Skip to content

wip: Introduces TextController.asMutableTextFieldValueState. #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

wip: Introduces TextController.asMutableTextFieldValueState. #1291

wants to merge 1 commit into from
+88 −8

Conversation

rjrjr
Copy link
Contributor

@rjrjr rjrjr commented Apr 9, 2025 •
edited
Loading

  • Waiting for the real author of this to get back from pat leave so we can debate replacing this:
  selectionStart: Int = textValue.length,
  selectionEnd: Int = selectionStart,

with this:

  selection: TextRange = TextRange(textValue.length)
  • Also probably should punch up the related UI test

@rjrjr rjrjr force-pushed the ray/no-more-ui-xp branch 2 times, most recently from 5f3193c to f306916 Compare April 9, 2025 22:57
Base automatically changed from ray/no-more-ui-xp to main April 9, 2025 23:48
@rjrjr rjrjr force-pushed the ray/more-mutable-state branch 2 times, most recently from 0b1b5b2 to 725ae31 Compare April 9, 2025 23:55
@rjrjr rjrjr force-pushed the ray/more-mutable-state branch from 725ae31 to ebd0c06 Compare April 10, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zach-klippenstein zach-klippenstein Awaiting requested review from zach-klippenstein zach-klippenstein will be requested when the pull request is marked ready for review zach-klippenstein is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rjrjr