Add serde::Serialize support for AisMessage #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| use serde_json::Error as SerdeError; | ||
|
|
||
| /// Serializes an `AisSentence` to JSON | ||
| pub fn serialize_to_json(sentence: &AisSentence) -> std::result::Result<String, SerdeError> { |
Check failure
Code scanning / clippy
failed to resolve: use of undeclared crate or module `std`
| use serde_json::Error as SerdeError; | ||
|
|
||
| /// Serializes an `AisSentence` to JSON | ||
| pub fn serialize_to_json(sentence: &AisSentence) -> std::result::Result<String, SerdeError> { |
Check failure
Code scanning / clippy
cannot find type `String` in this scope
| } | ||
|
|
||
| /// Deserializes an `AisSentence` from JSON | ||
| pub fn deserialize_from_json(json_data: &str) -> std::result::Result<AisSentence, SerdeError> { |
Check failure
Code scanning / clippy
failed to resolve: use of undeclared crate or module `std`
salsabiljb
force-pushed
the
serialize
branch
from
84c1d75 to
2cc0521
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
* This enables serialization of AIS messages into JSON format.
*This provides a readable string representation for each AisMessage variant.