Genericized (was test.check specific) compiler changes for downstream macro/ns resolution#805
Genericized (was test.check specific) compiler changes for downstream macro/ns resolution#805willcohen wants to merge 7 commits intosquint-cljs:mainfrom
Conversation
|
Eep. Stuff still changing underneath. This can happen later. |
|
Hehe sorry. I wasn't done with cljs.test but it's published now and no changes planned. |
358ee4f to
3293973
Compare
|
@borkdude this is now ready — took a little finagling after cljs.test settled. One more small proposed change to macros. I needed this for test.check because defspec bodies carry |
|
Rebased to sit on top of latest changes to squint. squint-cljs/cherry#186 updated as well. |
|
I'm not yet sure about this approach. clojure.test is a built-in namespace but clojure.test.check is an external dependency in ClojureScript so I don't think this change belongs in squint. |
|
Makes sense. I'll give it a shot. |
|
Here's a lighter touch approach to squint. I dropped the test.check specific stuff here, and cherry now handles that via env. Three new commits: First: "Populate :macro-aliases from :require :as so plain require finds built-in macros". Same content as before, rebased onto current main. |
…etry with :squint
|
To better decouple this from the various cherry PRs that depend on it, I've added red/green tests preceding each of the three commits, which should allow this to be self-contained. @borkdude |
|
Merged |
Reopening as followup to #803, which autoclosed when #802 merged. Needed for squint-cljs/cherry#184, which I similarly need to rebase and re-open based on this.
Please answer the following questions and leave the below in as part of your PR.
This PR corresponds to an issue with a clear problem statement.
This PR contains a test to prevent against future regressions
I have updated the CHANGELOG.md file with a description of the addressed issue.