Fix intersection type annotations #3459
Closed
+28
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simPod
force-pushed
the
hotfix-intersection-annotations
branch
3 times, most recently
from
9b54895 to
5aca79e
Compare
simPod
commented
Oct 25, 2021
| @@ -103,7 +103,6 @@ public function getErrorList() | |||
| 792 => 1, | |||
| 794 => 1, | |||
| 797 => 1, | |||
| 801 => 1, | |||
There was a problem hiding this comment.
This reported
Type hint "bar" missing for (Squiz.Commenting.FunctionComment.TypeHintMissing)
for
/**
* Function comment.
*
* @param $bar
* Comment here.
* @param ...
* Additional arguments here.
*
* @return
* Return value
*
*/
function foo($bar) {
}seems like a bug in test so I removed it
simPod
force-pushed
the
hotfix-intersection-annotations
branch
2 times, most recently
from
2bc3637 to
23c0d92
Compare
simPod
force-pushed
the
hotfix-intersection-annotations
branch
from
23c0d92 to
5aa4ee6
Compare
simPod
force-pushed
the
hotfix-intersection-annotations
branch
2 times, most recently
from
14ed8cf to
10e6e2e
Compare
|
@gsherwood Hi, just rebased and resolved conflicts for the second time. Should I pursue this? |
simPod
force-pushed
the
hotfix-intersection-annotations
branch
from
10e6e2e to
6567e47
Compare
simPod
force-pushed
the
hotfix-intersection-annotations
branch
from
6567e47 to
1f001c6
Compare
|
Thanks a lot, copied your regex to the FunctionCommentSniff we use in Drupal's Coder https://www.drupal.org/project/coder/issues/3303625 |
11 tasks
|
As PHPCSStandards/PHP_CodeSniffer#944 was merged into the new repository, I believe this PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2919 got stale so I rebased it and fixed