Skip to content

feat: update configuration files to enhance permissions and streamline Docker setup #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
narthanaj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: update configuration files to enhance permissions and streamline Docker setup #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .claude/settings.local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"Bash(wc:*)",
"Bash(cat:*)",
"Bash(head:*)",
"Bash(npm run format:*)"
"Bash(npm run format:*)",
"Bash(docker compose:*)"
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a redundant permission entry. The file already has Bash(docker-compose ps:*) and Bash(docker-compose logs:*) on lines 4-5, which use the hyphenated docker-compose command. This new entry uses the space-separated docker compose syntax.

While both syntaxes are valid (Docker Compose V2 uses docker compose without the hyphen), having both patterns is inconsistent. Consider either:

  1. Standardizing on one syntax (preferably docker compose as it's the modern V2 syntax)
  2. Updating all existing entries to use the same format
  3. If you need both for compatibility, use a single wildcard like Bash(docker*compose*:*) to cover both syntaxes

Copilot uses AI. Check for mistakes.
]
}
}
3 changes: 0 additions & 3 deletions apps/frontend/next.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ const API_URL = process.env.NEXT_PUBLIC_API_URL || 'http://localhost:8000';

const nextConfig: NextConfig = {
/* config options here */
experimental: {
turbopackUseSystemTlsCerts: true,
},
async rewrites() {
return [
{
Expand Down
1 change: 1 addition & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ services:
build:
context: .
dockerfile: Dockerfile
network: host
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The network: host directive in the build context is unusual and potentially problematic. This setting is meant for runtime containers, not build contexts. During the build process, Docker already has network access to download packages and dependencies from the internet without requiring host networking.

Adding network: host to the build context can:

  1. Reduce build portability across different environments
  2. Potentially expose the host network to build-time processes unnecessarily
  3. Not work correctly on all platforms (e.g., Docker Desktop for Mac/Windows)

If you're experiencing network issues during the Docker build (e.g., npm install failures, apt-get update failures), the issue is likely related to DNS configuration or corporate proxies, which should be addressed differently. Consider removing this line unless there's a specific documented reason for requiring host network access during the build.

Suggested change
network: host

Copilot uses AI. Check for mistakes.
image: resume-matcher
container_name: resume-matcher
ports:
Expand Down
Loading