Open
Conversation
Add French (Français) as a supported UI and content language for users in francophone countries (France, Switzerland, Belgium, etc.). Changes: - Add fr.json with complete French translations (620 keys, 1:1 parity with en.json) - Register 'fr' locale in i18n config with name and flag - Import French messages in the message loader - Add 'fr' to backend SUPPORTED_LANGUAGES list Closes srbhr#653
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (5 files)
Notes
|
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/backend/app/routers/config.py">
<violation number="1" location="apps/backend/app/routers/config.py:219">
P2: Schema and router constants are out of sync: `LanguageConfigResponse` has default `supported_languages=["en", "es", "zh", "ja"]` but router's `SUPPORTED_LANGUAGES` includes `["en", "es", "fr", "zh", "ja", "pt"]`. Update the schema default value and comments in `LanguageConfigRequest` to match the router's supported languages.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Update LanguageConfigResponse default and LanguageConfigRequest comments to include fr and pt, matching the router constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #653
Adds French (Français) as a fully supported UI and content language, enabling users in francophone countries (France, Switzerland, Belgium, Canada, etc.) to use Resume Matcher in their native language.
Changes
apps/frontend/messages/fr.jsonen.json)apps/frontend/i18n/config.ts'fr'locale with name "Français" and flagapps/frontend/lib/i18n/messages.tsapps/backend/app/routers/config.py"fr"toSUPPORTED_LANGUAGESTranslation notes
{count},{date},{status}, etc.) preservedTest plan
"fr"as a valid language in/config/languageendpointSummary by cubic
Adds full French (Français) support for both UI and generated content. Syncs backend language schema defaults to include fr and pt. Closes #653.
New Features
Bug Fixes
Written for commit f8c76f0. Summary will update on new commits.