fix: allow API key input for Ollama/local proxy providers#695
Open
shivangtanwar wants to merge 1 commit intosrbhr:mainfrom
Open
fix: allow API key input for Ollama/local proxy providers#695shivangtanwar wants to merge 1 commit intosrbhr:mainfrom
shivangtanwar wants to merge 1 commit intosrbhr:mainfrom
Conversation
The API key field was disabled for Ollama via `disabled={!requiresApiKey}`,
preventing users with proxied local models that require authentication
from entering a key. The save handler also unconditionally cleared the
key for non-requiresKey providers.
Changes:
- Remove `disabled` prop from API key input so it's always editable
- Unify save logic to send the key if provided, regardless of provider
- Include API key in test connection requests for all providers
- Keep the "(not required)" hint for Ollama to indicate it's optional
Closes srbhr#609
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewThis PR removes the
Key Observations
Files Reviewed (1 file)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disabled={!requiresApiKey}), preventing users with proxied local models (e.g. CLIProxyAPI) from entering an authentication token.api_keyto''for Ollama, discarding any key even if the user managed to enter one.Changes
disabled={!requiresApiKey}from the API key<Input>— field is always editablehandleSavelogic — sends the key if provided, sends empty if no key exists, regardless of providerhandleTestlogic — includes API key in test connection for all providersTest plan
Closes #609
Summary by cubic
Enables API key input for Ollama and local proxy providers so authenticated local setups can save and test connections. Fulfills #609 by sending the key when provided while keeping Ollama key optional.
Written for commit 3880b5e. Summary will update on new commits.