chore(ci): replace SourceKnight with setup-sp - #56
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the SourceKnight-based build (
maxime1907/action-sourceknight) with a native GitHub Actions workflow that clones dependencies directly and compiles withrumblefrog/setup-sp, following the pattern already validated insrcdslab/sm-plugin-AdminRoom.Plugin targets
addons/sourcemod/scripting/ConnectAnnounce.spaddons/sourcemod/plugins/ConnectAnnounce.smxDependencies
/addons→/addons(include copied toaddons/sourcemod/scripting/include)/addons→/addons(include copied toaddons/sourcemod/scripting/include)game/addons/sourcemod/scripting/include→/addons/sourcemod/scripting/include/addons→/addons(include copied toaddons/sourcemod/scripting/include)/addons→/addons(include copied toaddons/sourcemod/scripting/include)Note:
sourcemod(type:tar) was skipped, as expected — SourceMod itself is provided byrumblefrog/setup-sp@v1.3.1with version pinned to1.12.x.Packaging
The old workflow packaged
.sourceknight/package/*plus the rootcommon/folder. The newCreate packagestep replicates this using real, existing paths in the repo tree: it copies the compiled.smxintoaddons/sourcemod/plugins/and copies the rootcommon/directory (which containscommon/addons/sourcemod/configs/connect_announce/*.cfg) into the package root.Not locally validated
No local
spcomprun or dependency clone was performed as part of this change — paths were taken as declared insourceknight.yamland cross-checked against the repo's file tree only. The GitHub Actions run on this PR is the real signal for whether the build succeeds.Manual verification needed
sourceknight.yamldeclarations, not verified by cloning)..smx+common/) matches what downstream consumers expect; the previous packaging step used.sourceknight/package/*which may have included additional generated files not captured by this straightforward copy.