Skip to content

fix: use Database.Format for SQL escaping instead of SQL_EscapeString #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rushaway merged 1 commit into from
Aug 27, 2026
Merged

fix: use Database.Format for SQL escaping instead of SQL_EscapeString #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions addons/sourcemod/scripting/ConnectAnnounce.sp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public Plugin myinfo =
name = "Connect Announce",
author = "Neon + Botox + maxime1907 + .Rushaway",
description = "Connect Announcer",
version = "2.5.6",
version = "2.5.7",
url = ""
}

Expand Down Expand Up @@ -962,23 +962,19 @@ stock void SQLInsertUpdate_JoinClient(int client)
static int retries = 0;
char sClientName[32];
char sQuery[MAX_SQL_QUERY_LENGTH];
char sClientNameEscaped[32];
char sMessageEscaped[2 * MAX_CHAT_LENGTH + 1];
int userid = GetClientUserId(client);

FormatEx(sClientName, sizeof(sClientName), "%N", client);
SQL_EscapeString(g_hDatabase, sClientName, sClientNameEscaped, sizeof(sClientNameEscaped));
SQL_EscapeString(g_hDatabase, g_sClientJoinMessage[client], sMessageEscaped, sizeof(sMessageEscaped));

if (g_bSQLite)
{
Format(sQuery, sizeof(sQuery), "INSERT INTO `join` (`steamid`, `name`, `message`) VALUES ('%s', '%s', '%s') ON CONFLICT(`steamid`) DO UPDATE SET name=excluded.name, message=excluded.message;",
g_sAuthID[client], sClientNameEscaped, sMessageEscaped);
g_hDatabase.Format(sQuery, sizeof(sQuery), "INSERT INTO `join` (`steamid`, `name`, `message`) VALUES ('%s', '%s', '%s') ON CONFLICT(`steamid`) DO UPDATE SET name=excluded.name, message=excluded.message;",
g_sAuthID[client], sClientName, g_sClientJoinMessage[client]);
}
else
{
Format(sQuery, sizeof(sQuery), "INSERT INTO `join` (`steamid`, `name`, `message`) VALUES ('%s', '%s', '%s') ON DUPLICATE KEY UPDATE name='%s', message='%s';",
g_sAuthID[client], sClientNameEscaped, sMessageEscaped, sClientNameEscaped, sMessageEscaped);
g_hDatabase.Format(sQuery, sizeof(sQuery), "INSERT INTO `join` (`steamid`, `name`, `message`) VALUES ('%s', '%s', '%s') ON DUPLICATE KEY UPDATE name='%s', message='%s';",
g_sAuthID[client], sClientName, g_sClientJoinMessage[client], sClientName, g_sClientJoinMessage[client]);
}

if (DB_Connect())
Expand Down