(experimental) Add components: support for vSIM#3240
Open
kaelemc wants to merge 5 commits into
Open
Conversation
Member
Member
Author
|
Almost. will request your review when ready. |
Contributor
|
do we have a death wish? |
Member
Author
Yes, unless you can get me the 24.10.R1 srsim :) |
Member
Author
|
Seems to work well enough for me. |
Member
|
probably needs a doc addition |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3240 +/- ##
==========================================
+ Coverage 55.66% 55.91% +0.24%
==========================================
Files 233 235 +2
Lines 24034 24242 +208
==========================================
+ Hits 13379 13554 +175
- Misses 9198 9222 +24
- Partials 1457 1466 +9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of us who work with SR OS a lot got addicted a bit to the
components:, however this is currently SR-SIM only which is only 25.7 onwards.While some of the older versions of SR OS are within support, we sometimes need to use them in clab, thus meaning we have to use the vSIM which brings the fun of building the TiMOS line.
Instead we can parse
components:and let clab try to build it for us and make life easy.Few things are wonky since vSIMs are VMs, decided to put the
max_nics,cpuandramparameters as env vars under the slot.