Skip to content

(experimental) Add components: support for vSIM#3240

Open
kaelemc wants to merge 5 commits into
mainfrom
vsim-components
Open

(experimental) Add components: support for vSIM#3240
kaelemc wants to merge 5 commits into
mainfrom
vsim-components

Conversation

@kaelemc

@kaelemc kaelemc commented Jun 18, 2026

Copy link
Copy Markdown
Member

Some of us who work with SR OS a lot got addicted a bit to the components:, however this is currently SR-SIM only which is only 25.7 onwards.

While some of the older versions of SR OS are within support, we sometimes need to use them in clab, thus meaning we have to use the vSIM which brings the fun of building the TiMOS line.

Instead we can parse components: and let clab try to build it for us and make life easy.

Few things are wonky since vSIMs are VMs, decided to put the max_nics, cpu and ram parameters as env vars under the slot.

@hellt

hellt commented Jun 22, 2026

Copy link
Copy Markdown
Member

@kaelemc @FloSch62 is this good to go?

@kaelemc

kaelemc commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

Almost. will request your review when ready.

@sacckth

sacckth commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

do we have a death wish?

@FloSch62 FloSch62 marked this pull request as draft June 24, 2026 16:23
@kaelemc

kaelemc commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

do we have a death wish?

Yes, unless you can get me the 24.10.R1 srsim :)

@kaelemc kaelemc marked this pull request as ready for review July 1, 2026 10:43
@kaelemc

kaelemc commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Seems to work well enough for me.

@kaelemc kaelemc requested review from FloSch62 and hellt July 1, 2026 10:58
@hellt

hellt commented Jul 1, 2026

Copy link
Copy Markdown
Member

probably needs a doc addition

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.95402% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.91%. Comparing base (f8540cd) to head (c478c24).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
nodes/vr_sros/interface_map.go 85.10% 9 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3240      +/-   ##
==========================================
+ Coverage   55.66%   55.91%   +0.24%     
==========================================
  Files         233      235       +2     
  Lines       24034    24242     +208     
==========================================
+ Hits        13379    13554     +175     
- Misses       9198     9222      +24     
- Partials     1457     1466       +9     
Files with missing lines Coverage Δ
nodes/vr_sros/variant.go 100.00% <100.00%> (ø)
nodes/vr_sros/vr-sros.go 26.92% <100.00%> (-0.62%) ⬇️
nodes/vr_sros/interface_map.go 85.10% <85.10%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants