Skip to content

corrected threshold_2 for event a5 and allow event triggered meas reports #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions apps/units/o_cu_cp/cu_cp/cu_cp_unit_config_validator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,6 @@ static bool validate_mobility_appconfig(gnb_id_t gnb_id, const cu_cp_unit_mobili
cell.periodic_report_cfg_id.value());
return false;
}
// Check that for the serving cell only periodic reports are configured.
if (report_cfg_ids_to_report_type.at(cell.periodic_report_cfg_id.value()) != "periodical") {
fmt::print("For the serving cell only periodic reports are allowed\n");
return false;
}
}

// Check if cell is an external managed cell.
Expand Down
2 changes: 1 addition & 1 deletion lib/rrc/ue/rrc_measurement_types_asn1_converters.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -881,7 +881,7 @@ srsran::srs_cu_cp::event_triggered_report_cfg_to_rrc_asn1(const rrc_event_trigge
if (event_id.id == rrc_event_id::event_id_t::a5) {
auto& asn1_event_a5 = asn1_event_trigger_cfg.event_id.set_event_a5();
meas_trigger_quant_to_rrc_asn1(asn1_event_a5.a5_thres1, event_id.meas_trigger_quant_thres_or_offset.value());
meas_trigger_quant_to_rrc_asn1(asn1_event_a5.a5_thres2, event_id.meas_trigger_quant_thres_or_offset.value());
meas_trigger_quant_to_rrc_asn1(asn1_event_a5.a5_thres2, event_id.meas_trigger_quant_thres_2.value());
asn1_event_a5.report_on_leave = event_id.report_on_leave;
asn1_event_a5.hysteresis = event_id.hysteresis;
asn1::number_to_enum(asn1_event_a5.time_to_trigger, event_id.time_to_trigger);
Expand Down