Add autostart option to settings window#747
Open
lomacanderson wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Summary
This PR allows the user (in the launcher build) to toggle Autostart from the advanced tab of settings menu instead of only being able to from the setup assistant. Wording of strings was copied from the setup assistant.
Related issue
Fixes #732
Type of change
Testing
I tested to make sure the build worked, made sure the UI was consistant, then using breakpoints I made sure the already-existing autostart get/set functions were firing. Upon opening and closing the build, the toggled state was consistant. I also used hardcoding with the already-existing IsLauncher variable to make sure the option would be hidden with non-launcher builds.
Screenshots or recordings