Skip to content

Port Inline Gas Filter - #1073

Merged
ShadesMars merged 4 commits into
ss14Starlight:starlight-devfrom
neurovermi:trinary_inline
Jul 29, 2025
Merged

Port Inline Gas Filter#1073
ShadesMars merged 4 commits into
ss14Starlight:starlight-devfrom
neurovermi:trinary_inline

Conversation

@neurovermi

Copy link
Copy Markdown
Contributor

Short description

This PR adds an inline gas filter based on space-wizards/space-station-14#28359. Rather than moving gas from the input to the unfiltered output, the device directly connects the input and unfiltered output as a single pipenet (analagous to a manual valve), while still allowing for the filtering of gas by volume, which operates identically to the existing filter device with the same pressure limit of 4500 kPa.

Why we need to add this

This is a QoL atmos device requested by experienced atmos players to handle the common occurence of needing a filter that doesn't split the pipenets to which it is attached, which would normally require 8 resources and 3 tiles of space. This device will allow this common structure to be more compact while less wasteful of resources.

While the original PR kept the resource usage at 8 (and construction time at 3 seconds), I have elected to change this to be in line with other trinary devices, both for consistency and for the fact that it is a different device with a different purpose. The existing blocking filter still has a clearly defined purpose and role, separate from the inline filter - neither is superior to the other in general.

Follow-up work:

  • I dislike that the sprites taken from the ported PR still indicate linear flow of gas of some kind, which is not the case. This isn't a PR-killer, but updating of the sprites to reflect the nature of the device as a non-blocking filter in the near future would be preferable.
  • In the event of wizden making the switch to flowmos, this device could be repurposed to serve as a bi-directional non-blocking filter.

Media (Video/Screenshots)

inlinefiltertrinary

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the Starlight Fork License and grant permission for use in this repository under its conditions.

Changelog
🆑 neurovermi

  • add: Inline Gas Filter - an atmos device that filters gas without splitting the pipenet in two.

Similar to the regular filter except it doesnt split the pipenet. Pressure limit only applies to the filtered output node.
@github-actions github-actions Bot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Changes: Sprites and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 21, 2025
@Conflee

Conflee commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Sprite looks good I think, though it might get confused for the other two? That's an issue with the Filter and Mixer already but having a third makes it even moreso.

For now sprites approved, though if it does cause confusion I may look into respriting all three to have more obvious indicators of which do what (more obvious than just the + and - icons)

@neurovermi

Copy link
Copy Markdown
Contributor Author

Sprite looks good I think, though it might get confused for the other two? That's an issue with the Filter and Mixer already but having a third makes it even moreso.

The arrows and sprite animations do alleviate that somewhat, but I am very biased as I have spent a lot of time staring at these sprites. This may get even worse if we add T-Mixers as well. It might be nice to have clearer body shapes that better distinguish the device categories, like how scrubbers are round and vents are square. But I think first and foremost the lighting detail on the sprites should clearly indicate the presence and direction of gas flow in the device.

@neurovermi
neurovermi changed the base branch from Starlight to starlight-dev July 23, 2025 03:42
@ShadesMars
ShadesMars merged commit b5e8139 into ss14Starlight:starlight-dev Jul 29, 2025
14 checks passed
github-actions Bot added a commit that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants