Skip to content

Refinery Real Actual Omega Push - #5081

Closed
OrangeJuiceGoose wants to merge 39 commits into
ss14Starlight:starlight-devfrom
OrangeJuiceGoose:starlight-dev
Closed

Refinery Real Actual Omega Push#5081
OrangeJuiceGoose wants to merge 39 commits into
ss14Starlight:starlight-devfrom
OrangeJuiceGoose:starlight-dev

Conversation

@OrangeJuiceGoose

@OrangeJuiceGoose OrangeJuiceGoose commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Short description

Adds files for "Refinery Starport" station to game files. Hopefully allowing for in game testing.

Why we need to add this

Large station with lots of unique design features for departmental interplay. PR mostly is for bugfixing and testing and review by Caws. New PR because the old one was throwing errors due to manual uploading of files.

Media (Video/Screenshots)

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 STARLIGHT TEAM

  • add: Refinery Starport map files.

@OrangeJuiceGoose
OrangeJuiceGoose requested a review from a team July 11, 2026 01:21
@github-actions github-actions Bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XL Changes: Map S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. Changes: No C# Changes: Prototypes and removed size/XL labels Jul 11, 2026
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 87408c72-46f0-448d-bc7f-547318e8a308

📥 Commits

Reviewing files that changed from the base of the PR and between 2d09600 and acf6074.

📒 Files selected for processing (2)
  • Resources/Maps/_Starlight/Stations/Refinery.yml
  • Resources/Prototypes/_Starlight/Maps/refinery.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • Resources/Prototypes/_Starlight/Maps/refinery.yml

📝 Walkthrough

Summary

Adds the StarlightRefinery map prototype for in-game testing of the Refinery Starport station.

The prototype defines the station identity, player limits, emergency shuttle settings, and available jobs across service, engineering, medical, science, security, supply, civilian, silicon, law, and representative roles.

User impact

Players can test the Refinery Starport map with its department-specific layout and role distribution.

Notable changes

  • Adds Resources/Prototypes/_Starlight/Maps/refinery.yml.
  • Registers the StarlightRefinery map.
  • Adds the map name and station configuration.
  • Defines emergency shuttle behavior.
  • Defines supported job categories and limits.

Risk areas

  • Incorrect job definitions can make roles unavailable or unbalanced.
  • Incorrect map identity or shuttle settings can affect map selection and emergency evacuation.
  • The station's gameplay layout requires in-game review after the earlier manual-upload issues.

Guideline gaps

  • The PR context does not state why the map belongs in the Starlight-specific prototype path.
  • The PR context does not identify Starlight ownership or add ownership comments.
  • The PR context does not describe localization changes for the new station name.
  • The PR context does not state whether the map introduces breaking changes.
  • The PR context does not document the design impact of the department-specific layout.

Walkthrough

Adds the StarlightRefinery map prototype with map metadata, station naming, an emergency shuttle reference, and job availability ranges across configured departments and representative roles.

Changes

Starlight Refinery Map

Layer / File(s) Summary
Map identity and station setup
Resources/Prototypes/_Starlight/Maps/refinery.yml
Defines the map name, path, player limits, station naming generator, and refinery emergency shuttle reference.
Station job availability
Resources/Prototypes/_Starlight/Maps/refinery.yml
Adds job availability ranges for service, engineering, medical, science, security, supply, civilian, silicon, law, and representative roles.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: cawsforconcern

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains that the PR adds Refinery Starport map files for in-game testing and review.
Title check ✅ Passed The title identifies the Refinery change, but its wording is informal and does not clearly state that the PR adds map files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 11, 2026
@CawsForConcern CawsForConcern added size/XL T: New Content and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 11, 2026
@CawsForConcern
CawsForConcern self-requested a review July 11, 2026 02:21
@CawsForConcern CawsForConcern self-assigned this Jul 11, 2026
@CawsForConcern

Copy link
Copy Markdown
Contributor

Just a tip for the checkboxes:

## Checks
<!-- check boxes for faster reviewing of your PR -->

- [ ] I do not require assistance to complete the PR.
- [x ] Before posting/requesting review of a PR, I have verified that the changes work.
- [x ] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
- [x ] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions.

Fill it out like this:
- [x]

And not like this:
- [x ]

@github-actions github-actions Bot removed the S: Awaiting Changes Status: Changes are required before another review can happen label Jul 24, 2026

@CawsForConcern CawsForConcern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test fails real

there's a bunch of mapInit: true stuff saved in the map - you need to find the entities causing these and delete/replace them.

- proto: ActionToggleBlock
  entities:
  - uid: 4
    mapInit: true
    paused: true
    components:
    - type: Transform
      parent: 3
    - type: Action
      originalIconColor: '#FFFFFFFF'
      container: 3
- proto: ActionToggleInternals
  entities:
  - uid: 6
    mapInit: true
    paused: true
    components:
    - type: Transform
      parent: 5
    - type: Action
      originalIconColor: '#FFFFFFFF'
      container: 5
  - uid: 8
    mapInit: true
    paused: true
    components:
    - type: Transform
      parent: 7
    - type: Action
      originalIconColor: '#FFFFFFFF'
      container: 7
  - uid: 10
    mapInit: true
    paused: true
    components:
    - type: Transform
      parent: 9
    - type: Action
      originalIconColor: '#FFFFFFFF'
      container: 9
  - uid: 12
    mapInit: true
    paused: true
    components:
    - type: Transform
      parent: 11
    - type: Action
      originalIconColor: '#FFFFFFFF'
      container: 11
- proto: ActionToggleLight
  entities:
  - uid: 14
    mapInit: true
    paused: true
    components:
    - type: Transform
      parent: 13
    - type: Action
      originalIconColor: '#FFFFFFFF'
      container: 13

@CawsForConcern CawsForConcern added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 26, 2026

@CawsForConcern CawsForConcern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add your map to Content.IntegrationTests\Tests\Power\StationPowerTests.cs as well

@github-actions github-actions Bot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@github-actions

Copy link
Copy Markdown
Contributor

Content + Integration Test Results

Summary:

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️
1688 1662 6 20

Failed Tests:

Failed Tests ❌ Fail Message
❌ GameMapsLoadableTest("StarlightRefinery") Multiple failures or warnings in test:
1) Failed to load /Maps/_Starlight/Shuttles/emergency_spacemall.yml
Assert.That(mapLoader.TryLoadGrid(shuttleMap, shuttlePath, out var shuttle), Is.True)
Expected: True
But was: False

at Content.IntegrationTests.Tests.PostMapInitTest.<>c__DisplayClass21_0.b__0() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/PostMapInitTest.cs:line 440
at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.SingleThreadRunUntilEmpty() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1257
at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.Run() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1221
at Robust.UnitTesting.RobustIntegrationTest.ServerIntegrationInstance._serverMain() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 771
at System.Threading.Thread.StartHelper.Callback(Object state)

2) SERVER: 22.927s [ERRO] system.map_loader: File not found: /Maps/_Starlight/Shuttles/emergency_spacemall.yml Exception:
at Robust.UnitTesting.Pool.TestPair`2.ReportErrorLogs() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 25
at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 41
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose()
at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 146
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync()
at Content.IntegrationTests.Fixtures.GameTest.DoTeardown() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Fixtures/GameTest.cs:line 262
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Content.IntegrationTests.Fixtures.GameTest.DoTeardown()

❌ GameMapsLoadableTest("StarlightRefinery") Multiple failures or warnings in test:
1) Failed to load /Maps/_Starlight/Shuttles/emergency_spacemall.yml
Assert.That(mapLoader.TryLoadGrid(shuttleMap, shuttlePath, out var shuttle), Is.True)
Expected: True
But was: False

at Content.IntegrationTests.Tests.PostMapInitTest.<>c__DisplayClass21_0.b__0() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/PostMapInitTest.cs:line 440
at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.SingleThreadRunUntilEmpty() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1257
at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.Run() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1221
at Robust.UnitTesting.RobustIntegrationTest.ServerIntegrationInstance._serverMain() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 771
at System.Threading.Thread.StartHelper.Callback(Object state)

2) SERVER: 24.198s [ERRO] system.map_loader: File not found: /Maps/_Starlight/Shuttles/emergency_spacemall.yml Exception:
at Robust.UnitTesting.Pool.TestPair`2.ReportErrorLogs() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 25
at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 41
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose()
at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 146
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync()
at Content.IntegrationTests.Fixtures.GameTest.DoTeardown() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Fixtures/GameTest.cs:line 262
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Content.IntegrationTests.Fixtures.GameTest.DoTeardown()

❌ GameMapsLoadableTest("StarlightRefinery") SERVER: 9.764s [ERRO] system.map_loader: File not found: /Maps/_Starlight/Shuttles/emergency_spacemall.yml Exception:
❌ TestAllServerPrototypesAreSerializable Multiple failures or warnings in test:
1) Error when validating server prototype (GameMapPrototype, StarlightRefinery). Errors:
- File not found. (/Maps/_Starlight/Shuttles/emergency_spacemall.yml)

at Content.IntegrationTests.Tests.PrototypeTests.PrototypeTests.<>c__DisplayClass2_0.b__1() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/PrototypeTests/PrototypeTests.cs:line 59
at NUnit.Framework.Assert.Multiple(TestDelegate testDelegate)
at Content.IntegrationTests.Tests.PrototypeTests.PrototypeTests.SaveThenValidatePrototype(IntegrationInstance instance, String instanceId, TestEntityUidContext ctx) in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/PrototypeTests/PrototypeTests.cs:line 48
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)

2) Test was dirty-disposed.
at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 44
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose()
at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 146
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync()
at Content.IntegrationTests.Fixtures.GameTest.DoTeardown() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Fixtures/GameTest.cs:line 262
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Content.IntegrationTests.Fixtures.GameTest.DoTeardown()

❌ TestAllServerPrototypesAreSerializable Multiple failures or warnings in test:
1) Error when validating server prototype (GameMapPrototype, StarlightRefinery). Errors:
- File not found. (/Maps/_Starlight/Shuttles/emergency_spacemall.yml)

at Content.IntegrationTests.Tests.PrototypeTests.PrototypeTests.<>c__DisplayClass2_0.b__1() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/PrototypeTests/PrototypeTests.cs:line 59
at NUnit.Framework.Assert.Multiple(TestDelegate testDelegate)
at Content.IntegrationTests.Tests.PrototypeTests.PrototypeTests.SaveThenValidatePrototype(IntegrationInstance instance, String instanceId, TestEntityUidContext ctx) in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/PrototypeTests/PrototypeTests.cs:line 48
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)

2) Test was dirty-disposed.
at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 44
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose()
at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 146
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync()
at Content.IntegrationTests.Fixtures.GameTest.DoTeardown() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Fixtures/GameTest.cs:line 262
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Content.IntegrationTests.Fixtures.GameTest.DoTeardown()

❌ TestAllServerPrototypesAreSerializable Multiple failures or warnings in test:
1) Error when validating server prototype (GameMapPrototype, StarlightRefinery). Errors:
- File not found. (/Maps/_Starlight/Shuttles/emergency_spacemall.yml)

at Content.IntegrationTests.Tests.PrototypeTests.PrototypeTests.<>c__DisplayClass2_0.b__1() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/PrototypeTests/PrototypeTests.cs:line 59
at NUnit.Framework.Assert.Multiple(TestDelegate testDelegate)
at Content.IntegrationTests.Tests.PrototypeTests.PrototypeTests.SaveThenValidatePrototype(IntegrationInstance instance, String instanceId, TestEntityUidContext ctx) in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/PrototypeTests/PrototypeTests.cs:line 48
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.AsyncStateMachineBox`1.ExecutionContextCallback(Object s)

2) Test was dirty-disposed.
at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 44
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose()
at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 146
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync()
at Content.IntegrationTests.Fixtures.GameTest.DoTeardown() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Fixtures/GameTest.cs:line 262
at Content.IntegrationTests.Fixtures.GameTest.DoTeardown()
at InvokeStub_GameTest.DoTeardown(Object, Object, IntPtr*)

Github Test Reporter by CTRF 💚

@OrangeJuiceGoose

Copy link
Copy Markdown
Contributor Author

I am going to close this PR in order to try and fix errors with a fresh branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: Map Changes: No C# Changes: Prototypes S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/XL T: New Content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants