New Shuttle: Harm's Space Truck - #5311
Conversation
📝 WalkthroughWalkthroughAdds the SpaceTruck shuttle map, registers it in the shipyard catalog, and includes it in the existing ChangesSpaceTruck shuttle
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ShipyardCatalog
participant SpaceTruckMap
participant GridPowerTests
participant TestGridApcLoad
ShipyardCatalog->>SpaceTruckMap: references shuttlePath
GridPowerTests->>SpaceTruckMap: loads map from _gridPaths
GridPowerTests->>TestGridApcLoad: runs APC-load case
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 6 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (6 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Maps/_Starlight/Shuttles/SpaceTruck.yml`:
- Around line 2114-2123: Update GasValve uid 208 in the shuttle configuration so
the cargo hold and scrubbers remain connected to the passive red-line vent
during normal operation, while preserving the valve’s intended placement and
other component settings.
- Around line 1173-1178: Update the Transform position for ButtonFrameGrey uid
131 to align with its decorated SignalButtonDirectional uid 227 at -1.5,-5.5,
matching the half-tile coordinate convention used by neighboring frames uid 130
and 132.
- Around line 2026-2037: Update the entity with uid 199 by re-anchoring its
Transform and removing the serialized Physics override, matching neighboring
gas-pipe entities. The resulting pipe must be anchored and no longer use a
Dynamic body, while preserving its existing position, rotation, parent, and
AtmosPipeColor.
In `@Resources/Prototypes/_Starlight/Catalog/default_shipyard_catalog.yml`:
- Line 112: Update the description value in the catalog entry to use the file’s
established “small sized” wording and add a space after the ellipsis before “no
one knows why.” Preserve the rest of the flavour text unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 9a87106f-7a43-46bc-b9f3-ff7c67a907e2
📒 Files selected for processing (3)
Content.IntegrationTests/Tests/_Starlight/Power/GridPowerTests.csResources/Maps/_Starlight/Shuttles/SpaceTruck.ymlResources/Prototypes/_Starlight/Catalog/default_shipyard_catalog.yml
- And add Air Alarms and sensors
|
Right, test StartRoundTest on Shard 6 failed. Would be great to know how to fix that problem. |
|
Note The previously reviewed commits are no longer reachable (likely due to a force-push or rebase), so CodeRabbit is performing a full review instead of an incremental one. This review may take a little longer. |
CawsForConcern
left a comment
There was a problem hiding this comment.
review
- ditch the manual valve for the scrubber at the front of the cab - its noisy and I can't think of a use case where you want the scrubber to not scrub (and if you didn't you'd just use the air alarm)
- add some directional fans like this to prevent the rear from leaking air when docking due to the quirky diagonal thruster placement
- delete the bed and replace it, then re-save the grid - you have a sleep action saved in the shuttle's
.yml
getting rid of this is as easy as deleting the bed, placing a new one, and doing a new savegrid
- proto: ActionSleep
entities:
- uid: 120
components:
- type: Transform
parent: 119
- type: Action
originalIconColor: '#FFFFFFFF'
container: 119|
also, i'd suggest putting the bed in the middle and putting the gyro on the right - makes it easier to reach the air alarm since beds can be walked over |
2d22bff
## Short description <!-- What do you propose to change with your PR? --> Adding new shuttle "Harm's Space Truck" to Shipyard Console for $15050 Spesos. Current Size: 20x5. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Because it looks cute.... and it also has an IFF console. I think this allows an antagonist ($20K bribe thief as a main example) to interact with the Shipyard Console. I think this will make a nice RP with a Captain to convince him to get the Space Truck or steal the Cap's ID to buy one. Since buying a shuttle makes a Command-Only announcement that a shuttle was bought, this gives some time for Cap and security to confiscate the Space Truck before someone else does. It also gives syndicate agents a solid "getaway" vehicle for hostage negotiation or other objectives. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="220" height="859" alt="image" src="https://github.com/user-attachments/assets/5a7c44aa-5765-4a74-8751-dce18d73f956" /> <img width="215" height="857" alt="image" src="https://github.com/user-attachments/assets/13b8600d-9e2d-4422-adf8-f1b68a1d06f9" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Hot Mic - add: Added a new Shuttle to Shipyard Console; "Harm's Space Truck", a $15050 Spesos Space Truck for classic truck hauling across the known sectors. It also carries an IFF console for whatever reason. Size: 20x5.

Short description
Adding new shuttle "Harm's Space Truck" to Shipyard Console for $15050 Spesos. Current Size: 20x5.
Why we need to add this
Because it looks cute.... and it also has an IFF console. I think this allows an antagonist ($20K bribe thief as a main example) to interact with the Shipyard Console. I think this will make a nice RP with a Captain to convince him to get the Space Truck or steal the Cap's ID to buy one. Since buying a shuttle makes a Command-Only announcement that a shuttle was bought, this gives some time for Cap and security to confiscate the Space Truck before someone else does. It also gives syndicate agents a solid "getaway" vehicle for hostage negotiation or other objectives.
Media (Video/Screenshots)
Checks
Changelog
🆑 Hot Mic