Skip to content

New Shuttle: Harm's Space Truck - #5311

Merged
redmushie merged 7 commits into
ss14Starlight:starlight-devfrom
Dennisz125:Space-Trucker
Jul 31, 2026
Merged

New Shuttle: Harm's Space Truck#5311
redmushie merged 7 commits into
ss14Starlight:starlight-devfrom
Dennisz125:Space-Trucker

Conversation

@Dennisz125

@Dennisz125 Dennisz125 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Short description

Adding new shuttle "Harm's Space Truck" to Shipyard Console for $15050 Spesos. Current Size: 20x5.

Why we need to add this

Because it looks cute.... and it also has an IFF console. I think this allows an antagonist ($20K bribe thief as a main example) to interact with the Shipyard Console. I think this will make a nice RP with a Captain to convince him to get the Space Truck or steal the Cap's ID to buy one. Since buying a shuttle makes a Command-Only announcement that a shuttle was bought, this gives some time for Cap and security to confiscate the Space Truck before someone else does. It also gives syndicate agents a solid "getaway" vehicle for hostage negotiation or other objectives.

Media (Video/Screenshots)

image image

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 Hot Mic

  • add: Added a new Shuttle to Shipyard Console; "Harm's Space Truck", a $15050 Spesos Space Truck for classic truck hauling across the known sectors. It also carries an IFF console for whatever reason. Size: 20x5.

@Dennisz125
Dennisz125 requested a review from a team July 25, 2026 07:29
@github-actions github-actions Bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. Changes: Map Changes: C# Changes: Prototypes size/L labels Jul 25, 2026
@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds the SpaceTruck shuttle map, registers it in the shipyard catalog, and includes it in the existing TestGridApcLoad integration-test cases.

Changes

SpaceTruck shuttle

Layer / File(s) Summary
Define and catalog SpaceTruck
Resources/Maps/_Starlight/Shuttles/SpaceTruck.yml, Resources/Prototypes/_Starlight/Catalog/default_shipyard_catalog.yml
Adds the complete SpaceTruck map and a shipyard vessel entry referencing it.
Add APC-load test coverage
Content.IntegrationTests/Tests/_Starlight/Power/GridPowerTests.cs
Adds SpaceTruck to the _gridPaths test-case source for TestGridApcLoad.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant ShipyardCatalog
  participant SpaceTruckMap
  participant GridPowerTests
  participant TestGridApcLoad
  ShipyardCatalog->>SpaceTruckMap: references shuttlePath
  GridPowerTests->>SpaceTruckMap: loads map from _gridPaths
  GridPowerTests->>TestGridApcLoad: runs APC-load case
Loading

Possibly related PRs

Suggested reviewers: redmushie

🚥 Pre-merge checks | ✅ 6 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Avoid Service Locator ⚠️ Warning PR adds direct IoCManager.Resolve in ParticlePanicCommand and static Log.Error/Warning in particle systems, violating explicit-dependency guidance. Replace global resolves/logging with injected dependencies or passed-in services; keep IoCManager.InjectDependencies() only where UI requires it.
No Hardcoded Ecs Parameters ❓ Inconclusive placeholder pending
✅ Passed checks (6 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Magic Numbers ✅ Passed PASS: the only code-side literal is RunSeconds(2), an allowed obvious delay; the other numbers live in excluded YAML resource/prototype files.
Title check ✅ Passed The title clearly summarizes the main change: adding the new Harm's Space Truck shuttle.
Description check ✅ Passed The description matches the changeset by explaining the new shuttle, its price, size, and Shipyard Console addition.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Resources/Maps/_Starlight/Shuttles/SpaceTruck.yml`:
- Around line 2114-2123: Update GasValve uid 208 in the shuttle configuration so
the cargo hold and scrubbers remain connected to the passive red-line vent
during normal operation, while preserving the valve’s intended placement and
other component settings.
- Around line 1173-1178: Update the Transform position for ButtonFrameGrey uid
131 to align with its decorated SignalButtonDirectional uid 227 at -1.5,-5.5,
matching the half-tile coordinate convention used by neighboring frames uid 130
and 132.
- Around line 2026-2037: Update the entity with uid 199 by re-anchoring its
Transform and removing the serialized Physics override, matching neighboring
gas-pipe entities. The resulting pipe must be anchored and no longer use a
Dynamic body, while preserving its existing position, rotation, parent, and
AtmosPipeColor.

In `@Resources/Prototypes/_Starlight/Catalog/default_shipyard_catalog.yml`:
- Line 112: Update the description value in the catalog entry to use the file’s
established “small sized” wording and add a space after the ellipsis before “no
one knows why.” Preserve the rest of the flavour text unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 9a87106f-7a43-46bc-b9f3-ff7c67a907e2

📥 Commits

Reviewing files that changed from the base of the PR and between 4872c8e and b1c553f.

📒 Files selected for processing (3)
  • Content.IntegrationTests/Tests/_Starlight/Power/GridPowerTests.cs
  • Resources/Maps/_Starlight/Shuttles/SpaceTruck.yml
  • Resources/Prototypes/_Starlight/Catalog/default_shipyard_catalog.yml

Comment thread Resources/Maps/_Starlight/Shuttles/SpaceTruck.yml
Comment thread Resources/Maps/_Starlight/Shuttles/SpaceTruck.yml Outdated
Comment thread Resources/Maps/_Starlight/Shuttles/SpaceTruck.yml
Comment thread Resources/Prototypes/_Starlight/Catalog/default_shipyard_catalog.yml Outdated
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 25, 2026
- And add Air Alarms and sensors
@CawsForConcern CawsForConcern added T: New Content S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 25, 2026
@Dennisz125

Copy link
Copy Markdown
Contributor Author

Right, test StartRoundTest on Shard 6 failed. Would be great to know how to fix that problem.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Note

The previously reviewed commits are no longer reachable (likely due to a force-push or rebase), so CodeRabbit is performing a full review instead of an incremental one. This review may take a little longer.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 29, 2026

@CawsForConcern CawsForConcern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

  • ditch the manual valve for the scrubber at the front of the cab - its noisy and I can't think of a use case where you want the scrubber to not scrub (and if you didn't you'd just use the air alarm)
Image
  • add some directional fans like this to prevent the rear from leaking air when docking due to the quirky diagonal thruster placement
Image
  • delete the bed and replace it, then re-save the grid - you have a sleep action saved in the shuttle's .yml

getting rid of this is as easy as deleting the bed, placing a new one, and doing a new savegrid

- proto: ActionSleep
  entities:
  - uid: 120
    components:
    - type: Transform
      parent: 119
    - type: Action
      originalIconColor: '#FFFFFFFF'
      container: 119

@CawsForConcern

Copy link
Copy Markdown
Contributor

also, i'd suggest putting the bed in the middle and putting the gyro on the right - makes it easier to reach the air alarm since beds can be walked over

@CawsForConcern CawsForConcern added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 30, 2026
@CawsForConcern CawsForConcern mentioned this pull request Jul 30, 2026
4 tasks
@github-actions github-actions Bot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Jul 30, 2026
@Dennisz125

Copy link
Copy Markdown
Contributor Author
image

@CawsForConcern CawsForConcern added S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 30, 2026
@redmushie redmushie self-assigned this Jul 31, 2026
@redmushie
redmushie added this pull request to the merge queue Jul 31, 2026
Merged via the queue into ss14Starlight:starlight-dev with commit 2d22bff Jul 31, 2026
30 checks passed
starlightgithub Bot added a commit that referenced this pull request Jul 31, 2026
@Dennisz125
Dennisz125 deleted the Space-Trucker branch July 31, 2026 19:14
Limerent-Sun pushed a commit to Blimpuf-Station/BlimpufStation that referenced this pull request Aug 5, 2026
## Short description
<!-- What do you propose to change with your PR? -->
Adding new shuttle "Harm's Space Truck" to Shipyard Console for $15050
Spesos. Current Size: 20x5.

## Why we need to add this
<!-- What is the reason for adding these changes? Please post links to
Discussions as well as Bug Reports here. Please describe how this will
change the game balance. -->
Because it looks cute.... and it also has an IFF console. I think this
allows an antagonist ($20K bribe thief as a main example) to interact
with the Shipyard Console. I think this will make a nice RP with a
Captain to convince him to get the Space Truck or steal the Cap's ID to
buy one. Since buying a shuttle makes a Command-Only announcement that a
shuttle was bought, this gives some time for Cap and security to
confiscate the Space Truck before someone else does. It also gives
syndicate agents a solid "getaway" vehicle for hostage negotiation or
other objectives.

## Media (Video/Screenshots)
<!--
If your PR contains in-game changes you must provide screenshots/videos
of the changes.
-->
<img width="220" height="859" alt="image"
src="https://github.com/user-attachments/assets/5a7c44aa-5765-4a74-8751-dce18d73f956"
/>
<img width="215" height="857" alt="image"
src="https://github.com/user-attachments/assets/13b8600d-9e2d-4422-adf8-f1b68a1d06f9"
/>

## Checks
<!-- check boxes for faster reviewing of your PR -->

- [x] I do not require assistance to complete the PR.
- [x] Before posting/requesting review of a PR, I have verified that the
changes work.
- [x] I have added screenshots/videos of the changes, or this PR does
not change in-game mechanics.
- [x] I affirm that my changes are licensed under the [MIT
License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT)
and grant permission for use in this repository under its conditions.

**Changelog**
<!--
If you want the players to know about changes made in this PR, specify
them using the template outside the comment. Short and informative.

:cl: STARLIGHT TEAM
- add: Added Starlight.
- remove: Removed SS13.
- tweak: Changed SS14.
- fix: Fixed Rinary.
-->
:cl: Hot Mic
- add: Added a new Shuttle to Shipyard Console; "Harm's Space Truck", a
$15050 Spesos Space Truck for classic truck hauling across the known
sectors. It also carries an IFF console for whatever reason. Size: 20x5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: C# Changes: Map Changes: Prototypes S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. size/L T: New Content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants