Adds dough to the cookbook + Functionality for listing chemical reactions as recipes. - #5354
Conversation
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughDough guidebook metadata is added to food reactions, matching reactions are rendered by microwave guidebook controls, and new guidebook hierarchy, localization, and XML entries expose the Dough recipe section. ChangesDough reaction guidebook
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant GuidebookEntry
participant GuideMicrowaveGroupEmbed
participant ReactionPrototype
participant GuideMicrowaveEmbed
GuidebookEntry->>GuideMicrowaveGroupEmbed: create Dough group entries
GuideMicrowaveGroupEmbed->>ReactionPrototype: filter with InGuidebookGroup(group)
GuideMicrowaveGroupEmbed->>GuideMicrowaveEmbed: construct reaction control
GuideMicrowaveEmbed->>ReactionPrototype: read effects and reactants
GuideMicrowaveEmbed-->>GuidebookEntry: render reaction recipe
Suggested reviewers: 🚥 Pre-merge checks | ✅ 7 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (7 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Content.Client/Guidebook/Controls/GuideMicrowaveEmbed.xaml.cs`:
- Around line 261-269: Replace the hardcoded "(catalyst)" text in the
reactant.Catalyst branch of the liquidNameMsg construction with a Fluent
localization key, using the established localization/formatting mechanism to
render the localized catalyst label while preserving the existing spacing and
bold-name formatting.
In `@Content.Shared/_Starlight/Chemistry/Reaction/ReactionPrototype.Starlight.cs`:
- Line 3: Move the partial extension for ReactionPrototype from the _Starlight
directory into the canonical Chemistry/Reaction directory, keeping the filename
prefixed with Starlight. Preserve the namespace
Content.Shared.Chemistry.Reaction; unchanged so it remains part of the existing
ReactionPrototype type; only retain the current directory if repository
namespace checks require it.
In `@Resources/Prototypes/_Starlight/Guidebook/references.yml`:
- Line 35: Remove the trailing whitespace from line 35 in the references.yml
file, leaving the line content otherwise unchanged.
- Around line 7-35: Remove the duplicate FoodRecipes and DoughRecipes entries
from the Starlight references so the canonical definitions in the shared
guidebook references remain authoritative, including IceCreamRecipes and
DoughRecipes’ filterEnabled setting. Also remove the trailing whitespace after
the DoughRecipes text entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 5015c46a-444f-4552-9a89-ce6c6e293916
📒 Files selected for processing (10)
Content.Client/Guidebook/Controls/GuideMicrowaveEmbed.xaml.csContent.Client/Guidebook/Controls/GuideMicrowaveGroupEmbed.csContent.Shared/_Starlight/Chemistry/Reaction/ReactionPrototype.Starlight.csResources/Locale/en-US/_Starlight/guidebook/guides.ftlResources/Prototypes/Guidebook/references.ymlResources/Prototypes/Recipes/Reactions/food.ymlResources/Prototypes/_Starlight/Guidebook/references.ymlResources/Prototypes/_Starlight/Recipes/reactions.ymlResources/ServerInfo/Guidebook/Service/FoodRecipes.xmlResources/ServerInfo/_Starlight/Guidebook/Service/DoughRecipes.xml
|
@coderabbitai review |
✅ Action performedReview finished.
|
Co-authored-by: Rinary <rinary.super@gmail.com>
Content + Integration Test ResultsSummary:
Failed Tests:No failed tests ✨ Github Test Reporter by CTRF 💚 |
a9c6e2b
Short description
Adds recipes for various doughs to the guidebook. Creates the
guidebookGroupsmethod which allows for any chemical reaction to be formatted as a guidebook entry in the same style of every other food recipe.Why we need to add this
Extremely confusing for new players, suggested a number of times on discord (which you can find here, here, and here.)
The cookbook previously couldn't recognize any recipes that don't use a microwave, oven, stove, or deep fryer. This is necessary guidance for new players and a crucial part of cooking practically any dish. This aligns with the general philosophy of providing all necessary information by means accessible within the game, and avoids players having to turn to external websites or wikis to get simple recipes.
If new dough/cooking chemical reactions are added in the future this works the same way as all the actual food recipes. Just tag the reaction using
guidebookGroups.Documenting how to make things like condiments purely through chemical reactions is something that's made possible in this PR, and should probably be added to the guidebook but I'll save that for another day.
Media (Video/Screenshots)
Checks
Changelog
🆑 bynddark8, Rinary1