Fix JobWeightTest causing failures - #5380
Merged
redmushie merged 5 commits intoJul 28, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThe integration test fixture adds a ChangesJob weight test configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mackamuir
reviewed
Jul 28, 2026
Contributor
|
Also this test is evil and we have tried to fix it many times apparently |
Rinary1
approved these changes
Jul 28, 2026
Merged
via the queue into
ss14Starlight:starlight-dev
with commit Jul 28, 2026
24c86e1
26 checks passed
Limerent-Sun
pushed a commit
to Blimpuf-Station/BlimpufStation
that referenced
this pull request
Aug 5, 2026
## Short description <!-- What do you propose to change with your PR? --> JobWeightTest disconnects the pair, but does not dirty the pair. The rest of the tests rely on them being connected ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Failing lots, e.g. on ss14Starlight#5169 ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [ ] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. Not user facing, no CL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
JobWeightTest disconnects the pair, but does not dirty the pair. The rest of the tests rely on them being connected
Why we need to add this
Failing lots, e.g. on #5169
Media (Video/Screenshots)
Checks
Not user facing, no CL