Skip to content

(Cluster) Cold Loop Fix - #5389

Merged
redmushie merged 1 commit into
ss14Starlight:starlight-devfrom
Omegalucky:cluster-cold-loop-fix
Jul 29, 2026
Merged

(Cluster) Cold Loop Fix#5389
redmushie merged 1 commit into
ss14Starlight:starlight-devfrom
Omegalucky:cluster-cold-loop-fix

Conversation

@Omegalucky

@Omegalucky Omegalucky commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Short description

Remove hullplates from under cold loop's radiators, which preventing cooling.

Why we need to add this

TEG's cold loop is not functioning as a cooler for the TEG in it's current state.

Media (Video/Screenshots)

image

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 OMEGA

  • fix: Removed hull plates blocking TEG's cold loop from cooling.

@Omegalucky
Omegalucky requested a review from a team July 28, 2026 23:48
@github-actions github-actions Bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: Map Changes: No C# S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 28, 2026
@Omegalucky

Omegalucky commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Let me know if any mapping tasks need done for Cluster, and I can add them onto this PR.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 3017d511-faaf-495b-a243-5c1475f3347a

📥 Commits

Reviewing files that changed from the base of the PR and between f88ef61 and 75c15ba.

📒 Files selected for processing (1)
  • Resources/Maps/_Starlight/Stations/Cluster.yml

📝 Walkthrough

Walkthrough

Updates the Starlight station cluster timestamp, map tile payload, and several door device state-change timing values.

Changes

Cluster resource updates

Layer / File(s) Summary
Cluster metadata and tile payload
Resources/Maps/_Starlight/Stations/Cluster.yml
Updates the cluster timestamp and replaces one map layer’s encoded tile payload.
Door timing and state values
Resources/Maps/_Starlight/Stations/Cluster.yml
Adjusts secondsUntilStateChange values for multiple door devices, including Closing and Opening blocks.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: redmushie

🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Title check ✅ Passed Nice, clear title that matches the cold loop cooling fix.
Description check ✅ Passed The description clearly matches the radiator/hullplate cooling fix in the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Magic Numbers ✅ Passed PASS: Nice tidy change—only a map YAML prototype was modified, and YAML prototypes are exempt from this check.
No Hardcoded Ecs Parameters ✅ Passed PASS: This commit only updates Cluster.yml map data; the door timings are per-entity component values, and no system logic was modified.
Avoid Service Locator ✅ Passed PASS: The PR only edits a map YAML asset; no source files or service-locator usages (IoCManager, ServiceLocator, Log.) are present.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CawsForConcern CawsForConcern added T: Fix and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 29, 2026
@CawsForConcern CawsForConcern added S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 29, 2026
@redmushie
redmushie added this pull request to the merge queue Jul 29, 2026
@redmushie redmushie self-assigned this Jul 29, 2026
Merged via the queue into ss14Starlight:starlight-dev with commit 5dd6638 Jul 29, 2026
26 of 36 checks passed
starlightgithub Bot added a commit that referenced this pull request Jul 29, 2026
@Omegalucky
Omegalucky deleted the cluster-cold-loop-fix branch July 29, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: Map Changes: No C# S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. size/S T: Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants