Skip to content

corporeal command update - #5391

Merged
redmushie merged 2 commits into
ss14Starlight:starlight-devfrom
neomoth:corporeal-update
Jul 29, 2026
Merged

corporeal command update#5391
redmushie merged 2 commits into
ss14Starlight:starlight-devfrom
neomoth:corporeal-update

Conversation

@neomoth

@neomoth neomoth commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Short description

Changes what components are added/removed to reflect updates to ghost prototypes (no longer adds/removes speech and tts)

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

@neomoth
neomoth requested a review from a team July 29, 2026 00:28
@github-actions github-actions Bot added size/XS Changes: C# S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 29, 2026
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: b35a6526-f685-4ab1-b63b-6f14aa44b5d1

📥 Commits

Reviewing files that changed from the base of the PR and between f88ef61 and 3690e65.

📒 Files selected for processing (1)
  • Content.Server/_Starlight/Ghost/CorporealCommand.cs
💤 Files with no reviewable changes (1)
  • Content.Server/_Starlight/Ghost/CorporealCommand.cs

📝 Walkthrough

Walkthrough

Changes

Corporeal component handling

Layer / File(s) Summary
Adjust corporeal component lifecycle
Content.Server/_Starlight/Ghost/CorporealCommand.cs
Corporeal ghosts continue to receive EmotingComponent and VocalComponent; SpeechComponent and TextToSpeechComponent are no longer added or removed during corporeal toggles. A focused, nicely scoped adjustment preserves the existing command behavior.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: S: Untriaged, size/S

🚥 Pre-merge checks | ✅ 7 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related, but it's too generic to clearly convey the specific component change. Use a more specific title like 'Update CorporealCommand to stop managing speech and TTS components'.
✅ Passed checks (7 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly matches the component changes in CorporealCommand and is a solid summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Magic Numbers ✅ Passed PASS: the touched system file has no raw numeric literals; it only uses named enum casts and booleans, so no magic numbers were introduced.
No Hardcoded Ecs Parameters ✅ Passed Pass: the command only toggles component presence/state; behavior parameters live on Emoting/Vocal components, and ghost prototypes no longer use Speech/TTS.
Avoid Service Locator ✅ Passed Nice cleanup: the PR only removes speech/TTS component changes; no new service-locator usage was added, and existing EntitySystemManager lookups are unchanged.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@starlightgithub starlightgithub Bot added S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 29, 2026
@redmushie redmushie self-assigned this Jul 29, 2026
@redmushie
redmushie added this pull request to the merge queue Jul 29, 2026
Merged via the queue into ss14Starlight:starlight-dev with commit cfaef58 Jul 29, 2026
23 checks passed
Limerent-Sun pushed a commit to Blimpuf-Station/BlimpufStation that referenced this pull request Aug 5, 2026
## Short description
<!-- What do you propose to change with your PR? -->
Changes what components are added/removed to reflect updates to ghost
prototypes (no longer adds/removes speech and tts)
## Checks
<!-- check boxes for faster reviewing of your PR -->

- [x] I do not require assistance to complete the PR.
- [x] Before posting/requesting review of a PR, I have verified that the
changes work.
- [x] I have added screenshots/videos of the changes, or this PR does
not change in-game mechanics.
- [x] I affirm that my changes are licensed under the [MIT
License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT)
and grant permission for use in this repository under its conditions.

Co-authored-by: Red Mushie <82113471+redmushie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: C# S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants