Skip to content

Add an ERT Chaplain spawn point to the ERT Chaplain shuttle - #5392

Merged
redmushie merged 3 commits into
ss14Starlight:starlight-devfrom
wonderfulnewworld:mapping/chaplain-shuttle
Jul 30, 2026
Merged

Add an ERT Chaplain spawn point to the ERT Chaplain shuttle#5392
redmushie merged 3 commits into
ss14Starlight:starlight-devfrom
wonderfulnewworld:mapping/chaplain-shuttle

Conversation

@wonderfulnewworld

Copy link
Copy Markdown
Contributor

Short description

Adds a singular spawnpoint to the ERT Chaplain's shuttle.

Why we need to add this

Antag Selection (Rebirth) gets rid of the ERT Chaplain Antag ghost role, in favor of a normal ERT Chaplain ghost role, so it needs a singular spawn point mapped. Including this here so the other PR doesn't get hit with a mapping tag.

Media (Video/Screenshots)

image

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Technically nothing player facing until Antag Selection (Rebirth) is merged.

@wonderfulnewworld
wonderfulnewworld requested a review from a team July 29, 2026 02:57
@github-actions github-actions Bot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/XS S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: Map Changes: No C# and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS labels Jul 29, 2026
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • Resources/Maps/_Starlight/Shuttles/SecureTerminal/ERT-Chaplain.yml
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ad775e11-aaab-4014-a1e9-d30541bf3dc7

📥 Commits

Reviewing files that changed from the base of the PR and between 38df907 and 4e921e9.

📒 Files selected for processing (1)
  • Resources/Maps/_Starlight/Shuttles/SecureTerminal/ERT-Chaplain.yml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The Chaplain shuttle grid now reports 517 entities and includes a SpawnPointGhostERTChaplain prototype at position 0.5,2.5 under parent 2, spawning entity uid: 532.

Changes

ERT Chaplain spawn point

Layer / File(s) Summary
Grid metadata and spawn definition
Resources/Maps/_Starlight/Shuttles/CC-NT/Chaplain_GRID.yml
Increments entityCount from 516 to 517 and adds the SpawnPointGhostERTChaplain prototype with entity uid: 532 and its transform.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: Changes: Prototypes

Suggested reviewers: redmushie

🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Title check ✅ Passed Clear and specific title accurately matches the added ERT Chaplain spawn point.
Description check ✅ Passed The description is clearly related to the mapping change and explains why the spawn point was added.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Magic Numbers ✅ Passed Only a YAML map/prototype file changed; the magic-numbers rule explicitly excludes YAML prototypes.
No Hardcoded Ecs Parameters ✅ Passed The change is map/prototype-only; SpawnPointGhostERTChaplain stores behavior in GhostRole fields, and GhostRoleSystem consumes them generically.
Avoid Service Locator ✅ Passed PASS: The commit only adds a map spawn point and references an existing data-only prototype; no code or dependency-resolution/service-locator usage was introduced.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 29, 2026
@wonderfulnewworld

Copy link
Copy Markdown
Contributor Author

hang on thtas the wrong entity

@wonderfulnewworld

Copy link
Copy Markdown
Contributor Author

there we go

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 29, 2026

@redmushie redmushie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need you to check something for me -- I know when we addgamerule ERTSecuritySpawn or similar (I don't have the exact names memorized) it spawns a shuttle + ghost roles, whereas addgamerule ERTSecurityShuttleSpawn or something spawns just the shuttle.

  • Do we have the same for Chaplain shuttle?
  • If we do, does this affect both, or just one?
  • If we don't, does that make it impossible to load the shuttle without spawning the ghost roles?

I don't think I have to say it but I think the ideal case is where we match that pattern, a way to spawn without and with ghost roles explicitly.

@starlightgithub starlightgithub Bot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 29, 2026
@redmushie redmushie self-assigned this Jul 29, 2026
@wonderfulnewworld

wonderfulnewworld commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

I need you to check something for me -- I know when we addgamerule ERTSecuritySpawn or similar (I don't have the exact names memorized) it spawns a shuttle + ghost roles, whereas addgamerule ERTSecurityShuttleSpawn or something spawns just the shuttle.

  • Do we have the same for Chaplain shuttle?
  • If we do, does this affect both, or just one?
  • If we don't, does that make it impossible to load the shuttle without spawning the ghost roles?

I don't think I have to say it but I think the ideal case is where we match that pattern, a way to spawn without and with ghost roles explicitly.

Good catch. I added the one with the spawner to a separate file now, so we can still use the shuttlespawn one to just spawn the shuttle without the ghost role.

bruh why i sound like chatgpt

@github-actions github-actions Bot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Jul 29, 2026
@starlightgithub starlightgithub Bot added S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 29, 2026

@redmushie redmushie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I checked the two game rules and they are:

  • ERTChaplainSpawn, which currently just Spawns The Guy;
  • ERTChaplainShuttleSpawn, which currently just spawns the shuttle.

So if we merge this, then #4958 will use it and spawn the shuttle + the guy, replacing the current behavior for ERTChaplainSpawn, correct?

@wonderfulnewworld

Copy link
Copy Markdown
Contributor Author

Awesome, I checked the two game rules and they are:

  • ERTChaplainSpawn, which currently just Spawns The Guy;
  • ERTChaplainShuttleSpawn, which currently just spawns the shuttle.

So if we merge this, then #4958 will use it and spawn the shuttle + the guy, replacing the current behavior for ERTChaplainSpawn, correct?

I have to make a singular line change over on the other pr, but I’ll do this after this pr gets merged to dev to save a singular merge conflict, but yeah, it’ll spawn the shuttle + the guy.

@CawsForConcern CawsForConcern mentioned this pull request Jul 30, 2026
4 tasks
@redmushie
redmushie added this pull request to the merge queue Jul 30, 2026
Merged via the queue into ss14Starlight:starlight-dev with commit 4b7181d Jul 30, 2026
24 checks passed
Limerent-Sun pushed a commit to Blimpuf-Station/BlimpufStation that referenced this pull request Aug 5, 2026
…light#5392)

## Short description
Adds a singular spawnpoint to the ERT Chaplain's shuttle.

## Why we need to add this
[Antag Selection
(Rebirth)](ss14Starlight#4958)
gets rid of the ERT Chaplain Antag ghost role, in favor of a normal ERT
Chaplain ghost role, so it needs a singular spawn point mapped.
Including this here so the other PR doesn't get hit with a mapping tag.

## Media (Video/Screenshots)
<img width="374" height="391" alt="image"
src="https://github.com/user-attachments/assets/9afd340f-e0d8-459e-a0be-9c098987181b"
/>

## Checks
- [X] I do not require assistance to complete the PR.
- [X] Before posting/requesting review of a PR, I have verified that the
changes work.
- [X] I have added screenshots/videos of the changes, or this PR does
not change in-game mechanics.
- [X] I affirm that my changes are licensed under the [MIT
License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT)
and grant permission for use in this repository under its conditions.

Technically nothing player facing until Antag Selection (Rebirth) is
merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: Map Changes: No C# S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants