Add an ERT Chaplain spawn point to the ERT Chaplain shuttle - #5392
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe Chaplain shuttle grid now reports 517 entities and includes a ChangesERT Chaplain spawn point
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
hang on thtas the wrong entity |
|
there we go |
There was a problem hiding this comment.
I need you to check something for me -- I know when we addgamerule ERTSecuritySpawn or similar (I don't have the exact names memorized) it spawns a shuttle + ghost roles, whereas addgamerule ERTSecurityShuttleSpawn or something spawns just the shuttle.
- Do we have the same for Chaplain shuttle?
- If we do, does this affect both, or just one?
- If we don't, does that make it impossible to load the shuttle without spawning the ghost roles?
I don't think I have to say it but I think the ideal case is where we match that pattern, a way to spawn without and with ghost roles explicitly.
Good catch. I added the one with the spawner to a separate file now, so we can still use the shuttlespawn one to just spawn the shuttle without the ghost role. bruh why i sound like chatgpt |
There was a problem hiding this comment.
Awesome, I checked the two game rules and they are:
ERTChaplainSpawn, which currently just Spawns The Guy;ERTChaplainShuttleSpawn, which currently just spawns the shuttle.
So if we merge this, then #4958 will use it and spawn the shuttle + the guy, replacing the current behavior for ERTChaplainSpawn, correct?
I have to make a singular line change over on the other pr, but I’ll do this after this pr gets merged to dev to save a singular merge conflict, but yeah, it’ll spawn the shuttle + the guy. |
4b7181d
…light#5392) ## Short description Adds a singular spawnpoint to the ERT Chaplain's shuttle. ## Why we need to add this [Antag Selection (Rebirth)](ss14Starlight#4958) gets rid of the ERT Chaplain Antag ghost role, in favor of a normal ERT Chaplain ghost role, so it needs a singular spawn point mapped. Including this here so the other PR doesn't get hit with a mapping tag. ## Media (Video/Screenshots) <img width="374" height="391" alt="image" src="https://github.com/user-attachments/assets/9afd340f-e0d8-459e-a0be-9c098987181b" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. Technically nothing player facing until Antag Selection (Rebirth) is merged.
Short description
Adds a singular spawnpoint to the ERT Chaplain's shuttle.
Why we need to add this
Antag Selection (Rebirth) gets rid of the ERT Chaplain Antag ghost role, in favor of a normal ERT Chaplain ghost role, so it needs a singular spawn point mapped. Including this here so the other PR doesn't get hit with a mapping tag.
Media (Video/Screenshots)
Checks
Technically nothing player facing until Antag Selection (Rebirth) is merged.