Skip to content

Remove sparks from lightning #5396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Swonkus wants to merge 1 commit into from
Closed

Remove sparks from lightning #5396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Content.Server/Tesla/EntitySystem/LightningSparkingSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ private void OnHitByLightning(Entity<LightningSparkingComponent> uid, ref HitByL
{
_appearance.SetData(uid.Owner, TeslaCoilVisuals.Lightning, true);
uid.Comp.LightningEndTime = _gameTiming.CurTime + TimeSpan.FromSeconds(uid.Comp.LightningTime);
uid.Comp.IsSparking = true;
uid.Comp.IsSparking = false;
Comment on lines 25 to +27

@coderabbitai coderabbitai Bot Jul 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Clear the lightning appearance when disabling sparking.

Nice targeted change toward preventing lightning-induced ignition, but Line 25 still enables the lightning appearance while Line 27 makes Update skip the cleanup path. After the first hit, TeslaCoilVisuals.Lightning can remain enabled indefinitely. Set the appearance to false here, or otherwise preserve a cleanup path.

Proposed fix 
-        _appearance.SetData(uid.Owner, TeslaCoilVisuals.Lightning, true);
+        _appearance.SetData(uid.Owner, TeslaCoilVisuals.Lightning, false);
         uid.Comp.LightningEndTime = _gameTiming.CurTime + TimeSpan.FromSeconds(uid.Comp.LightningTime);
         uid.Comp.IsSparking = false;
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
_appearance.SetData(uid.Owner, TeslaCoilVisuals.Lightning, true);
uid.Comp.LightningEndTime = _gameTiming.CurTime + TimeSpan.FromSeconds(uid.Comp.LightningTime);
uid.Comp.IsSparking = true;
uid.Comp.IsSparking = false;
_appearance.SetData(uid.Owner, TeslaCoilVisuals.Lightning, false);
uid.Comp.LightningEndTime = _gameTiming.CurTime + TimeSpan.FromSeconds(uid.Comp.LightningTime);
uid.Comp.IsSparking = false;
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Content.Server/Tesla/EntitySystem/LightningSparkingSystem.cs` around lines 25
- 27, Update the sparking-disable logic around LightningSparkingSystem’s
appearance update so TeslaCoilVisuals.Lightning is cleared when IsSparking is
set to false. Preserve the existing timing assignment and ensure Update retains
a cleanup path rather than leaving the lightning appearance enabled
indefinitely.

}

public override void Update(float frameTime)
Expand Down
Loading