Plumbing machine tile fix by Mackamuir · Pull Request #5406 · ss14Starlight/space-station-14

Mackamuir · 2026-07-30T00:08:04Z

Short description

Fixes issue with the plumbing smart dispenser being anchored under a tile
Fixes issue with plumbing machine power states
Adds a new opt-in boolean to allow machines that would otherwise be prevented from unanchoring on a tile, to be unanchored.
Updates the plumbing smart dispenser icon in the RPLD
Stops the Plumbing smart dispenser from being able to rotate, causing some visual fuckery.

Why we need to add this

bugfix :)

Checks

I do not require assistance to complete the PR.
Before posting/requesting review of a PR, I have verified that the changes work.
I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 Mack

fix: The Plumbing Smart Dispenser will no longer be in the floor.
fix: The icon for the Plumbing Smart Dispenser will now appear correctly on the RPLD.

coderabbitai · 2026-07-30T00:11:46Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 6ed7b8e7-5f2b-4a6a-bdf8-1c481a1f9bdf

📥 Commits

Reviewing files that changed from the base of the PR and between 21e423a and 2d396b6.

📒 Files selected for processing (2)

Resources/Maps/_Starlight/MedTak/MedTakPointAlpha.yml
Resources/Maps/_Starlight/Stations/SpaceMall.yml

💤 Files with no reviewable changes (2)

Resources/Maps/_Starlight/Stations/SpaceMall.yml
Resources/Maps/_Starlight/MedTak/MedTakPointAlpha.yml

📝 Walkthrough

Walkthrough

This update adds powered connector sprite visibility handling, makes subfloor anchoring under cover configurable, updates plumbing dispenser prototypes, and removes rotation fields from related map entities.

Changes

Plumbing and subfloor updates

Layer / File(s)	Summary
Powered connector layer visibility `Content.Client/_Starlight/Plumbing/PlumbingConnectorAppearanceSystem.cs`	Appearance changes now update the mapped powered sprite layer from `PowerDeviceVisuals.Powered` data.
Configurable subfloor anchoring `Content.Shared/SubFloor/SubFloorHideComponent.cs`, `Content.Shared/SubFloor/SharedSubFloorHideSystem.cs`	`AllowAnchoringUnderCover` controls whether covered anchor and unanchor attempts are cancelled.
Dispenser prototype configuration `Resources/Prototypes/_Starlight/Entities/Structures/Piping/Plumbing/plumbing_machines.yml`, `Resources/Prototypes/_Starlight/Admeme/MedTak/Entities/Structures/dispenser.yml`, `Resources/Prototypes/_Starlight/RPLD/rpld.yml`	Dispenser transform, subfloor, sprite-layer mapping, and RCD texture settings are updated.
Map entity transform updates `Resources/Maps/_Starlight/MedTak/MedTakPointAlpha.yml`, `Resources/Maps/_Starlight/Stations/SpaceMall.yml`	Rotation fields are removed from the affected dispenser and SpaceMall entity transforms.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

ss14Starlight/space-station-14#5197: Updates related connector sprite-layer visibility handling in the same appearance system.
ss14Starlight/space-station-14#5301: Adds related powered sprite-layer configuration for the smart dispenser.

Suggested reviewers: conflee

🚥 Pre-merge checks | ✅ 8

✅ Passed checks (8 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and directly points to the plumbing machine tile-related fix.
Description check	✅ Passed	The description clearly matches the plumbing dispenser, power, unanchoring, icon, and rotation fixes in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No Magic Numbers	✅ Passed	PASS — nice cleanup: the touched system code adds no new magic numbers; changes are limited to bool gating and a powered-layer update.
No Hardcoded Ecs Parameters	✅ Passed	Anchoring behavior moved to SubFloorHideComponent data, and plumbing visuals stay prototype-driven; no new entity-specific behavior is hardcoded in systems.
Avoid Service Locator	✅ Passed	PASS: The touched systems use injected dependencies and entity/component resolution; no IoCManager/Log-style service locator was added.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Mackamuir · 2026-07-30T02:07:27Z

Sleeper PR to remove spall, sea of red real

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Resources/Maps/_Starlight/MedTak/MedTakPointAlpha.yml`:
- Around line 9-12: Update the maps configuration in the MedTakPointAlpha YAML
so maps is explicitly an empty sequence using the established [] syntax, while
preserving grids and the cleaned-up orphans metadata.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d0265386-c224-4653-a25f-337e46771f54

📥 Commits

Reviewing files that changed from the base of the PR and between ab42b85 and 21e423a.

📒 Files selected for processing (2)

Resources/Maps/_Starlight/MedTak/MedTakPointAlpha.yml
Resources/Maps/_Starlight/Stations/SpaceMall.yml

redmushie

Why do we need AllowAnchoringUnderCover? It just seems redundant here like you're fixing the same bug twice in one PR

Mackamuir · 2026-08-01T01:42:12Z

Why do we need AllowAnchoringUnderCover? It just seems redundant here like you're fixing the same bug twice in one PR

Thats actually fixing a seperate thing, maybe I the naming is poor but its talking about the pipes not the actual fridge, otherwise you get the "You cant unanchor this here!" like you would for a vent with a tile for example.

Other fix for that would be to remove the dual layer for the smart fridge and revert it to original behaviour, which really isnt the end of the world as you cant even really see the pipes with it

## Short description - Fixes issue with the plumbing smart dispenser being anchored under a tile - Fixes issue with plumbing machine power states - Adds a new opt-in boolean to allow machines that would otherwise be prevented from unanchoring on a tile, to be unanchored. - Updates the plumbing smart dispenser icon in the RPLD - Stops the Plumbing smart dispenser from being able to rotate, causing some visual fuckery. ## Why we need to add this bugfix :) ## Checks  - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog**  :cl: Mack - fix: The Plumbing Smart Dispenser will no longer be in the floor. - fix: The icon for the Plumbing Smart Dispenser will now appear correctly on the RPLD.

Mackamuir added 5 commits July 30, 2026 08:48

Fix Smart Dispenser being hidden under tiles

dab96aa

reapply power state to make it work, I guess.

9bb6bf5

Update sprite icon in RPLD Radial menu

5537cb7

Add system to allow multi-layer machines be unanchored.

415e165

Stop the smart dispenser from being able to rotate

ab42b85

Mackamuir requested a review from a team July 30, 2026 00:08

coderabbitai Bot previously approved these changes Jul 30, 2026

View reviewed changes

Mackamuir dismissed coderabbitai[bot]’s stale review via 21e423a July 30, 2026 02:56

github-actions Bot added size/M Changes: Map and removed size/S labels Jul 30, 2026

coderabbitai Bot requested changes Jul 30, 2026

View reviewed changes

Comment thread Resources/Maps/_Starlight/MedTak/MedTakPointAlpha.yml Outdated

Remove rotation from spall and medtak base smart dispensers/

2d396b6

Mackamuir force-pushed the plumbing-machine-fix branch from 21e423a to 2d396b6 Compare July 30, 2026 03:03

github-actions Bot added size/S and removed size/M labels Jul 30, 2026

coderabbitai Bot approved these changes Jul 30, 2026

View reviewed changes

CawsForConcern approved these changes Jul 30, 2026

View reviewed changes

redmushie requested changes Jul 31, 2026

View reviewed changes

starlightgithub Bot added the S: Awaiting Changes Status: Changes are required before another review can happen label Jul 31, 2026

redmushie self-assigned this Jul 31, 2026

Mackamuir added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Aug 1, 2026

redmushie approved these changes Aug 1, 2026

View reviewed changes

starlightgithub Bot added S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Aug 1, 2026

redmushie added this pull request to the merge queue Aug 1, 2026

Merged via the queue into ss14Starlight:starlight-dev with commit 419fc06 Aug 1, 2026
23 checks passed

starlightgithub Bot added a commit that referenced this pull request Aug 1, 2026

Changelog: PR #5406 [skip ci]

bf05f9f

Navigation Menu

Uh oh!

Plumbing machine tile fix - #5406

Plumbing machine tile fix#5406
redmushie merged 6 commits into
ss14Starlight:starlight-devfrom
Mackamuir:plumbing-machine-fix

Mackamuir commented Jul 30, 2026

Uh oh!

coderabbitai Bot commented Jul 30, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

Mackamuir commented Jul 30, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

redmushie left a comment

Uh oh!

Mackamuir commented Aug 1, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Mackamuir commented Jul 30, 2026

Short description

Why we need to add this

Checks

Uh oh!

coderabbitai Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

Mackamuir commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

redmushie left a comment

Choose a reason for hiding this comment

Uh oh!

Mackamuir commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Jul 30, 2026 •

edited

Loading

Mackamuir commented Jul 30, 2026 •

edited

Loading

Mackamuir commented Aug 1, 2026 •

edited

Loading