Update engine to v283.0.0 for serv5, and refactor content to work with it - #5426
Merged
StarlightHost merged 14 commits intoAug 10, 2026
Merged
Conversation
github-actions
Bot
added
Changes: UI
Changes: C#
S: Untriaged
Contributor
|
test failz are real edited because my 10pm brain is stupid, obviously the map manager doesn't exist anymore lack of starlight comments on wizden file edits updating dependencies, but unsure whether or not this is a problem as we have an upstream pr arriving soon from what i understand (cc @CrazyPhantom779 ) so changes will likely be applied then anyway |
…e-station-14 into refactor/serv5 # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Contributor
Upstream PR already went through, in fact this help a little bit for the next one |
Contributor
|
Important Review skippedToo many files! This PR contains 129 files, which is 29 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (129)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
StarlightHost
enabled auto-merge
August 10, 2026 08:17
StarlightHost
disabled auto-merge
August 10, 2026 08:17
StarlightHost
enabled auto-merge
August 10, 2026 08:17
StarlightHost
approved these changes
Aug 10, 2026
starlightgithub
Bot
added
S: Approved
Merged
via the queue into
ss14Starlight:starlight-dev
with commit Aug 10, 2026
b7b3414
23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Let me tell you a story, of how I spent 30 minutes trying to figure out why Afterlight test startup was abominably slow, only to realize Starlight hasn't updated the engine in a long time, and then spending a few hours updating the engine here instead
This updates (your custom fork of) the engine and Content to compile with it
Includes changes to IMapManager being deleted in engine (thank god) and the engine update in this same PR
Also fixes Content.Shared/Polymorph/PolymorphActions.cs to not resolve a prototype in a data field's setter because that is insane, if you could make sure that is caught in review because that will not work properly with serialization, the closest you can get to it is a ISerializationHooks.AfterDeserialization implementation but even then you should just resolve it in the system
Related but not needed (hopefully)
Why we need to add this
Media (Video/Screenshots)
Gets ingame 👍
Checks