Supermatter guidebook entry - #5429
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe guidebook now includes localized Supermatter entries, engineering prototype wiring, and XML pages for crystal operation, stability, structural recovery, delamination response, and advanced handling research. ChangesSupermatter Guidebook Addition
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
Resources/ServerInfo/Guidebook/Engineering/SupermatterAdvancedSupermatterHandling.xml (1)
32-32: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winSolid lore content — tighten a few label/heading inconsistencies for polish.
The three experiment write-ups read well and the redacted-document flavor lands nicely. A few small terminology and formatting inconsistencies are worth a quick pass:
- Line 98 uses
## Project SM-Zero, while the sibling entries use## Experiment SM-T1(line 32) and## Experiment SM-ZS-LS(line 180). The body of the SM-Zero section itself still calls every field "Experiment ..." (Experiment Lead, Experiment Handler, Experiment Difficulty, Experiment Configuration, Experiment Results), so "Project" in the heading reads as a mismatch.- Line 198 uses
[color=orange]Experimental Configuration[/color], while the same section header elsewhere reads[color=orange]Experiment Configuration[/color](lines 49, 118).- Lines 148, 154, 157, 160, and 171 switch to sentence case ("Required automation:", "Safe emitter limit:", "Estimated safe emitter limit:", "Emitters used during testing:", "Maximum recorded output:"), while every other field label in the document uses Title Case (e.g. "Chamber Temperature:", "Pressure Supply:", "Coolant:").
None of this affects rendering, but fixing it keeps the same term used for the same concept throughout the archive.
📝 Suggested consistency fixes
- ## Project SM-Zero + ## Experiment SM-Zero- [color=orange]Experimental Configuration[/color] + [color=orange]Experiment Configuration[/color]- Required automation: + Required Automation: - Pressure floor monitoring. - Temperature-sensitive emitter activation. [color=orange]Experiment Results[/color] - Safe emitter limit: + Safe Emitter Limit: Six emitters. - Estimated safe emitter limit: + Estimated Safe Emitter Limit: Sixteen emitters. - Emitters used during testing: + Emitters Used During Testing: Thirty-two emitters.Also applies to: 49-49, 98-99, 118-118, 148-172, 180-181, 198-198
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/ServerInfo/Guidebook/Engineering/SupermatterAdvancedSupermatterHandling.xml` at line 32, Normalize the experiment headings and field labels in the guidebook: rename the SM-Zero heading from “Project” to “Experiment,” change “Experimental Configuration” to “Experiment Configuration,” and convert the sentence-case labels around the SM-Zero section to Title Case while preserving their existing wording and values.Resources/ServerInfo/Guidebook/Engineering/SupermatterBehaviour.xml (1)
8-13: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueLink the related sub-pages.
Nice short page, but the “Related Documentation” bullets make readers leave Supermatter Behaviour without a direct way back. Use the in-text link style already used in other guidebook pages, e.g.
[textlink="Supermatter Structural Recovery" link="SupermatterStructuralRecovery"].🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Resources/ServerInfo/Guidebook/Engineering/SupermatterBehaviour.xml` around lines 8 - 13, Update the “Related Documentation” bullets in the Supermatter Behaviour guidebook page to use in-text links for both “Supermatter Stability” and “Supermatter Structural Recovery,” matching the existing [textlink] style and their corresponding page identifiers.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/ServerInfo/Guidebook/Engineering/SupermatterDelamination.xml`:
- Around line 20-34: Update the Delamination Cleanup reference around the
existing cascade entity ID, replacing `cascade1` with the prototype identifier
`Cascad1`; preserve the surrounding guide content and formatting.
---
Nitpick comments:
In
`@Resources/ServerInfo/Guidebook/Engineering/SupermatterAdvancedSupermatterHandling.xml`:
- Line 32: Normalize the experiment headings and field labels in the guidebook:
rename the SM-Zero heading from “Project” to “Experiment,” change “Experimental
Configuration” to “Experiment Configuration,” and convert the sentence-case
labels around the SM-Zero section to Title Case while preserving their existing
wording and values.
In `@Resources/ServerInfo/Guidebook/Engineering/SupermatterBehaviour.xml`:
- Around line 8-13: Update the “Related Documentation” bullets in the
Supermatter Behaviour guidebook page to use in-text links for both “Supermatter
Stability” and “Supermatter Structural Recovery,” matching the existing
[textlink] style and their corresponding page identifiers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 1b8c599f-14fc-40e0-b58c-74161b230c1d
📒 Files selected for processing (8)
Resources/Locale/en-US/guidebook/guides.ftlResources/Prototypes/Guidebook/engineering.ymlResources/ServerInfo/Guidebook/Engineering/Supermatter.xmlResources/ServerInfo/Guidebook/Engineering/SupermatterAdvancedSupermatterHandling.xmlResources/ServerInfo/Guidebook/Engineering/SupermatterBehaviour.xmlResources/ServerInfo/Guidebook/Engineering/SupermatterDelamination.xmlResources/ServerInfo/Guidebook/Engineering/SupermatterStability.xmlResources/ServerInfo/Guidebook/Engineering/SupermatterStructuralRecovery.xml
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/ServerInfo/Guidebook/Engineering/SupermatterStability.xml`:
- Around line 4-59: Update the Supermatter stability guide’s “Sources of Stress”
thresholds to match implementation: temperature above 473.15 K, pressure below
33 kPa, or pressure above 363.9 kPa. Revise the pressure-regulator guidance to
state that regulators do not automatically prevent overpressure; players must
configure the inlet threshold, which defaults to 0, and include the configured
threshold in SOP guidance if retaining that recommendation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 706c27e7-aa23-4c5e-9359-0c7e64427661
📒 Files selected for processing (5)
Resources/ServerInfo/Guidebook/Engineering/Supermatter.xmlResources/ServerInfo/Guidebook/Engineering/SupermatterAdvancedSupermatterHandling.xmlResources/ServerInfo/Guidebook/Engineering/SupermatterDelamination.xmlResources/ServerInfo/Guidebook/Engineering/SupermatterStability.xmlResources/ServerInfo/Guidebook/Engineering/SupermatterStructuralRecovery.xml
🚧 Files skipped from review as they are similar to previous changes (2)
- Resources/ServerInfo/Guidebook/Engineering/Supermatter.xml
- Resources/ServerInfo/Guidebook/Engineering/SupermatterDelamination.xml
|
@redmushie if you want i can remove the whole experiment section. i want to give idea for setups, but dont want an list of steps to follow. So im unsure about what i should do. |
Content + Integration Test Results
🎉 No failed tests in this run. Github Test Reporter by CTRF 💚 |
623de9a
## Short description So new players can lookup what the Supermatter does, and give some hints how it works. ## Media (Video/Screenshots) <img width="1407" height="1149" alt="grafik" src="https://github.com/user-attachments/assets/b43f2b6f-bc99-4710-91ca-b30b5272b5b0" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: SirLutz - add: Supermatter guidebook entry. - add: Supermatter guidebook hints for valid setups.
Short description
So new players can lookup what the Supermatter does, and give some hints how it works.
Media (Video/Screenshots)
Checks
Changelog
🆑 SirLutz