Project NEOCYTE: New Era - #5457
Merged
walksanatora merged 21 commits intoAug 10, 2026
Merged
Conversation
github-actions
Bot
added
S: Needs Review
Contributor
Author
|
drafting this because I need this pr here so I can keep track of what i've actually done already and what i haven't cause this is gonna be actually massive diff |
it's _Starlight
github-actions
Bot
added
the
S: Merge Conflict
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…n-14 into neocyte/new-era # Conflicts: # Resources/Prototypes/_Starlight/Entities/Mobs/Species/Neocyte/avali.yml
github-actions
Bot
removed
the
S: Merge Conflict
Contributor
Author
|
@coderabbitai explain test fails |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ss14Starlight/space-station-14"
pr="5457"
echo "== Pull request checks =="
gh pr checks "$pr" --repo "$repo" --required || true
echo
echo "== Failed workflow runs =="
gh run list --repo "$repo" --branch "$(gh pr view "$pr" --repo "$repo" --json headRefName --jq .headRefName)" \
--status failure --limit 20 \
--json databaseId,name,workflowName,displayTitle,conclusion,htmlURL,headSha,createdAtLength of output: 1264 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ss14Starlight/space-station-14"
run_id="31037834913"
job_id="92419511734"
echo "== Workflow run metadata =="
gh api "repos/$repo/actions/runs/$run_id" \
--jq '{name,display_title,event,status,conclusion,head_branch,head_sha,html_url,created_at,updated_at}'
echo
echo "== Failed job and steps =="
gh api "repos/$repo/actions/jobs/$job_id" \
--jq '{name,status,conclusion,started_at,completed_at,html_url,steps:[.steps[]|{name,status,conclusion,number,started_at,completed_at}]}'
echo
echo "== Failed-step log =="
gh run view "$run_id" --repo "$repo" --log-failed || true
echo
echo "== Job annotations =="
gh api "repos/$repo/check-runs/$job_id/annotations?per_page=100" \
--jq '.[] | {path,start_line,end_line,annotation_level,message,title}' || trueLength of output: 195165 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== Failing test structure =="
ast-grep outline Content.IntegrationTests/Tests/_Starlight/Antags/VampireRuleTest.cs --items all
echo
echo "== Failing test around Line 114 =="
sed -n '1,155p' Content.IntegrationTests/Tests/_Starlight/Antags/VampireRuleTest.cs
echo
echo "== Files changed by this PR that mention the failing test or vampire rules =="
git diff --name-only "$(git merge-base HEAD origin/master)" HEAD | while IFS= read -r file; do
if rg -n -i -e 'VampireRuleTest|VampireRule|vampire' "$file" 2>/dev/null; then
printf '\n-- %s --\n' "$file"
git diff "$(git merge-base HEAD origin/master)" HEAD -- "$file"
fi
done
echo
echo "== Neocyte/Protogen changes in antag eligibility and species-selection code =="
git diff --name-only "$(git merge-base HEAD origin/master)" HEAD | while IFS= read -r file; do
if rg -n -i -e 'antag|species|protogen|neocyte' "$file" 2>/dev/null; then
printf '%s\n' "$file"
fi
doneLength of output: 9422 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ss14Starlight/space-station-14"
pr="5457"
base_sha="$(gh pr view "$pr" --repo "$repo" --json baseRefOid --jq .baseRefOid)"
head_sha="$(gh pr view "$pr" --repo "$repo" --json headRefOid --jq .headRefOid)"
echo "== Comparison =="
printf 'base: %s\nhead: %s\n' "$base_sha" "$head_sha"
compare_json="$(mktemp)"
gh api "repos/$repo/compare/$base_sha...$head_sha" > "$compare_json"
echo
echo "== Changed files with vampire/antag/role/test paths =="
jq -r '.files[]
| select(.filename | test("Vampire|Antag|Role|Species|Protogen|Neocyte"; "i"))
| .filename' "$compare_json"
echo
echo "== Relevant changed patch content =="
jq -r '.files[]
| select(
(.filename | test("Vampire|Antag|Role"; "i"))
or ((.patch // "") | test("Vampire|MindIsAntagonist|AddAntagonistRole|antagonist"; "i"))
)
| "\n-- \(.filename) --\n\(.patch // "[No textual patch available]")"' "$compare_json"
echo
echo "== Is the failed test changed by this PR? =="
jq -r '.files[]
| select(.filename == "Content.IntegrationTests/Tests/_Starlight/Antags/VampireRuleTest.cs")
| "changed: \(.filename)"' "$compare_json"Length of output: 29602
The required The actual failure is in integration-test shard 7: At Assert.That(roleSys.MindIsAntagonist(mind), "Player mind was not marked as antagonist.");The result was The Relation to this PRThis PR does not modify:
It does modify _neocyte.EquipSpeciesLoadoutForAntag(...)That method returns immediately unless the spawned antagonist has The available CI log does not show an exception or an explicit reason why the vampire mind was not marked. Based on the evidence, this looks unrelated to the Neocyte migration and may be an intermittent or timing-dependent vampire integration-test failure. The test waits for only 10 ticks after You are interacting with an AI system. |
github-actions
Bot
added
the
S: Merge Conflict
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…n-14 into neocyte/new-era # Conflicts: # Content.Server/Antag/AntagSelectionSystem.cs
Contributor
|
Important Review skippedToo many files! This PR contains 275 files, which is 175 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (275)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
removed
the
S: Merge Conflict
Rinary1
previously approved these changes
Aug 10, 2026
starlightgithub
Bot
added
S: Approved
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Aug 10, 2026
github-actions
Bot
added
the
S: Merge Conflict
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Contributor
Author
|
merge conflicts dealt with |
github-actions
Bot
removed
the
S: Merge Conflict
walksanatora
approved these changes
Aug 10, 2026
Merged
via the queue into
ss14Starlight:starlight-dev
with commit Aug 10, 2026
0871c7c
23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Renames all Protogen stuff to Neocytes, meaning "New Cell"/"New Cellular"/"Beyond Biological".
Somewhat a port of Blimpuf Station #41, although I've basically done all the work from scratch, only using the names they provided.
Also includes a new species migration system so people don't lose their old Protogens.
As I always state when I use AI, I used AI to help with marking migrations, and with making Neocytes always spawn with a frame. The marking migration's pretty similar to map migrations, all things considered... Also, it's something we can probably remove wholesale in like a month or two, it's mostly just here to migrate people over to the new species names, but the further we get from the present, the less use cases it'll have. Eh, who knows, maybe we'll have another case one day if we delete a species or something.
Why we need to add this
Been working on writing some lore for Protogens, and I've come to a conclusion that we should just split them off from their origin for the following reasons:
Media (Video/Screenshots)
Content.Client_cCEqjeH467.webm
Content.Client_9bhQuTuJtu.webm
Checks
Changelog
🆑 wonderfulnewworld, Limerent-Sun