Skip to content

Add glasses to species - #5489

Merged
walksanatora merged 4 commits into
ss14Starlight:starlight-devfrom
RedSpeeds:add-glasses-to-species
Aug 8, 2026
Merged

Add glasses to species#5489
walksanatora merged 4 commits into
ss14Starlight:starlight-devfrom
RedSpeeds:add-glasses-to-species

Conversation

@RedSpeeds

@RedSpeeds RedSpeeds commented Aug 3, 2026

Copy link
Copy Markdown
Member

Short description

Allows Scurret, Kobold, Monkey to wear glasses

Why we need to add this

If a moth/moproach can wear them why would the others not be able to?

Media (Video/Screenshots)

N/A

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 RedSpeeds

  • add: Added glasses slots to Monkey, Kobold, Scurret.

@RedSpeeds
RedSpeeds requested a review from a team August 3, 2026 03:20
@github-actions github-actions Bot added Changes: No C# Changes: Prototypes S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 89af1ca4-9804-4b76-9691-077bc2280394

📥 Commits

Reviewing files that changed from the base of the PR and between b5d4edd and 57b55ab.

📒 Files selected for processing (2)
  • Resources/Prototypes/InventoryTemplates/monkey_inventory_template.yml
  • Resources/Prototypes/InventoryTemplates/scurret_inventory_template.yml
🚧 Files skipped from review as they are similar to previous changes (2)
  • Resources/Prototypes/InventoryTemplates/monkey_inventory_template.yml
  • Resources/Prototypes/InventoryTemplates/scurret_inventory_template.yml

📝 Walkthrough

Summary

Adds glasses inventory slots for Monkey, Kobold, and Scurret species.

Each slot uses the glasses texture, EYES slot flag, three-second strip time, UI and stripping positions, and the Eyes display name where configured.

Players can equip glasses on these species. The author tested multiple glasses types. Insomniac glasses may align less naturally, but they are uncommon in-game.

Risk areas

  • Sprite alignment may vary between glasses types and species.
  • The available diff summary does not show the Kobold template change. Verify that the Kobold slot is included.
  • The change affects inventory placement and wearable-item access for three species.

Guideline gaps

  • The PR does not state why the slot belongs in the shared inventory templates.
  • The PR does not include Starlight ownership comments.
  • The PR does not mention localization handling for the Eyes display name.
  • The PR does not state whether the change has breaking-change impact.
  • The PR does not document the design rationale for glasses alignment.

Walkthrough

The monkey and scurret inventory templates now include configurable eyes slots with glasses visuals, EYES flags, stripping settings, UI positions, and display names.

Changes

Wearable eye slots

Layer / File(s) Summary
Configure eyes slots
Resources/Prototypes/InventoryTemplates/monkey_inventory_template.yml, Resources/Prototypes/InventoryTemplates/scurret_inventory_template.yml
Both inventory templates add an eyes slot with glasses texture, the EYES flag, configured stripping and UI positions, a three-second strip time, and the Eyes display name.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding glasses access for species.
Description check ✅ Passed The description directly explains that Monkey, Kobold, and Scurret can wear glasses.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously requested changes Aug 3, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Resources/Prototypes/InventoryTemplates/monkey_inventory_template.yml`:
- Around line 62-68: Update the new eyes slot coordinates in
Resources/Prototypes/InventoryTemplates/monkey_inventory_template.yml lines
62-68 and Resources/Prototypes/InventoryTemplates/scurret_inventory_template.yml
lines 91-97: replace both uiWindowPos 0,2 and strippingWindowPos 0,0 values at
each site with unused coordinates, preserving the existing slot definitions and
ensuring no control overlap.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 36a600e0-3116-42e3-99ff-e54ff9874e3c

📥 Commits

Reviewing files that changed from the base of the PR and between fae63ce and d5d1573.

📒 Files selected for processing (2)
  • Resources/Prototypes/InventoryTemplates/monkey_inventory_template.yml
  • Resources/Prototypes/InventoryTemplates/scurret_inventory_template.yml

@wonderfulnewworld

Copy link
Copy Markdown
Contributor

Did you check to make sure the glasses align with their sprites?

@redmushie redmushie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs media to prove it doesn't look horrible

@starlightgithub starlightgithub Bot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Aug 3, 2026
@redmushie redmushie self-assigned this Aug 3, 2026
@RedSpeeds

Copy link
Copy Markdown
Member Author
image image

Tested it on a wide variety of glasses only one that was looking a bit weird was the insomniac glasses but since ive never seen those in game i dont think they will pose a problem

@RedSpeeds
RedSpeeds requested a review from redmushie August 6, 2026 00:23
@github-actions github-actions Bot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Aug 6, 2026
@starlightgithub starlightgithub Bot added S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Aug 7, 2026
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@walksanatora
walksanatora added this pull request to the merge queue Aug 8, 2026
Merged via the queue into ss14Starlight:starlight-dev with commit 8a5a1da Aug 8, 2026
23 checks passed
starlightgithub Bot added a commit that referenced this pull request Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: No C# Changes: Prototypes S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants