Lights Respritening

[Conflee]

Short description

Resprites the Small Light, Light Tube, Emergency Light, and Strobe Light. New sprites are a little cleaner, less pre-color tinted so coloring shows up better, and have more built in fake bloom in their on states.

Why we need to add this

Respriting progress. Looks nice.

Media (Video/Screenshots)

Checks

• I do not require assistance to complete the PR.
• Before posting/requesting review of a PR, I have verified that the changes work.
• I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
• I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 Conflee

• tweak: Resprited the Small Light, Light Tube, Emergency Light, and Strobe Light. They're all slightly cleaner, less pre-tinted so coloring stands out more, and have fake bloom added to their on states.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 536d9c48-d5ae-40bd-90ae-a339e8804bf2

📥 Commits

Reviewing files that changed from the base of the PR and between 5534260 and def54a2.

⛔ Files ignored due to path filters (2)

• Resources/Textures/_Starlight/Structures/Wallmounts/Lighting/light_small.rsi/glow.png is excluded by !**/*.png
• Resources/Textures/_Starlight/Structures/Wallmounts/Lighting/light_tube.rsi/glow.png is excluded by !**/*.png

📒 Files selected for processing (1)

• Resources/Textures/_Starlight/Structures/Wallmounts/Lighting/emergency_light.rsi/meta.json

🚧 Files skipped from review as they are similar to previous changes (1)

• Resources/Textures/_Starlight/Structures/Wallmounts/Lighting/emergency_light.rsi/meta.json

---

📝 Walkthrough

Summary

Resprites the Small Light, Light Tube, Emergency Light, and Strobe Light.

• Uses _Starlight sprite resources for standard, empty, powered, emergency, and strobe light entities.
• Adds RSI metadata for the new 32×32 textures.
• Adds directional states for broken, burned, base, empty, glow, off, and on variants.
• Reduces pre-tinted coloring and adds reduced fake bloom to on states.
• Improves visibility of user-applied light colors.
• Does not change entity behavior or component configuration.

User impact

Players see cleaner wall-mounted light sprites. Powered lights include built-in fake bloom. Light Tube bloom is wider and less linear after review feedback.

Risk areas

• Sprite path changes can cause missing textures if any referenced RSI state or direction is incomplete.
• Fake bloom is sprite-based and may not scale as well as a shader-based effect.
• Visual changes may affect readability in dark areas and under different color settings.

Guideline gaps

• The available context does not state why these assets belong in Shared or why _Starlight is the correct placement.
• The available context does not identify Starlight ownership comments beyond metadata attribution.
• The available context does not mention localization impact.
• The available context does not explicitly state breaking-change impact.
• The design impact is described through review comments but does not define target bloom behavior or acceptance criteria.

Walkthrough

The change adds RSI metadata for Starlight lighting textures and updates lighting prototypes to use those resources. Entity behavior and component configuration remain unchanged.

Changes

Starlight lighting assets

Layer / File(s)	Summary
Lighting texture metadata Resources/Textures/_Starlight/Structures/Wallmounts/Lighting/*.rsi/meta.json	Added RSI metadata for directional tube, small, emergency, and strobe light states, including dimensions, licensing, attribution, and animation timing.
Lighting prototype sprite wiring Resources/Prototypes/Entities/Structures/Lighting/base_lighting.yml, Resources/Prototypes/Entities/Structures/Lighting/strobe_lighting.yml	Updated lighting entities to reference the corresponding _Starlight sprite resources. Entity behavior and component configuration remain unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title identifies the lighting resprite change and matches the primary purpose of the pull request.
Description check	✅ Passed	The description directly explains the lighting resprites, visual changes, motivation, and affected entities.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[redmushie]

I'm sorry but the fake bloom is just way too much. As someone with bad eyesight it unironically makes me think I need to squint to see correctly, but I'm seeing fine already, it's just the sprite.

I don't know if it needs less opacity or harder opacity falloff or smaller size but it needs to be waves hands around less.

[Conflee]

I'm sorry but the fake bloom is just way too much. As someone with bad eyesight it unironically makes me think I need to squint to see correctly, but I'm seeing fine already, it's just the sprite.

I don't know if it needs less opacity or harder opacity falloff or smaller size but it needs to be waves hands around less.

halved

OLD:

NEW:

[Conflee]

r4r

[redmushie]

I looked it up and what I'm thinking of is astigmatism. It's a condition that makes lights look like this:

It affects 30 to 40% of people, which includes me.

It's apparently caused by having multiple focal points, which is why the light tube bloom specifically is making my brain think I should squint to focus:

I don't have any problems with the light bulb however; I think the main problem with the tube for me is that the bloom is almost in a straight line. Do you think you could make it less straight-line-esque?

I'm speculating here but maybe bleed out a bit wider, as the tube itself illuminates in a circle anyways.

[Conflee]

I looked it up and what I'm thinking of is astigmatism. It's a condition that makes lights look like this:

It's apparently caused by having multiple focal points, which is why the light tube bloom specifically is making my brain think I should squint to focus:

I don't have any problems with the light bulb however; I think the main problem with the tube for me is that the bloom is almost in a straight line. Do you think you could make it less straight-line-esque?

I'm speculating here but maybe bleed out a bit wider, as the tube itself illuminates in a circle anyways.

new

[Conflee]

github services are down, rerun tests later

[wayiscool]

I'm gonna be honest, a shader that does this sort of thing would be a more robust method of having light bloom or light rays rather than a sprite. Using a sprite to fake the bloom "works" but isn't really optimal at all.

[Conflee]

I'm gonna be honest, a shader that does this sort of thing would be a more robust method of having light bloom or light rays rather than a sprite. Using a sprite to fake the bloom "works" but isn't really optimal at all.

maybe, but nobody in all of SS14 has coded one ever even in AGPL forks. Maybe an obscure Russian server has it but if they do their repo is private.

[redmushie]

So much better, thank you