Skip to content

More Avali Names - #5506

Merged
redmushie merged 8 commits into
ss14Starlight:starlight-devfrom
Orhu:orhu-MoreAvaliNames
Aug 4, 2026
Merged

More Avali Names#5506
redmushie merged 8 commits into
ss14Starlight:starlight-devfrom
Orhu:orhu-MoreAvaliNames

Conversation

@Orhu

@Orhu Orhu commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Short description

Adds 20 new avail first names, and 16 more avali and resomi pack names to the name generator.

Why we need to add this

So there will be less Runos.

Avali have only 20 random names. Resomi have 280, Thaven have 80, Rodentia have 100 per gender, Shadekin have 50...

Avali names aren't hard to come up with and more variety means less characters wind up having the same name. This is basically just making progress toward giving avali more unique names.

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 Orhu

  • add: Added more Avali first names and pack names to the name generator.

There are like 280 resomi names and only 20 avali ones. No fucking wonder there are 200 runos
@Orhu
Orhu requested a review from a team August 3, 2026 23:01
@github-actions github-actions Bot added Changes: No C# Changes: Prototypes S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S labels Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The change adds 20 Avali first names, 16 Avali pack names, and 16 Resomi pack names. It updates the Avali and Resomi prototype dataset counts to include the new entries.

Changes

Name dataset expansion

Layer / File(s) Summary
Localized entries and dataset counts
Resources/Locale/en-US/_Starlight/datasets/names/*, Resources/Prototypes/_Starlight/Datasets/Names/*
Adds Avali first-name entries 21–40, Avali pack entries 15–30, and Resomi pack entries 15–30. Updates the corresponding dataset counts.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: redmushie

🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Magic Numbers ✅ Passed The PR changes only localization data and excluded YAML prototypes; numeric suffixes are required 1-based dataset IDs, contiguous 1–40 or 1–30. Clear and well-structured.
No Hardcoded Ecs Parameters ✅ Passed The change is clean and data-only: it adds Fluent entries and updates localizedDataset counts; no ECS systems, components, or hardcoded behavior parameters are changed.
Avoid Service Locator ✅ Passed The change only updates .ftl localization entries and YAML dataset counts; scans found no service-locator or dependency-resolution calls, and all dataset ranges validate.
Title check ✅ Passed The title clearly identifies the main change: adding more Avali names.
Description check ✅ Passed The description explains the added Avali first names and Avali and Resomi pack names, and gives a clear reason for the change.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@wonderfulnewworld wonderfulnewworld left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files need to end in newlines

Comment thread Resources/Locale/en-US/_Starlight/datasets/names/avali_first.ftl Outdated
Comment thread Resources/Locale/en-US/_Starlight/datasets/names/avali_packs.ftl Outdated
Comment thread Resources/Locale/en-US/_Starlight/datasets/names/resomi_packs.ftl Outdated
Co-authored-by: Shin <99152399+wonderfulnewworld@users.noreply.github.com>
coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 4, 2026
Co-authored-by: Shin <99152399+wonderfulnewworld@users.noreply.github.com>
Co-authored-by: Shin <99152399+wonderfulnewworld@users.noreply.github.com>
@Orhu

Orhu commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

files need to end in newlines

fixed

coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 4, 2026
@starlightgithub starlightgithub Bot added S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Aug 4, 2026
@redmushie
redmushie added this pull request to the merge queue Aug 4, 2026
@redmushie redmushie self-assigned this Aug 4, 2026
Merged via the queue into ss14Starlight:starlight-dev with commit 53b21e5 Aug 4, 2026
26 checks passed
starlightgithub Bot added a commit that referenced this pull request Aug 4, 2026
@Orhu Orhu mentioned this pull request Aug 4, 2026
4 tasks
DisposalUnit pushed a commit to DisposalUnit/space-station-14 that referenced this pull request Aug 6, 2026
## Short description
Adds more new names to the random name generator for Avali (first and
pack names), Borgis (and all variants), Corgis, Cyclorites, Devils
(names and titles), Resomi (pack only), Shadekin, and Thaven.

## Why we need to add this
This change brings all playable species (that are original to starlight)
up to 100 random names. This is being done for the same reasons PR ss14Starlight#5506
was done. By bringing the number of random names up, we will wind up
seeing less characters with similar or identical names, making every
character feel more unique.

Some of the new borgi names are references to various robot dogs from
pop culture.

I also removed the name "Jax" from from the shadekin list. No idea why
it was in there. It really should not be for hopefully obvious reasons.

Number of new names added in each category:
- 60 new Avali first names (100 total)
- 10 new pack names (40 total)
- 19 new Borgi names (50 total)
- 19 new Corgi names (50 total)
- 5 new Syndiborgi names (20 total)
- 5 new Cyclorite names (100 total)
- 8 new Devil names (25 total)
- 8 new Devil titles (25 total)
- 52 new Shadekin names (100 total)
- 24 new Thaven names (100 total)

## Checks

- [x] I do not require assistance to complete the PR.
- [x] Before posting/requesting review of a PR, I have verified that the
changes work.
- [x] I have added screenshots/videos of the changes, or this PR does
not change in-game mechanics.
- [x] I affirm that my changes are licensed under the [MIT
License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT)
and grant permission for use in this repository under its conditions.

**Changelog**

:cl: Orhu
- add: Adds new random names for Avali (first and pack), Borgis (and all
variants), Corgis, Cyclorites, Devils (name and title), Resomi (pack
only), Shadekin, and Thaven.
- remove: Removed the name "Jax" from the Shadekin random name pool.
bynddark8 pushed a commit to bynddark8/space-station-14 that referenced this pull request Aug 6, 2026
## Short description
Adds more new names to the random name generator for Avali (first and
pack names), Borgis (and all variants), Corgis, Cyclorites, Devils
(names and titles), Resomi (pack only), Shadekin, and Thaven.

## Why we need to add this
This change brings all playable species (that are original to starlight)
up to 100 random names. This is being done for the same reasons PR ss14Starlight#5506
was done. By bringing the number of random names up, we will wind up
seeing less characters with similar or identical names, making every
character feel more unique.

Some of the new borgi names are references to various robot dogs from
pop culture.

I also removed the name "Jax" from from the shadekin list. No idea why
it was in there. It really should not be for hopefully obvious reasons.

Number of new names added in each category:
- 60 new Avali first names (100 total)
- 10 new pack names (40 total)
- 19 new Borgi names (50 total)
- 19 new Corgi names (50 total)
- 5 new Syndiborgi names (20 total)
- 5 new Cyclorite names (100 total)
- 8 new Devil names (25 total)
- 8 new Devil titles (25 total)
- 52 new Shadekin names (100 total)
- 24 new Thaven names (100 total)

## Checks

- [x] I do not require assistance to complete the PR.
- [x] Before posting/requesting review of a PR, I have verified that the
changes work.
- [x] I have added screenshots/videos of the changes, or this PR does
not change in-game mechanics.
- [x] I affirm that my changes are licensed under the [MIT
License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT)
and grant permission for use in this repository under its conditions.

**Changelog**

:cl: Orhu
- add: Adds new random names for Avali (first and pack), Borgis (and all
variants), Corgis, Cyclorites, Devils (name and title), Resomi (pack
only), Shadekin, and Thaven.
- remove: Removed the name "Jax" from the Shadekin random name pool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: No C# Changes: Prototypes S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants