Gas tank tweaks & fixes

[redmushie]

Short description

• Subfloor tank
  • Now retains gas when unanchored
  • Can no longer be picked up by hand
  • Can no longer be picked up by mechs
  • Has significant mass to deter dragging it around as canister alternative
• Tall gas tank
  • Now retains gas when unanchored
  • Can no longer be picked up by mechs
  • Entire bottom half is now clickable instead of only a small area
  • Clickable area no longer moves when rotated
  • Has significant mass to deter dragging it around as canister alternative

Why we need to add this

• Tall gas tank fixture fixes are bugfixes
• The other stuff is to make them better match expected behavior (I got feedback on this) and to improve their QoL while retaining balance (allowing gas retention, but with weight increase and no pickup possible).

Media (Video/Screenshots)

Subfloor tank gas retention & mass

2026-08-04.18-47-28.mp4

Tall tank: Collision, Visual targeting

2026-08-04.17-58-05.mp4

Tall tank: Unanchoring, Drag weight

2026-08-04.18-23-52.mp4

Tall tank: No mech pickup

2026-08-04.18-26-03.mp4

Checks

• I do not require assistance to complete the PR.
• Before posting/requesting review of a PR, I have verified that the changes work.
• I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
• I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 redmushie

• add: Subfloor- and tall gas tanks now retain gas when unanchored.
• add: Subfloor- and tall gas tanks are now quite heavy to drag around.
• tweak: Subfloor- and tall gas tanks can no longer be picked up by hand or by hydraulic clamp.
• fix: Tall gas tanks no longer have their clickable section move when oriented differently.
• fix: Tall gas tanks are now properly clickable on their lower half.

[coderabbitai]

📝 Walkthrough

Walkthrough

The change adds the NoMechGrab tag and applies it to subfloor and tall gas tanks. Both tank variants retain gas when unanchored and receive updated pickup, rendering, physics, and fixture settings.

Changes

Gas tank handling

Layer / File(s)	Summary
NoMechGrab tag contract and grabber filtering Content.Server/Mech/Equipment/Components/MechGrabberComponent.cs, Resources/Prototypes/_Starlight/tags.yml	The NoMechGrab tag is documented and excluded by the mech grabber blacklist.
Subfloor gas tank handling and physics Resources/Prototypes/_Starlight/Entities/Structures/Piping/Atmospherics/pipes.yml	Subfloor gas tanks retain gas when unanchored, prevent direct pickup, use non-colliding physics, and receive the NoMechGrab tag.
Tall gas tank handling and fixtures Resources/Prototypes/_Starlight/Entities/Structures/Piping/Atmospherics/pipes.yml	Tall gas tanks retain gas when unanchored, render above doors, use updated fixture density and placement, add a bottom interaction fixture, and receive the NoMechGrab tag.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• ss14Starlight/space-station-14#5473: This PR also modifies the subfloor and tall gas tank prototypes.

Suggested reviewers: rinary1

🚥 Pre-merge checks | ✅ 8

✅ Passed checks (8 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No Magic Numbers	✅ Passed	The only system addition is the string tag NoMechGrab; the numeric edits are confined to YAML prototypes, which this check excludes.
No Hardcoded Ecs Parameters	✅ Passed	The PR adds no system logic or hardcoded behavior values. MechGrabberSystem reads component.Blacklist, while tank behavior is configured through YAML component fields and fixtures. Good data-driven...
Avoid Service Locator	✅ Passed	The change adds only whitelist data and YAML tags/components; it adds no service resolution. Existing dependencies use the appropriate [Dependency] injection pattern.
Title check	✅ Passed	The title clearly identifies the gas tank changes and fixes covered by the pull request.
Description check	✅ Passed	The description clearly and accurately explains the gas tank behavior changes, fixes, and rationale.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Rinary1]

closed as stale