Skip to content

Reduce Pipe Noise Pollution - #5523

Merged
redmushie merged 7 commits into
ss14Starlight:starlight-devfrom
Omegalucky:reduce-gas-pipe-noise
Aug 6, 2026
Merged

Reduce Pipe Noise Pollution#5523
redmushie merged 7 commits into
ss14Starlight:starlight-devfrom
Omegalucky:reduce-gas-pipe-noise

Conversation

@Omegalucky

@Omegalucky Omegalucky commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Short description

Reducing noise pollution of active pipe types.

Why we need to add this

QOL. Related PR dicussion: https://discord.com/channels/1272545509562777621/1534522809278271549

Media (Video/Screenshots)

N/A

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 OMEGA

  • remove: Passive gate noise.
  • tweak: Reduced manual valve noise volume and radius.
  • tweak: Reduced signal valve noise volume and radius.

@Omegalucky
Omegalucky requested a review from a team August 5, 2026 12:49
@github-actions github-actions Bot added Changes: No C# Changes: Prototypes S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Summary

Reduces noise from active pipe controls as a quality-of-life change. The change does not alter gameplay balance.

User impact

  • Passive gate ambient sound is disabled.
  • Manual and signal-controlled valve sounds remain enabled.
  • Valve volume changes from -9 to -13.
  • Valve range changes from 5 to 3.

File changes

  • Updated Resources/Prototypes/Entities/Structures/Piping/Atmospherics/binary.yml.
  • No public or exported entities changed.

Risk areas

The change affects only ambient sound playback. It may make passive gates silent and make manual and signal-controlled valves less noticeable. No functional pipe behavior changes are described.

Validation

The available context reports a five-line addition and five-line removal. It provides no test, build, or in-game validation evidence.

Guideline gaps

  • No concrete validation evidence is provided.
  • No explanatory documentation or changelog entry is visible in the available PR context.

Walkthrough

This update changes ambient sound settings for passive gates, manual valves, and signal-controlled valves in one atmospherics prototype file.

Changes

Atmospherics audio tuning

Layer / File(s) Summary
Valve ambient sound values
Resources/Prototypes/Entities/Structures/Piping/Atmospherics/binary.yml
Passive gate ambient sound is disabled. Manual and signal-controlled valve volume changes from -9 to -13, and range changes from 5 to 3.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: redmushie, rinary1

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: reducing pipe noise.
Description check ✅ Passed The description explains the pipe noise reductions, quality-of-life purpose, related discussion, and changelog entries.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 5, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 5, 2026
@Omegalucky
Omegalucky marked this pull request as draft August 5, 2026 13:25
@Omegalucky
Omegalucky marked this pull request as ready for review August 5, 2026 13:25
Comment thread Resources/Prototypes/Entities/Structures/Piping/Atmospherics/binary.yml Outdated
Comment thread Resources/Prototypes/Entities/Structures/Piping/Atmospherics/binary.yml Outdated
Comment thread Resources/Prototypes/Entities/Structures/Piping/Atmospherics/binary.yml Outdated
@starlightgithub starlightgithub Bot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Aug 5, 2026
@redmushie redmushie self-assigned this Aug 5, 2026
…inary.yml

Co-authored-by: Red Mushie <82113471+redmushie@users.noreply.github.com>
Omegalucky and others added 2 commits August 6, 2026 12:40
…inary.yml

Co-authored-by: Red Mushie <82113471+redmushie@users.noreply.github.com>
…inary.yml

Co-authored-by: Red Mushie <82113471+redmushie@users.noreply.github.com>
@Omegalucky
Omegalucky requested a review from redmushie August 6, 2026 02:41
@github-actions github-actions Bot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Aug 6, 2026
@starlightgithub starlightgithub Bot added S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Aug 6, 2026
@redmushie
redmushie added this pull request to the merge queue Aug 6, 2026
Merged via the queue into ss14Starlight:starlight-dev with commit 4417186 Aug 6, 2026
27 of 29 checks passed
starlightgithub Bot added a commit that referenced this pull request Aug 6, 2026
bynddark8 pushed a commit to bynddark8/space-station-14 that referenced this pull request Aug 6, 2026
## Short description
<!-- What do you propose to change with your PR? -->

Reducing noise pollution of active pipe types.

## Why we need to add this
<!-- What is the reason for adding these changes? Please post links to
Discussions as well as Bug Reports here. Please describe how this will
change the game balance. -->

QOL. Related PR dicussion:
https://discord.com/channels/1272545509562777621/1534522809278271549

## Media (Video/Screenshots)
<!--
If your PR contains in-game changes you must provide screenshots/videos
of the changes.
-->

N/A

## Checks
<!-- check boxes for faster reviewing of your PR -->

- [x] I do not require assistance to complete the PR.
- [ ] Before posting/requesting review of a PR, I have verified that the
changes work.
- [ ] I have added screenshots/videos of the changes, or this PR does
not change in-game mechanics.
- [x] I affirm that my changes are licensed under the [MIT
License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT)
and grant permission for use in this repository under its conditions.

**Changelog**
<!--
If you want the players to know about changes made in this PR, specify
them using the template outside the comment. Short and informative.

:cl: STARLIGHT TEAM
- add: Added Starlight.
- remove: Removed SS13.
- tweak: Changed SS14.
- fix: Fixed Rinary.
-->

:cl: OMEGA
- remove: Passive gate noise.
- tweak: Reduced manual valve noise volume and radius.
- tweak: Reduced signal valve noise volume and radius.

---------

Co-authored-by: Red Mushie <82113471+redmushie@users.noreply.github.com>
bynddark8 pushed a commit to bynddark8/space-station-14 that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: No C# Changes: Prototypes S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants