[Admeme phase] WAR WIZARDS!!! - #5526
Merged
Merged
Conversation
bigger for face and back and change face color
github-actions
Bot
removed
the
S: Merge Conflict
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughSummaryAdds the Cryomancer and Pyromancer wizard paths.
Gameplay impact
Notable upstream-file changes
Risk areas
Guideline gaps
WalkthroughThe PR adds fire and frost wizard spellbook paths, their actions and effects, wizard equipment, summonable ice entities, store categories, localization, and supporting textures. Projectile spells now accept configurable speeds. ChangesWizard spellbook expansion
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Wizard
participant SpellbookCatalog
participant SpellAction
participant SharedMagicSystem
participant ProjectileEntity
Wizard->>SpellbookCatalog: purchase suit and spell
SpellbookCatalog->>SpellAction: grant purchased action
Wizard->>SpellAction: activate spell
SpellAction->>SharedMagicSystem: send ProjectileSpellEvent
SharedMagicSystem->>ProjectileEntity: spawn projectile at configured speed
ProjectileEntity->>Wizard: apply speech, trail, collision, or impact effects
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 9
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Locale/en-US/_Starlight/store/spellbook-catalog.ftl`:
- Around line 38-39: Update the player-facing values for the affected spellbook
description entries, including spellbook-firearrow-desc and the additional
entries identified by the comment, correcting “three arrow,” “damage anyone,” “a
ice,” “periodicly,” “shard,” and “blocks.” Keep all existing FTL keys unchanged
and modify only their displayed text.
In `@Resources/Prototypes/_Starlight/Catalog/spellbook_catalog.yml`:
- Around line 150-165: Resolve the duplicate listing around
SpellbookExplosionRune by removing the repeated entry or assigning it the
intended unique listing ID and corresponding productAction. Ensure no two
catalog listings share the SpellbookExplosionRune identifier, while preserving
the valid listing’s existing configuration.
In `@Resources/Prototypes/_Starlight/Entities/Clothing/Head/eva-helmets.yml`:
- Around line 164-168: Update the name and description of
ClothingHeadHelmetsoftsuitWizardFrost to describe the Frost/Cryomancer helmet
rather than the Pyromancer hood, while leaving its sprite and other entity
properties unchanged.
In `@Resources/Prototypes/_Starlight/Entities/Mobs/NPCs/summons.yml`:
- Line 5: Correct the player-facing text only: in
Resources/Prototypes/_Starlight/Entities/Mobs/NPCs/summons.yml lines 5-5,
replace “malovelent” with “malevolent”; in
Resources/Locale/en-US/_Starlight/ghost/roles/ghost-role-component.ftl lines
134-134, replace “survies” with “survives” and “at all cost” with “at all
costs”. Keep all internal identifiers unchanged.
In
`@Resources/Prototypes/_Starlight/Entities/Objects/Magic/projectile_spells.yml`:
- Around line 131-147: Update the description for ActionIceOrb to correct the
grammar and state that the orb throws icy shards every 1.5 seconds, matching
ProjectileIceOrb’s behavior. Preserve the rest of the description unchanged.
- Around line 78-80: Correct the displayed spell name and description from
“Artic” to “Arctic” in ActionArticGlare at
Resources/Prototypes/_Starlight/Entities/Objects/Magic/projectile_spells.yml
lines 78-80 and in the spellbook catalog values at
Resources/Locale/en-US/_Starlight/store/spellbook-catalog.ftl lines 53-54. Keep
the spellbook-articglare-* FTL keys unchanged; update only displayed values.
In `@Resources/Prototypes/_Starlight/Entities/Objects/Magic/spawn_spells.yml`:
- Around line 35-39: Update RuneSummonIce in
Resources/Prototypes/_Starlight/Entities/Objects/Magic/spawn_spells.yml:35-39 so
its TimedDespawn lifetime covers the complete 2.6-second summonice animation, or
shorten the animation accordingly. If retaining the two-second TimerTrigger
delay, adjust
Resources/Textures/_Starlight/Objects/Magic/summoning.rsi/meta.json:11-23 to
reduce the total frame duration to match it.
In `@Resources/Prototypes/explosion.yml`:
- Around line 139-149: Rename the firecolor field in the Incendiary explosion
prototype to fireColor, matching the established explosion prototype schema and
existing definitions.
In `@Resources/Textures/_Starlight/Mobs/Demons/icesculpture.rsi/meta.json`:
- Around line 3-14: Update the root copyright in the RSI metadata to “State
based copyright,” and add the “Romero/Littlemen” attribution to the icesculpture
state while preserving its existing name and directions.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 35432de8-81c9-43c3-8226-55b9daf425bb
⛔ Files ignored due to path filters (33)
Resources/Audio/_Starlight/Weapons/Guns/Gunshots/frozenbeam.oggis excluded by!**/*.oggResources/Textures/_Starlight/Clothing/Head/Hoods/wizardfire.rsi/equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/_Starlight/Clothing/Head/Hoods/wizardfire.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Starlight/Clothing/Head/Hoods/wizardfrost.rsi/equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/_Starlight/Clothing/Head/Hoods/wizardfrost.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Starlight/Clothing/OuterClothing/Suits/wizardfire.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/_Starlight/Clothing/OuterClothing/Suits/wizardfire.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Starlight/Clothing/OuterClothing/Suits/wizardfrost.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/_Starlight/Clothing/OuterClothing/Suits/wizardfrost.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Starlight/Mobs/Demons/icesculpture.rsi/icesculpture.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/articglare.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/eruption.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/eruptionrune.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/firearrows.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/firebolt.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/fireorb.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/iceorb.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/icepillars.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/icerune.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/iceshard.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/sculptureicon.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/summoning.rsi/summonice.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Battery/frozentome.rsi/base.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Battery/frozentome.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Battery/frozentome.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Battery/frozentome.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/eruptionbomb.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/firearrow.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/firebolt.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/fireorb.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/iceorb.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/iceshard.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/projectiles.rsi/muzzle_magic.pngis excluded by!**/*.png
📒 Files selected for processing (31)
Content.Shared/Magic/Events/ProjectileSpellEvent.csContent.Shared/Magic/SharedMagicSystem.csResources/Locale/en-US/_Starlight/ghost/roles/ghost-role-component.ftlResources/Locale/en-US/_Starlight/store/spellbook-catalog.ftlResources/Locale/en-US/magic/spells-actions.ftlResources/Locale/en-US/store/categories.ftlResources/Prototypes/Store/categories.ymlResources/Prototypes/Store/presets.ymlResources/Prototypes/_Starlight/Catalog/spellbook_catalog.ymlResources/Prototypes/_Starlight/Entities/Clothing/Head/eva-helmets.ymlResources/Prototypes/_Starlight/Entities/Clothing/OuterClothing/softsuits.ymlResources/Prototypes/_Starlight/Entities/Mobs/NPCs/summons.ymlResources/Prototypes/_Starlight/Entities/Objects/Magic/projectile_spells.ymlResources/Prototypes/_Starlight/Entities/Objects/Magic/rune_spells.ymlResources/Prototypes/_Starlight/Entities/Objects/Magic/spawn_spells.ymlResources/Prototypes/_Starlight/Entities/Objects/Weapons/Guns/Battery/battery_guns.ymlResources/Prototypes/_Starlight/Entities/Objects/Weapons/Guns/Projectiles/hitscan.ymlResources/Prototypes/_Starlight/Entities/Objects/Weapons/Guns/Projectiles/magic.ymlResources/Prototypes/_Starlight/Entities/Structures/Windows/window.ymlResources/Prototypes/_Starlight/Magic/ice_spells.ymlResources/Prototypes/explosion.ymlResources/Textures/_Starlight/Clothing/Head/Hoods/wizardfire.rsi/meta.jsonResources/Textures/_Starlight/Clothing/Head/Hoods/wizardfrost.rsi/meta.jsonResources/Textures/_Starlight/Clothing/OuterClothing/Suits/wizardfire.rsi/meta.jsonResources/Textures/_Starlight/Clothing/OuterClothing/Suits/wizardfrost.rsi/meta.jsonResources/Textures/_Starlight/Mobs/Demons/icesculpture.rsi/meta.jsonResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/meta.jsonResources/Textures/_Starlight/Objects/Magic/summoning.rsi/meta.jsonResources/Textures/_Starlight/Objects/Weapons/Guns/Battery/frozentome.rsi/meta.jsonResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/meta.jsonResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/projectiles.rsi/meta.json
💤 Files with no reviewable changes (1)
- Resources/Prototypes/_Starlight/Magic/ice_spells.yml
Contributor
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Contributor
Author
|
i'll let big brother ai review and correct everything wrong. I swear i went over it 4 time. |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@Resources/Prototypes/_Starlight/Entities/Objects/Magic/projectile_spells.yml`:
- Around line 1-3: Remove or override the inherited ActionUpgrade from
ActionFirebolt, ActionFireOrb, and ActionIceOrb so none of these actions
upgrades to ActionFireballII or ActionFireballIII. Apply the change at all three
listed locations in
Resources/Prototypes/_Starlight/Entities/Objects/Magic/projectile_spells.yml
while preserving their shared ActionFireball settings.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 0f2e7d79-f8ac-4d35-89cf-2c5a1c05b8b4
⛔ Files ignored due to path filters (33)
Resources/Audio/_Starlight/Weapons/Guns/Gunshots/frozenbeam.oggis excluded by!**/*.oggResources/Textures/_Starlight/Clothing/Head/Hoods/wizardfire.rsi/equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/_Starlight/Clothing/Head/Hoods/wizardfire.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Starlight/Clothing/Head/Hoods/wizardfrost.rsi/equipped-HELMET.pngis excluded by!**/*.pngResources/Textures/_Starlight/Clothing/Head/Hoods/wizardfrost.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Starlight/Clothing/OuterClothing/Suits/wizardfire.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/_Starlight/Clothing/OuterClothing/Suits/wizardfire.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Starlight/Clothing/OuterClothing/Suits/wizardfrost.rsi/equipped-OUTERCLOTHING.pngis excluded by!**/*.pngResources/Textures/_Starlight/Clothing/OuterClothing/Suits/wizardfrost.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Starlight/Mobs/Demons/icesculpture.rsi/icesculpture.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/articglare.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/eruption.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/eruptionrune.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/firearrows.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/firebolt.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/fireorb.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/iceorb.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/icepillars.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/icerune.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/iceshard.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/sculptureicon.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Magic/summoning.rsi/summonice.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Battery/frozentome.rsi/base.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Battery/frozentome.rsi/icon.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Battery/frozentome.rsi/inhand-left.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Battery/frozentome.rsi/inhand-right.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/eruptionbomb.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/firearrow.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/firebolt.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/fireorb.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/iceorb.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/iceshard.pngis excluded by!**/*.pngResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/projectiles.rsi/muzzle_magic.pngis excluded by!**/*.png
📒 Files selected for processing (31)
Content.Shared/Magic/Events/ProjectileSpellEvent.csContent.Shared/Magic/SharedMagicSystem.csResources/Locale/en-US/_Starlight/ghost/roles/ghost-role-component.ftlResources/Locale/en-US/_Starlight/store/spellbook-catalog.ftlResources/Locale/en-US/magic/spells-actions.ftlResources/Locale/en-US/store/categories.ftlResources/Prototypes/Store/categories.ymlResources/Prototypes/Store/presets.ymlResources/Prototypes/_Starlight/Catalog/spellbook_catalog.ymlResources/Prototypes/_Starlight/Entities/Clothing/Head/eva-helmets.ymlResources/Prototypes/_Starlight/Entities/Clothing/OuterClothing/softsuits.ymlResources/Prototypes/_Starlight/Entities/Mobs/NPCs/summons.ymlResources/Prototypes/_Starlight/Entities/Objects/Magic/projectile_spells.ymlResources/Prototypes/_Starlight/Entities/Objects/Magic/rune_spells.ymlResources/Prototypes/_Starlight/Entities/Objects/Magic/spawn_spells.ymlResources/Prototypes/_Starlight/Entities/Objects/Weapons/Guns/Battery/battery_guns.ymlResources/Prototypes/_Starlight/Entities/Objects/Weapons/Guns/Projectiles/hitscan.ymlResources/Prototypes/_Starlight/Entities/Objects/Weapons/Guns/Projectiles/magic.ymlResources/Prototypes/_Starlight/Entities/Structures/Windows/window.ymlResources/Prototypes/_Starlight/Magic/ice_spells.ymlResources/Prototypes/explosion.ymlResources/Textures/_Starlight/Clothing/Head/Hoods/wizardfire.rsi/meta.jsonResources/Textures/_Starlight/Clothing/Head/Hoods/wizardfrost.rsi/meta.jsonResources/Textures/_Starlight/Clothing/OuterClothing/Suits/wizardfire.rsi/meta.jsonResources/Textures/_Starlight/Clothing/OuterClothing/Suits/wizardfrost.rsi/meta.jsonResources/Textures/_Starlight/Mobs/Demons/icesculpture.rsi/meta.jsonResources/Textures/_Starlight/Objects/Magic/magicactions.rsi/meta.jsonResources/Textures/_Starlight/Objects/Magic/summoning.rsi/meta.jsonResources/Textures/_Starlight/Objects/Weapons/Guns/Battery/frozentome.rsi/meta.jsonResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/meta.jsonResources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/projectiles.rsi/meta.json
💤 Files with no reviewable changes (1)
- Resources/Prototypes/_Starlight/Magic/ice_spells.yml
🚧 Files skipped from review as they are similar to previous changes (27)
- Resources/Textures/_Starlight/Mobs/Demons/icesculpture.rsi/meta.json
- Resources/Textures/_Starlight/Clothing/Head/Hoods/wizardfire.rsi/meta.json
- Resources/Locale/en-US/_Starlight/ghost/roles/ghost-role-component.ftl
- Resources/Prototypes/Store/categories.yml
- Resources/Textures/_Starlight/Objects/Weapons/Guns/Battery/frozentome.rsi/meta.json
- Resources/Locale/en-US/store/categories.ftl
- Resources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/projectiles.rsi/meta.json
- Resources/Textures/_Starlight/Objects/Magic/magicactions.rsi/meta.json
- Resources/Prototypes/Store/presets.yml
- Resources/Prototypes/_Starlight/Entities/Mobs/NPCs/summons.yml
- Resources/Textures/_Starlight/Clothing/Head/Hoods/wizardfrost.rsi/meta.json
- Resources/Locale/en-US/magic/spells-actions.ftl
- Resources/Textures/_Starlight/Objects/Weapons/Guns/Projectiles/magic.rsi/meta.json
- Resources/Textures/_Starlight/Clothing/OuterClothing/Suits/wizardfrost.rsi/meta.json
- Content.Shared/Magic/SharedMagicSystem.cs
- Resources/Prototypes/_Starlight/Entities/Objects/Magic/spawn_spells.yml
- Resources/Prototypes/_Starlight/Entities/Clothing/OuterClothing/softsuits.yml
- Resources/Textures/_Starlight/Objects/Magic/summoning.rsi/meta.json
- Resources/Locale/en-US/_Starlight/store/spellbook-catalog.ftl
- Resources/Prototypes/_Starlight/Entities/Objects/Magic/rune_spells.yml
- Resources/Prototypes/_Starlight/Entities/Structures/Windows/window.yml
- Resources/Prototypes/_Starlight/Catalog/spellbook_catalog.yml
- Resources/Textures/_Starlight/Clothing/OuterClothing/Suits/wizardfire.rsi/meta.json
- Resources/Prototypes/explosion.yml
- Resources/Prototypes/_Starlight/Entities/Objects/Weapons/Guns/Projectiles/magic.yml
- Resources/Prototypes/_Starlight/Entities/Objects/Weapons/Guns/Battery/battery_guns.yml
- Content.Shared/Magic/Events/ProjectileSpellEvent.cs
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Prototypes/explosion.yml`:
- Around line 151-164: Wrap the added DefaultnoSpace explosion prototype block
with # Starlight-start before the block and # Starlight-end after it, preserving
the prototype contents and placement.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ee0fd647-d0d0-47ef-9d94-4475cdbea47f
📒 Files selected for processing (4)
Resources/Prototypes/_Starlight/Entities/Objects/Magic/rune_spells.ymlResources/Prototypes/_Starlight/Entities/Structures/Windows/window.ymlResources/Prototypes/explosion.ymlResources/Textures/_Starlight/Objects/Weapons/Guns/Battery/frozentome.rsi/meta.json
💤 Files with no reviewable changes (1)
- Resources/Prototypes/_Starlight/Entities/Structures/Windows/window.yml
🚧 Files skipped from review as they are similar to previous changes (1)
- Resources/Prototypes/_Starlight/Entities/Objects/Magic/rune_spells.yml
…a pr in public now
Conflee
approved these changes
Aug 10, 2026
Conflee
left a comment
Conflee
left a comment
Contributor
There was a problem hiding this comment.
Sprites approved for testing. Incendiary and Explosion Runes should be redone to match the other new Wizard Runes in the future however
walksanatora
approved these changes
Aug 10, 2026
starlightgithub
Bot
added
S: Approved
Merged
via the queue into
ss14Starlight:starlight-dev
with commit Aug 10, 2026
65b80ae
24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Oh my god this was bigger and more difficult than i had anticipated. I hope the pr goes well. Rinary/Redmushie if things are bad i am sorry i truly did my best.
This PR aim to add two wizard archetype tailored for an hostile gameplay: the Cryomancer and the Pyromancer.
Each kits for now cost 15 wizcoin and need admin intervention to be purchased, this is to test them and gather feedback before seeing them in regular shifts (i asked Cy for this).
Content wise this adds:
All sprites are made by me, the sound file i took from Pixabay, Sevenshade helped me a lot with the system change (thank you again).
Edit:
Also if this content is well received i do plan on adding more archetypes.
Why we need to add this
Wizard content is REALLY lacking, often resulting in either nothing burger or mass rodding/animation spam. This has caused a significant amount of suggestion calling for nerf or simple removal.
Thats because the option for a viable hostile wizard are all very unfun and not engaging. This pr aims to solve this.
The two kits are entirely tailored for combat while aiming for interacting gameplay. Both have strengh, weaknessed and counter. The wizard wont be able to just wipe the station but will take a significant amount attention and ressources to put down.
Media (Video/Screenshots)
Too much to put here, the fire suit is animated and so are a lot of the spells/rune/tome
Checks
Changelog
🆑 Romero/Littlemen, with thanks to SevenShade