Lagan stir stir, ice cream and other chore pass...

[Cvlancer]

Short description

Doing another small chore pass with some few services changes.

Why we need to add this

#5250 #5458 #5463

Media (Video/Screenshots)

Checks

• I do not require assistance to complete the PR.
• Before posting/requesting review of a PR, I have verified that the changes work.
• I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
• I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 Cvlancer

• add: (LAGAN) Added stir stir to gen pop.
• add: (LAGAN) Added ice cream maker to kitchen.
• add: (LAGAN) Added Vend of silence mimes room.
• add: (LAGAN) Added ticket machine to cargo.
• add: (LAGAN) Added another fuel dispenser to robotics.
• add: (LAGAN) Added a coffee dispenser and sink to the side bar.
• add: (LAGAN) Added that uhh penguin pet to court house.
• add: (LAGAN) Added a second window to the hop line for someone to help.
• remove: (LAGAN) Removed a random railing in solitary.
• remove: (LAGAN) Removed the linking from hop window and warden windows.
• tweak: (LAGAN) Changed genpop's turnstiles glass firelocks with the wall variant.
• tweak: (LAGAN) Changed moved kitchen around a bit.

[coderabbitai]

📝 Walkthrough

Summary

• Updates the Lagan station map under the LAGAN scope.
• Adds Stir Stir, an ice cream maker, a Vend of Silence, a cargo ticket machine, a robotics fuel dispenser, a coffee dispenser, a sink, a courthouse penguin, and a second HoP line window.
• Removes selected railings and HoP–warden window links.
• Changes gen pop turnstile glass firelocks to wall variants.
• Rearranges the kitchen.
• Updates map metadata, tile data, decals, door timers, entity transforms, machine contents, atmospherics filters, and device-link wiring.
• Replaces legacy single-value gas filters with filteredGases lists.
• Removes obsolete entities and device-link source connections.
• Reverts the engineering tech fabricator and paddy removal.

Gameplay and user impact

• Lagan gains new service, security, cargo, robotics, kitchen, and courthouse fixtures.
• The kitchen gains ice cream and coffee equipment.
• The courthouse gains a penguin pet.
• HoP access gains an additional service window.
• Solitary, paddy, gen pop, and HoP–warden window layouts change.
• Atmospherics filter configuration uses the newer list-based schema.

Notable upstream-file changes

• Changes are limited to Resources/Maps/_Starlight/Stations/Lagan.yml.
• No exported or public declarations change.
• The file changes by approximately 326 additions and 249 removals.

Risk areas

• Map entity placement and transform changes can create overlap, inaccessible equipment, or incorrect room layouts.
• Device-link changes can break connected machinery or leave stale links.
• Atmospherics schema changes can alter gas routing.
• Firelock and window changes can affect access control and containment.
• New machines require correct anchoring, power, contents, and interaction behavior.

Validation evidence

• The available PR context provides no test, map validation, runtime verification, or screenshot-based validation result.
• The PR description includes map screenshots that show intended placements, but it does not state how they were verified.

Guideline gaps

• The PR does not explain the rationale for the full set of map changes.
• The PR does not state whether Shared-first placement was considered.
• The PR does not include Starlight ownership comments.
• The PR does not provide explanatory documentation for the device-link and atmospherics changes.
• The PR does not mention localization review for added player-visible content.
• The PR does not provide explicit validation evidence.
• The available context does not show changelog formatting or a changelog entry.
• The PR does not address the reported absence of a vital monitor or an additional criminal record.

Walkthrough

The Lagan station map data was updated with new tiles, decals, entities, equipment, machine configurations, atmospherics filters, door timers, and device-link wiring. Obsolete map records and entities were removed.

Changes

Lagan station map

Layer / File(s)	Summary
Map layout and metadata Resources/Maps/_Starlight/Stations/Lagan.yml	Map metadata, serialized tile data, decals, directional markers, and obsolete map references were updated.
Station infrastructure and device wiring Resources/Maps/_Starlight/Stations/Lagan.yml	Door timers and gas filter schemas were updated. Obsolete device networks were removed. Floor drains and secure windoor device links were changed.
Fabrication equipment and technology data Resources/Maps/_Starlight/Stations/Lagan.yml	Cargo, engineering, science, and service fabricators were added or updated. Technology disciplines and obsolete fabrication entities were changed.
Station objects and placements Resources/Maps/_Starlight/Stations/Lagan.yml	Furniture, fixtures, decorations, machines, media-area objects, and miscellaneous transforms were added, removed, or repositioned.
Kitchen and spawn placements Resources/Maps/_Starlight/Stations/Lagan.yml	Kitchen equipment and props were rearranged. Monkey and penguin spawn entities were added. Obsolete spawn data was removed.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Suggested labels: T: Rework

Suggested reviewers: redmushie

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title identifies the Lagan map chore pass and names several primary additions, although it omits some secondary changes.
Description check	✅ Passed	The description explains the Lagan map changes, references related issues, includes media, and provides a changelog.
Linked Issues check	✅ Passed	The description links issues #5250, #5458, and #5463 that are identified as related to the map and service changes.
Out of Scope Changes check	✅ Passed	The reported changes remain within the stated Lagan map and service chore scope.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Resources/Maps/_Starlight/Stations/Lagan.yml`:
- Around line 92598-92623: Remove the duplicate EngineeringTechFab entity at the
shared position -22.5,42.5, or move one of the entities identified by UIDs 1080
and 31155 to a separate accessible tile. Verify the resulting entity and
prototype references and grid placement so only one fabricator occupies that
tile.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d3199c7a-8bc0-41c2-a718-0fab8fd48f13

📥 Commits

Reviewing files that changed from the base of the PR and between 32ef983 and 1236cb2.

📒 Files selected for processing (1)

• Resources/Maps/_Starlight/Stations/Lagan.yml

[Littlemen07]

Removed the paddy despite the nerf but didnt add the vital monitor or another criminal record 💀

[CawsForConcern]

approved, but you don't need to remove the paddy from maps - it got changed to be nonlethal again in #5488