Incendiary ammunition nerf. - #5543
Conversation
Just removed HItscanIgniteEffect component from the bullet. That's it. As much as i wanted to reduce it on buckshot - i don't think you can without knowing C#.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummaryRemoves User impactIncendiary ammunition no longer applies fire stacks when it hits a person. This includes incendiary buckshot and regular incendiary shots. Existing blunt and heat damage remain unchanged. File changes
Risk areas
Guideline gaps
WalkthroughThe change removes Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
rejected, Incendiary should provide fire... Because their purpose lies in their incendiary effect |
|
Imo incendiary would be just fine with just "burning the target from inside out"(aka dealing heat), which would be the more intended purpose of it. |
Short description
This PR removes HitscanIgniteEffect component from incendiary ammo, making it not grant fire stacks on shooting a person.
That's it. As much as i wanted to reduce it on buckshot - i don't think you can without knowing C#.
Why we need to add this
Incendiary by itself is a very solid early tech ammo by the virtue of applying most of it's damage as blunt and heat damage mix.
However, addition of it being able to add fire stacks has made it completely impossible to fight against anywhere outside of spaced areas - no hardsuit besides Atmos and elite hardsuits - do not provide perfect fire resist, making it into a DoT applied on you every single time.
What made it worse was how fire system works without a hardsuit - and that is: fire stacks applying a temperature increase, making the heat damage constant and heavily punishing for not having fire protection(which is REALLY scarce and outside of hardsuits, and elite web vest - there isn't much safety from it besides a fire suit. Which, c'mon).
It was bad on both a buckshot(due to every pellet counting towards the effect, giving you max of them in a single shot) and regular shots(due to volume of fire just giving you massive fire stacks in almost a second).
Media (Video/Screenshots)
incen.test.mp4
Checks
Changelog
🆑 DisposalUnit