Skip to content

Incendiary ammunition nerf. - #5543

Closed
DisposalUnit wants to merge 2 commits into
ss14Starlight:starlight-devfrom
DisposalUnit:incend-kill
Closed

Incendiary ammunition nerf.#5543
DisposalUnit wants to merge 2 commits into
ss14Starlight:starlight-devfrom
DisposalUnit:incend-kill

Conversation

@DisposalUnit

@DisposalUnit DisposalUnit commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Short description

This PR removes HitscanIgniteEffect component from incendiary ammo, making it not grant fire stacks on shooting a person.
That's it. As much as i wanted to reduce it on buckshot - i don't think you can without knowing C#.

Why we need to add this

Incendiary by itself is a very solid early tech ammo by the virtue of applying most of it's damage as blunt and heat damage mix.
However, addition of it being able to add fire stacks has made it completely impossible to fight against anywhere outside of spaced areas - no hardsuit besides Atmos and elite hardsuits - do not provide perfect fire resist, making it into a DoT applied on you every single time.
What made it worse was how fire system works without a hardsuit - and that is: fire stacks applying a temperature increase, making the heat damage constant and heavily punishing for not having fire protection(which is REALLY scarce and outside of hardsuits, and elite web vest - there isn't much safety from it besides a fire suit. Which, c'mon).
It was bad on both a buckshot(due to every pellet counting towards the effect, giving you max of them in a single shot) and regular shots(due to volume of fire just giving you massive fire stacks in almost a second).

Media (Video/Screenshots)

incen.test.mp4

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 DisposalUnit

  • tweak: Incendiary ammo of all types no longer applies fire stacks.

Just removed HItscanIgniteEffect component from the bullet. That's it.
As much as i wanted to reduce it on buckshot - i don't think you can without knowing C#.
@DisposalUnit
DisposalUnit requested a review from a team August 6, 2026 15:11
@github-actions github-actions Bot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 799af386-1efc-423e-88f1-df26d24ecdea

📥 Commits

Reviewing files that changed from the base of the PR and between 6bab688 and 3a78b7f.

📒 Files selected for processing (1)
  • Resources/Prototypes/_Starlight/Entities/Objects/Weapons/Guns/Projectiles/hitscan.yml
💤 Files with no reviewable changes (1)
  • Resources/Prototypes/_Starlight/Entities/Objects/Weapons/Guns/Projectiles/hitscan.yml

📝 Walkthrough

Summary

Removes HitscanIgniteEffect from five Starlight incendiary projectile prototypes: magnum, pistol, light-rifle, rifle, and shotgun.

User impact

Incendiary ammunition no longer applies fire stacks when it hits a person. This includes incendiary buckshot and regular incendiary shots. Existing blunt and heat damage remain unchanged.

File changes

  • Updated Resources/Prototypes/_Starlight/Entities/Objects/Weapons/Guns/Projectiles/hitscan.yml.
  • Removed five HitscanIgniteEffect declarations.
  • No upstream or Shared files changed.

Risk areas

  • Confirm that all intended incendiary variants no longer apply fire stacks.
  • Confirm that existing damage and projectile behavior remain unchanged.
  • Confirm that incendiary ammunition retains its intended heat damage.

Guideline gaps

  • The PR does not state whether the Starlight-only placement follows the Shared-first convention.
  • The PR does not include a Starlight ownership comment.
  • The PR does not describe the design rationale or impact beyond the fire-stack reduction.

Walkthrough

The change removes HitscanIgniteEffect from five incendiary hitscan projectile prototypes. Their damage and projectile behavior remain unchanged.

Changes

Cohort / File(s) Summary
Incendiary projectile configuration
Resources/Prototypes/_Starlight/Entities/Objects/Weapons/Guns/Projectiles/hitscan.yml
Removes HitscanIgniteEffect from incendiary magnum, pistol, light-rifle, rifle, and shotgun projectile prototypes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: reducing incendiary ammunition effects.
Description check ✅ Passed The description explains that removing HitscanIgniteEffect stops incendiary ammunition from applying fire stacks and gives the balance reason.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@Rinary1

Rinary1 commented Aug 11, 2026

Copy link
Copy Markdown
Member

rejected, Incendiary should provide fire... Because their purpose lies in their incendiary effect

@Rinary1 Rinary1 closed this Aug 11, 2026
@DisposalUnit

Copy link
Copy Markdown
Contributor Author

Imo incendiary would be just fine with just "burning the target from inside out"(aka dealing heat), which would be the more intended purpose of it.
Considering that fire in this game is overpowered, period. But eh.

@DisposalUnit
DisposalUnit deleted the incend-kill branch August 13, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: No C# Changes: Prototypes S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants