Skip to content

Avali, Reptillians, and Noctiliae can now eat Phenylpiperidine crystals - #5547

Merged
Rinary1 merged 1 commit into
ss14Starlight:starlight-devfrom
wonderfulnewworld:fixes/crystals-for-all
Aug 11, 2026
Merged

Avali, Reptillians, and Noctiliae can now eat Phenylpiperidine crystals#5547
Rinary1 merged 1 commit into
ss14Starlight:starlight-devfrom
wonderfulnewworld:fixes/crystals-for-all

Conversation

@wonderfulnewworld

@wonderfulnewworld wonderfulnewworld commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Short description

Avali, Reptillians, and Noctiliae can now eat Phenylpiperidine crystals.

Why we need to add this

They couldn't eat it before, due to their special stomachs.

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog
🆑 wonderfulnewworld

  • fix: Avali, Reptillians, and Noctiliae can now eat Phenylpiperidine crystals.

@wonderfulnewworld
wonderfulnewworld requested a review from a team August 6, 2026 23:18
@wonderfulnewworld wonderfulnewworld changed the title Avali, Reptillians, and Moths can now eat Phenylpiperidine crystals Avali, Reptillians, and Noctiliae can now eat Phenylpiperidine crystals Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Summary

Adds the Pill tag to PhenylpiperidineSolidified.

This allows Avali, Reptillians, and Moths to eat Phenylpiperidine crystals despite their special stomach rules.

Notable changes

  • Updates Resources/Prototypes/_Mono/Entities/Objects/Misc/solids.yml.
  • Adds a Tag component with the Pill tag to PhenylpiperidineSolidified.

Risk areas

  • The change affects species-specific food handling.
  • No additional validation evidence is provided.

Guideline gaps

  • The PR body does not provide validation evidence.
  • The PR body does not explain why the Pill tag is the correct gameplay mechanism.
  • No localization or changelog information is provided.

Walkthrough

The PhenylpiperidineSolidified entity now includes a Tag component with the Pill tag.

Changes

Pill tag assignment

Layer / File(s) Summary
Assign the Pill tag
Resources/Prototypes/_Mono/Entities/Objects/Misc/solids.yml
Adds the Tag component and assigns the Pill tag to PhenylpiperidineSolidified.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: redmushie, rinary1

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the primary gameplay change: the listed species can eat Phenylpiperidine crystals.
Description check ✅ Passed The description explains the affected species, the stomach compatibility issue, and the intended fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Resources/Prototypes/_Mono/Entities/Objects/Misc/solids.yml`:
- Around line 44-46: Move the Starlight-only Tag override for Pill out of the
shared solids prototype and into the corresponding mirrored _Starlight prototype
path, preserving the override there without changing shared behavior.
- Around line 44-46: Align the new Pill metadata in the affected solid prototype
with the existing pill contract: either add the required Pill parent metadata
alongside the Tag or update the Avali/Reptillian/Moth stomach consumers to use
the metadata this prototype actually provides. Reuse the established contract
from existing chemistry pill prototypes and ensure the solid is accepted by the
intended pill whitelist.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 56b9082a-2e63-4c38-bcec-3058b89d10ea

📥 Commits

Reviewing files that changed from the base of the PR and between b58f507 and bc81c96.

📒 Files selected for processing (1)
  • Resources/Prototypes/_Mono/Entities/Objects/Misc/solids.yml

Comment thread Resources/Prototypes/_Mono/Entities/Objects/Misc/solids.yml
@github-actions github-actions Bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Changes: No C# Changes: Prototypes S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed size/XS labels Aug 6, 2026
@starlightgithub starlightgithub Bot added S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Aug 11, 2026
@Rinary1
Rinary1 added this pull request to the merge queue Aug 11, 2026
Merged via the queue into ss14Starlight:starlight-dev with commit 0caaf0b Aug 11, 2026
27 of 33 checks passed
starlightgithub Bot added a commit that referenced this pull request Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: No C# Changes: Prototypes S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants