Skip to content

No more infinite cake - #5548

Merged
walksanatora merged 1 commit into
ss14Starlight:starlight-devfrom
wonderfulnewworld:fixes/infinite-cake-no-more
Aug 7, 2026
Merged

No more infinite cake#5548
walksanatora merged 1 commit into
ss14Starlight:starlight-devfrom
wonderfulnewworld:fixes/infinite-cake-no-more

Conversation

@wonderfulnewworld

Copy link
Copy Markdown
Contributor

Short description

No more infinite cotton cake

Why we need to add this

Infinite bug bad

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog
🆑 wonderfulnewworld

  • fix: Cotton cake can no longer be sliced infinitely.

@wonderfulnewworld
wonderfulnewworld requested a review from a team August 7, 2026 06:27
@github-actions github-actions Bot added size/XS S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Prototypes S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Aug 7, 2026
@TaserTheFox

Copy link
Copy Markdown
Contributor

#5549
rip duplicate

@walksanatora walksanatora left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p0

@starlightgithub starlightgithub Bot added S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Aug 7, 2026
@walksanatora
walksanatora enabled auto-merge August 7, 2026 06:28
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7a3fd07d-f641-4513-ad4c-cc6004fb9e74

📥 Commits

Reviewing files that changed from the base of the PR and between 1ada28a and 2447b16.

📒 Files selected for processing (1)
  • Resources/Prototypes/_Starlight/Entities/Objects/Consumable/Food/Baked/cake.yml

📝 Walkthrough

Summary

FoodCottonCakeSlice now inherits from FoodCakeSliceBase. This prevents cotton cake slices from being treated as whole cotton cakes and sliced repeatedly.

User impact

Cotton cake can no longer generate an infinite number of slices.

Notable changes

  • Updated Resources/Prototypes/_Starlight/Entities/Objects/Consumable/Food/Baked/cake.yml.
  • Changed the parent entity for FoodCottonCakeSlice.

Risk areas

The inheritance change could affect cotton cake slice behavior if FoodCakeSliceBase does not provide all required properties. The change is limited to one prototype declaration.

Guideline gaps

None identified from the available PR context.

Walkthrough

FoodCottonCakeSlice now inherits from FoodCakeSliceBase instead of FoodCottonCake.

Changes

Cake slice inheritance

Layer / File(s) Summary
Update cake slice parent
Resources/Prototypes/_Starlight/Entities/Objects/Consumable/Food/Baked/cake.yml
FoodCottonCakeSlice now uses the generic FoodCakeSliceBase parent.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: redmushie, rinary1

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the fix for the infinite cotton cake slicing bug.
Description check ✅ Passed The description explains that the change prevents cotton cake from being sliced infinitely.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@walksanatora
walksanatora added this pull request to the merge queue Aug 7, 2026
Merged via the queue into ss14Starlight:starlight-dev with commit f3ff201 Aug 7, 2026
26 of 27 checks passed
starlightgithub Bot added a commit that referenced this pull request Aug 7, 2026
Limerent-Sun pushed a commit to Blimpuf-Station/BlimpufStation that referenced this pull request Aug 7, 2026
## Short description
No more infinite cotton cake

## Why we need to add this
Infinite bug bad

## Checks
- [X] I do not require assistance to complete the PR.
- [X] Before posting/requesting review of a PR, I have verified that the
changes work.
- [X] I have added screenshots/videos of the changes, or this PR does
not change in-game mechanics.
- [X] I affirm that my changes are licensed under the [MIT
License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT)
and grant permission for use in this repository under its conditions.

**Changelog**
:cl: wonderfulnewworld
- fix: Cotton cake can no longer be sliced infinitely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: No C# Changes: Prototypes S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants