Allow selection of multiple roles/departments when configuring access - #5555
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummaryThe access configurator now supports access levels from multiple departments or roles.
This prevents department changes from discarding earlier selections. The main risk is incorrect state merging when selections are added or cleared across departments. Guideline gaps
WalkthroughThe access overrider and door electronics configuration menu now retain and submit pressed access levels from all access groups. The overrider caches non-visible levels and merges them with visible button states before submission. ChangesAccess preservation
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Content.Client/Access/UI/AccessOverriderWindow.xaml.cs`:
- Around line 21-27: Add a `#region` Starlight block around the new _pressedAccess
field and a separate `#region` Starlight block around BuildAccessList, preserving
the existing // Starlight-edit ownership markers and leaving surrounding members
unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a75cdfe2-11dd-4a7f-9269-c283142efcfd
📒 Files selected for processing (2)
Content.Client/Access/UI/AccessOverriderWindow.xaml.csContent.Client/Doors/Electronics/DoorElectronicsConfigurationMenu.xaml.cs
5f1ff9f
Short description
Enables the multiool and access configurator to configure access from any department, no longer limited to one.
Why we need to add this
Currently if you select an access level for a device, it is discarded if you select another department to add more roles. This change will remove this limitation.
Media (Video/Screenshots)
AccessreadermultiplecategoriesH.265.mp4
Checks
Changelog
🆑 OMEGA