Allow partial smellers to detect bodies in closed containers

[Sparlight]

Short description

Based on a request from SnakeNuke. Seemed reasonable.
Partial smellers (vulpkanins) can now detect bodies inside closed containers, with a faint scent emission.
This primarily is intended to help with paramedic work, and aid in discoverability of corpses hidden in maints.

Why we need to add this

Putting a corpse in a locker is basically round removal. Bodies in closets can be detected by full smellers already; but we're doing a carve-out for corpses being detected in closets by partial smellers. Makes sense for a corpse to smell bad anyway.

Media (Video/Screenshots)

Sparlight.s.Dev.Server.-.Starlight.2026-08-08.11-14-20.mp4

Checks

• I do not require assistance to complete the PR.
• Before posting/requesting review of a PR, I have verified that the changes work.
• I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
• I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 Sparlight

• add: Partial smellers can now faintly perceive the scent emissions of corpses inside closed containers.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 15fda947-d765-4dc5-bbcc-5542d1f48ebc

📥 Commits

Reviewing files that changed from the base of the PR and between ce399d0 and f68f2ec.

📒 Files selected for processing (1)

• Content.Shared/_Starlight/Scent/Components/ScentMarkerComponent.cs

🚧 Files skipped from review as they are similar to previous changes (1)

• Content.Shared/_Starlight/Scent/Components/ScentMarkerComponent.cs

---

📝 Walkthrough

Summary

Partial smellers can detect scent markers from corpses inside closed containers. Non-corpse scent markers remain hidden from partial smellers.

This supports paramedic and K9 gameplay. It helps players find corpses hidden in lockers and maintenance areas before they rot.

Changes

• Added the networked, serialized WasDead flag to ScentMarkerComponent.
• Recorded the emitter's dead state when the server creates or refreshes scent markers.
• Updated partial-smeller filtering to reveal contained markers only when WasDead is true.
• Limited changes to Starlight scent systems. No upstream files changed.

Risk areas

• Partial smellers can now detect corpse scent through closed containers.
• The system must not reveal contained scent from living entities or other non-corpse emitters.
• Existing full-smeller detection remains unchanged.
• Network serialization must preserve WasDead between the server and client.
• The dead-state snapshot can become stale if an emitter changes state after a marker is emitted or refreshed.

Guideline gaps

None identified from the available PR context.

Walkthrough

Scent markers now record whether their emitter was dead at emission or refresh time. Partial perception no longer hides contained markers marked WasDead.

Changes

Scent marker visibility

Layer / File(s)	Summary
Record emitter death state Content.Shared/_Starlight/Scent/Components/ScentMarkerComponent.cs, Content.Server/_Starlight/Scent/Systems/ScentSystem.cs	ScentMarkerComponent adds the networked WasDead field. New and refreshed markers set the field from the emitter’s current mob state.
Apply death state to filtering Content.Client/_Starlight/Scent/Systems/ScentTrackingSystem.cs	Partial-perception filtering hides contained markers only when WasDead is false.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• ss14Starlight/space-station-14#5500: Introduces the scent marker state extended by this change.
• ss14Starlight/space-station-14#5557: Modifies the same scent marker state and partial-perception filtering paths with a separate visibility flag.

Suggested reviewers: redmushie

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: partial smellers can detect bodies inside closed containers.
Description check	✅ Passed	The description directly explains the corpse-detection change, its intended paramedic use, and its gameplay rationale.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Content.Server/_Starlight/Scent/Systems/ScentSystem.cs`:
- Line 459: Update both IsDead calls in ScentSystem, including the assignments
to markerComp.WasDead at the referenced locations, to use the injected
MobStateSystem dependency and its overload that accepts the resolved
MobStateComponent; do not reference an undeclared MobState receiver.

In `@Content.Shared/_Starlight/Scent/Components/ScentMarkerComponent.cs`:
- Around line 31-34: Replace the line comment above ScentMarkerComponent.WasDead
with XML documentation describing whether the emitter was dead when the scent
was emitted or when the marker was last refreshed through merging. Keep the
documentation accurate for both initial emission and ScentSystem merge updates.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f60e266a-e422-4817-8820-f757868637b2

📥 Commits

Reviewing files that changed from the base of the PR and between e22931e and ce399d0.

📒 Files selected for processing (3)

• Content.Client/_Starlight/Scent/Systems/ScentTrackingSystem.cs
• Content.Server/_Starlight/Scent/Systems/ScentSystem.cs
• Content.Shared/_Starlight/Scent/Components/ScentMarkerComponent.cs

[Sparlight]

@coderabbitai re-review

[coderabbitai]

@Sparlight I will re-review the current changes.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.