let get live - #5623
Merged
Merged
Conversation
* dont spawn attached to entity * fdsadagagd * space * next Vector2 * more efficient * refactor: removed unused using --------- Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com> Co-authored-by: Fildrance <fildrance@gmail.com>
## Short description This fixes the shuttle console being locked and not usable by abductors ## Why we need to add this I was not aware that abductors had an event listener that prevent them for using any access locked systems what so ever so even if a console was not locked to anyone they couldn't use it. This PR changes the abductor shuttle so that its not locked and cannot be locked by others to fix this problem ## Media (Video/Screenshots) N/A ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: RedSpeeds - fix: Fixed Abductors not being able to interact with their shuttle console.
## Short description <!-- What do you propose to change with your PR? --> A remake of Lobster from the ground up. Requires: - #5282 - #5283 - #5284 - #5285 - #5286 - #5287 - #5345 **Map is intentionally not added to the map pool with this PR** - it will be in the future, but I'd like to run a few admin-supervised play tests of the map to make sure the heating system isn't a complete disaster. ### Features It's now very cold outside (-65C), [so you better bundle up with your winter clothing](#4388). There's roundstart weather now! A perpetual snowstorm batters the new Lobster station at all hours of the night. <img width="480" height="372" alt="snow" src="https://github.com/user-attachments/assets/dfdadfc9-2a9b-49d4-b720-cf2265fe2136" /> - A new parallax ft. sprite art by @wayiscool (see Media!) - Departments are actually warmed by heaters! Heating rooms are marked by brand new signs (ft. sprites by @SevenShadesofStarlight ) and are dual-access, letting both Engineering and the relevant department adjust their thermostats. - New signs for Robotics Surgery by @Conflee! <img width="480" alt="image" src="https://github.com/user-attachments/assets/7f9e3278-6bc3-41b4-aaed-0bc2c924958b" /> ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> I could write a lot about why Lobster is a problem. I'll keep it short: 1. **Lobster has no atmospheric challenges.** "Space" is too safe, which makes this one of _the_ most played maps on both Alpha and Beta. 2. **Players generally don't like how the floor of the station looks** (too chaotic, too noisy). This is the only station where I've seen people group up to replace the entire floor of the station because they just don't like it that much. 3. **Atmospherics and Engineering get bored on this map.** There's just not much to do. 4. **Lobster has some weird layout issues.** The RD has to get access through Engineering to card the AI. On Novo Lobster, there's a big pathway that the RD can take to get there instead. 5. **Lack of Maints.** You can't access the west side of Science except by flying around the outside of the map. There's no back-door to Kitchen, Botany, or Atmospherics. There's just a bunch of places where maints _should_ be, but aren't. Making it dangerously cold outside is my way of making the map more interesting. It's way less deadly than space and it encourages people to interact with the winter clothing we have. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="7008" height="5024" alt="StarlightNovoLobster-0" src="https://github.com/user-attachments/assets/c8ed69de-8462-4cc8-8d41-d9fa152a1cf9" /> <img width="1299" height="1004" alt="image" src="https://github.com/user-attachments/assets/6254d251-d649-4ec7-b67f-38645cbe704d" /> <img width="1300" height="999" alt="image" src="https://github.com/user-attachments/assets/a1aa0fff-b98e-4581-ae4a-99b2b2bb3c9b" /> <img width="1293" height="1002" alt="image" src="https://github.com/user-attachments/assets/6710a2e7-e90e-4778-aebb-b04fe6535da4" /> <img width="1293" height="998" alt="image" src="https://github.com/user-attachments/assets/40ee2691-f77b-4020-8fba-de8a7f6e7a04" /> <img width="1301" height="1003" alt="image" src="https://github.com/user-attachments/assets/2c23f6b0-2c9b-43b0-92ec-d21ce24a9579" /> <img width="1293" height="997" alt="image" src="https://github.com/user-attachments/assets/c1ce7656-64d0-409d-9771-f0b33cff1ddf" /> <img width="1298" height="1001" alt="image" src="https://github.com/user-attachments/assets/29310a3d-0639-4322-8fab-01056465be42" /> <img width="1294" height="996" alt="image" src="https://github.com/user-attachments/assets/bb48a975-3243-4598-abe8-2519e0fafe27" /> <img width="1295" height="999" alt="image" src="https://github.com/user-attachments/assets/fd9a99a9-a24b-4f0a-beb2-53f69296ea94" /> <img width="1294" height="1001" alt="image" src="https://github.com/user-attachments/assets/74bb2560-cf39-4737-814b-3f07ecce9493" /> <img width="1299" height="998" alt="image" src="https://github.com/user-attachments/assets/b9b1ee13-f3a5-4e41-a56c-0be5432727d3" /> fig. 1 - Novo Lobster. <img width="416" height="288" alt="cargo_novolobster-0" src="https://github.com/user-attachments/assets/3b3a96c4-c970-4978-b8e7-a31b439fba75" /> fig. 2 - Bespoke cargo shuttle with no directional fans under the docking doors. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Caws, Conf, Way, SevenShades - add: Novo Lobster, a full rework of Lobster Station. Better bundle up, 'cuz it's reeeal cold. Available for playtesting, but not yet in the regular map rotation.
## Short description <!-- What do you propose to change with your PR? --> Doing another small chore pass with some few services changes. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> #5250 #5458 #5463 ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="783" height="513" alt="image" src="https://github.com/user-attachments/assets/be144fb1-66d1-4953-941d-6332e74253b9" /> <img width="348" height="431" alt="image" src="https://github.com/user-attachments/assets/a5a6076b-cd88-46a2-a220-78f0843c9167" /> <img width="595" height="575" alt="image" src="https://github.com/user-attachments/assets/52dc1d29-2c17-4a92-b77f-b84f1d507b15" /> <img width="740" height="469" alt="image" src="https://github.com/user-attachments/assets/7b795244-bd80-4412-b5ae-ef815405da15" /> <img width="1036" height="657" alt="image" src="https://github.com/user-attachments/assets/4e498804-344c-421b-aaaa-a9979ed75f54" /> <img width="643" height="511" alt="image" src="https://github.com/user-attachments/assets/b969d069-40c6-4893-a542-8c4e29e39e3c" /> <img width="645" height="458" alt="image" src="https://github.com/user-attachments/assets/7b3176f1-baaf-480e-9360-76de3c98ca85" /> <img width="1001" height="643" alt="image" src="https://github.com/user-attachments/assets/aeec8c42-e13a-4a99-89c9-3e12e445ae65" /> <img width="751" height="750" alt="image" src="https://github.com/user-attachments/assets/89bcdeea-7eee-477d-bd73-a65b5874ff01" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Cvlancer - add: (LAGAN) Added stir stir to gen pop. - add: (LAGAN) Added ice cream maker to kitchen. - add: (LAGAN) Added Vend of silence mimes room. - add: (LAGAN) Added ticket machine to cargo. - add: (LAGAN) Added another fuel dispenser to robotics. - add: (LAGAN) Added a coffee dispenser and sink to the side bar. - add: (LAGAN) Added that uhh penguin pet to court house. - add: (LAGAN) Added a second window to the hop line for someone to help. - remove: (LAGAN) Removed a random railing in solitary. - remove: (LAGAN) Removed the linking from hop window and warden windows. - tweak: (LAGAN) Changed genpop's turnstiles glass firelocks with the wall variant. - tweak: (LAGAN) Changed moved kitchen around a bit.
## Short description <!-- What do you propose to change with your PR? --> Redo of #5069 With fixes and better commenting. > Adds an experimental fix for the alcohol lag that has been reported numerous times, disabled by default enabled by setting opt.drunk_render_fix to true. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> > This will hopefully fix #5038, [this thread](https://discord.com/channels/1272545509562777621/1509365322757439554), [this thread](https://discord.com/channels/1272545509562777621/1523743383594467390), [this thread](https://discord.com/channels/1272545509562777621/1515343691995152474), and [this thread](https://discord.com/channels/1272545509562777621/1519592978597806162). ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> The drunk effect looks the exact same, and nobody can replicate the lag in dev. ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [ ] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: CrazyPhantom - fix: Experimental fix for alcohol lag can be enabled with the command ``cvar opt.drunk_render_fix true``.
## Short description Revamps the starboard TEG room, adds a mid sized supermatter setup, and gives engi a bluespace harvester next to secure storage to give them a _reason_ to run multiple engines. ## Why we need to add this Starboard TEG is horribly outdated to current un-written standards of TEGs being runnable with minimal setup but plenty of room for upgrade by seasoned engineers. They wouldnt let me add a supermatter to mall so woe, starboardmatter be upon ye. Bluespace harvesters have thus far not broken the balance, and their highest safe mode (6, 1 MW consumed) gives engi an actual reason to setup two or more engines in order to fuel it ## Media (Video/Screenshots) <img width="503" height="784" alt="image" src="https://github.com/user-attachments/assets/9c5e3ae7-dfd1-433f-b593-e0964771bf11" /> <img width="388" height="598" alt="image" src="https://github.com/user-attachments/assets/2353bcb3-a034-4a22-81a3-7c9f9ebdd4e6" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Orange Juice Goose - add: Bluespace harvester for starboard. - add: Supermatter for starboard. Starboardmatter. - tweak: Reworked starboard TEG. --------- Co-authored-by: Red Mushie <82113471+redmushie@users.noreply.github.com>
## Short description <!-- What do you propose to change with your PR? --> Adds `AirlockMaintJournalismLocked`, a maints door version of `AirlockJournalismLocked` ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> **Required for mapping!** This is a blocker for Radio Host getting mapped (and for Reporters getting their doors swapped to Journalism access, too!). ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="621" height="468" alt="image" src="https://github.com/user-attachments/assets/57a7d91f-4c14-4d42-a525-ae47e873572e" /> <img width="478" height="185" alt="image" src="https://github.com/user-attachments/assets/579e2f8d-7c65-4467-9c1d-7c701f6e4228" /> fig. 1 - Maints door. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions.
## Short description Allows Scurret, Kobold, Monkey to wear glasses ## Why we need to add this If a moth/moproach can wear them why would the others not be able to? ## Media (Video/Screenshots) N/A ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: RedSpeeds - add: Added glasses slots to Monkey, Kobold, Scurret.
## Short description <!-- What do you propose to change with your PR? --> Reverts mapping changes made in #5186 that weren't mapping approved. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> 1. The mapping changes were not approved. 2. The PR modified `.yml` files of upstream shuttles, which isn't proper - new copies of those shuttles should have been made and put in a `_Starlight` subfolder. 3. Using remote consoles on a shuttle makes them annoying for mapping to test - you can't `loadgrid` them and fly them around immediately, you have to stop and replace the remote console with a regular console to test pilot them (unless you boot up in Release mode on local, then `setgamemap` to the map that uses it, etc.) 4. The security shuttles are entirely broken by #5186 as the PR put the "remote security shuttle console" at the helm of these shuttles, but we don't have a universal roundstart security shuttle with the correct grid component, so the computer has no idea what to remote control and just gives you a blank interface. 5. The computer mapped to the helms is the _remote_ shuttle console. It's meant to remotely control shuttles, not be on the shuttle in question. I don't oppose the concept of #5186 (adding access requirements to shuttle computers), but the implementation is not proper and new prototypes should have been made instead of using the remote consoles on the shuttles themselves. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Caws - fix: The security shuttles no longer give you a blank 'no shuttle found' pilot interface when attempting to pilot them.
## Short description Resprites the Small Light, Light Tube, Emergency Light, and Strobe Light. New sprites are a little cleaner, less pre-color tinted so coloring shows up better, and have more built in fake bloom in their on states. ## Why we need to add this Respriting progress. Looks nice. ## Media (Video/Screenshots) <img width="297" height="252" alt="image" src="https://github.com/user-attachments/assets/d4103bbc-dc44-4598-b418-7996d7a53b6a" /> <img width="283" height="230" alt="image" src="https://github.com/user-attachments/assets/6d16266b-b375-4006-bcf9-327d2c447298" /> <img width="279" height="223" alt="image" src="https://github.com/user-attachments/assets/6958833b-f6b0-41cc-a6f3-88a1bd5fd889" /> <img width="282" height="222" alt="image" src="https://github.com/user-attachments/assets/2bf86f88-7b8a-4e1f-8fd3-acf9b6b1ecf5" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Conflee - tweak: Resprited the Small Light, Light Tube, Emergency Light, and Strobe Light. They're all slightly cleaner, less pre-tinted so coloring stands out more, and have fake bloom added to their on states.
## Short description Fixes player controlled cuffed zombies being unable to attack. ## Why we need to add this This is a bit of a cheese strategy that prevents players that are being zombified from being able to attack. Note that AI controlled zombies could still attack. Cause of this is a desync on the `CuffableComponent.CanStillInteract` value. This would be false on the client, but true on the server. https://github.com/ss14Starlight/space-station-14/blob/ee07ab504a21316e2bc3c8ece90b8277c675c37b/Content.Shared/Cuffs/Components/CuffableComponent.cs#L33-L37 This seems to be rooted in how `SharedCuffableSystem.UpdateCuffState` handles updates on entities with no hands: it always defaults to `false`. ## Media (Video/Screenshots) https://github.com/user-attachments/assets/24783f06-d0a2-4e6a-aad3-30c6b9536668 Video of a cuffed Resomi turning (cuffs fall on the ground) and then tearing down its cage. ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Xale - fix: Cuffing no longer prevents player controlled zombies from attacking.
## Short description <!-- What do you propose to change with your PR? --> Fix a potential memory leak concern. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> After scents were released, there were concerns that a memory leak may have been introduced with the drunkenness overlay. I haven't really seen where the issue may be, but I was able to locate a potential issue with the scent overlay's behavior. So now we drop it from the overlay manager when someone disconnects. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions.
## Short description Resprites Grass, Light Grass, Dark Grass, and Jungle Grass to be usable to create gradients to blend patches of grass and make grassy areas look less flat. Ported from Crystal Punk Resprites and adds a fuck ton of new trees, including birch, non-snowy conifer trees, red vampiric 'gulthias' trees, etc. Ported from Crystal Punk crystallpunk-14/crystall-punk-14#1539 crystallpunk-14/crystall-punk-14#1672 crystallpunk-14/crystall-punk-14#1154 crystallpunk-14/crystall-punk-14#1172 Also added Water Reeds floral decals from Crystal Punk ## Why we need to add this Better grass and trees makes natural areas look way nicer. Mappers can use a clever mix of mowed and unmowed astro-grasses to control how the edges blend over each other depending on what they want. Takes a little tinkering but the effect is very pretty. ## Media (Video/Screenshots) <img width="773" height="768" alt="image" src="https://github.com/user-attachments/assets/b6e6cd12-766a-4f1e-972a-ada5c4990b75" /> <img width="1107" height="593" alt="image" src="https://github.com/user-attachments/assets/02e1e7a9-34e7-4737-860a-fd8d754748f5" /> <img width="1104" height="594" alt="image" src="https://github.com/user-attachments/assets/05745742-d5a6-434b-a2f2-fe37a8a3f828" /> <img width="1107" height="598" alt="image" src="https://github.com/user-attachments/assets/9aa052ca-ab8d-4694-a1f1-9dcf4b37cf77" /> <img width="1109" height="599" alt="image" src="https://github.com/user-attachments/assets/f401bdf9-8450-41de-aee1-c8683f445744" /> <img width="1111" height="598" alt="image" src="https://github.com/user-attachments/assets/7ef68364-ac1c-4e64-92d7-960c5a309980" /> <img width="1109" height="600" alt="image" src="https://github.com/user-attachments/assets/8df01b2c-226e-4e8c-bf94-34532035e185" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Conflee - add: Added Gulthias, Birch, Snowy Oak, and non-snowy Conifer trees from Crystal Punk. - add: Added water reeds floral decals, from Crystal Punk. - tweak: Resprited Grass, Light Grass, Dark Grass, and Jungle Grass using sprites from Crystal Punk. - tweak: Resprited basic trees and Snowy Conifer Trees using sprites from Crystal Punk.
## Short description I accidentally logged antags' entities rather than their actual antag id. I don't actually know *how* to test the Prometheus stuff though, so uh, if someone could verify this looks correct, it'd help me... ## Why we need to add this Logging's useful. ## Checks - [ ] I do not require assistance to complete the PR. - [ ] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. Nothing player facing here.
## Short description Ports some Wizden PRs that deal with conditional spawners, namely: - Wizden [#43234](space-wizards/space-station-14#43234) - Wizden [#43589](space-wizards/space-station-14#43589) - Wizden [#44912](space-wizards/space-station-14#44912) I went around/skipped Wizden [#39096](space-wizards/space-station-14#39096), since it has a lot more entity-related stuff that I don't think we have + it would take another series of PRs, and for our purposes right now, we only need these 3 PRs. ## Why we need to add this We have random spawners that mappers can't use because they don't hold rotation; now they do. + requested by Caws ## Media (Video/Screenshots) <img width="988" height="771" alt="image" src="https://github.com/user-attachments/assets/5a63869c-39f4-4070-b262-8df07582f540" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: SnappingOpossum, Princess-Cheeseballs, MilenVolf - fix: Certain randomized items and decorations no longer spawn with the wrong rotation. - fix: Handheld artifacts will no longer create entities glued to players. --------- Co-authored-by: SnappingOpossum <snappingopossum@outlook.com> Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com> Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com> Co-authored-by: Fildrance <fildrance@gmail.com>
…h it (#5426) ## Short description <!-- What do you propose to change with your PR? --> Let me tell you a story, of how I spent 30 minutes trying to figure out why Afterlight test startup was abominably slow, only to realize Starlight hasn't updated the engine in a long time, and then spending a few hours updating the engine here instead This updates (your custom fork of) the engine and Content to compile with it Includes changes to IMapManager being deleted in engine (thank god) and the engine update in this same PR Also fixes [Content.Shared/Polymorph/PolymorphActions.cs](https://github.com/ss14Starlight/space-station-14/compare/starlight-dev...DrSmugleaf:refactor/serv5?expand=1#diff-54ab3bf4029189d16be30ecb8ab45bffbb03ad981e52aa0c6354f95fa8b9f135) to not resolve a prototype in a data field's setter because that is insane, if you could make sure that is caught in review because that will not work properly with serialization, the closest you can get to it is a ISerializationHooks.AfterDeserialization implementation but even then you should just resolve it in the system Related but not needed (hopefully) - space-wizards/RobustToolbox#6875 - space-wizards/RobustToolbox#6876 - space-wizards/RobustToolbox#6877 ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> Gets ingame 👍 <img width="1282" height="752" alt="image" src="https://github.com/user-attachments/assets/3316d6a7-84cd-4a39-8f3d-10f1b80f68c3" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. --------- Co-authored-by: Starlight <ss14-Starlight@outlook.com>
## Short description <!-- What do you propose to change with your PR? --> In the spirit of #2525, I have gone through and removed a bunch of upstream shuttles that are completely unused. Some of these are for GameRules that have long since been removed, some of these were shuttles related to upstream maps that were removed. All the same, they're loitering in the files and doing nothing but increasing our filesize by a small but non-zero amount and that sucks. This PR also organizes the shuttle folder by adding the following folders: - Admeme - Cargo - Evac - Nukeops - Shipyard No longer any of us have to go "what the hell is `pts.yml`" for now you can just look at it and go "it must be some Shipyard thing because it's in the shipyard folder. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> I got mad I couldn't find something. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [ ] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Caws - tweak: Organized the shuttle files for both mapper and admin convenience. - fix: Xenoborgs now use the custom Starlight Mothership once again. - remove: Removed a bunch of old/unused shuttle files.
## Short description prevent CI failure on things that are not critical This also changes the PR comment to use folded fail messages, to make PR's with failed reports less large. ## Why we need to add this CI Failing on things like C# diags. Sorry :( ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions.
…5604) ## Short description In the Cosmic Cult guidebook sections, change "Bible" text to "Holy Book" instead ## Why we need to add this The bible is just one of many selectable Holy Book types in the Chaplain's loadout. The guidebook shouldn't presume every Chaplain is playing a Christian. I tested that the guidebook entries display as I expected with these changes. **I also tested every loadout-selectable holy book** to ensure that they all produce holy water when used on water. ## Media (Video/Screenshots) <img width="694" height="602" alt="Screenshot_20260810_145302" src="https://github.com/user-attachments/assets/79b50a4c-5585-40a1-ab41-ecf7c2c6efa1" /> <img width="694" height="602" alt="Screenshot_20260810_145316" src="https://github.com/user-attachments/assets/5689eaa1-fa96-41a4-931b-194bac7fb49e" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: noxypaws - tweak: use "Holy Book" instead of "Bible" in Cosmic Cult guidebook entries.
## Short description <!-- What do you propose to change with your PR? --> Fixes welding fuel from tanks getting in things with reagent filters ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Fixes: #5599 ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [ ] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: CrazyPhantom - fix: Fixed welding fuel getting in censers. --------- Co-authored-by: Rinary <rinary.super@gmail.com>
## Short description Add a new detective pistol, the cold case, based of a Mauser C96 as well as the option for det to choose their lethal sidearm. When the detective choose their sidearm they will spawn with a holster with the corresponding weapon. Balance wise the cold case has the due process firerate, 15 shots of .40 and only reload like a mosin: you need to feed the ammo directly into it and it will load one by one. This PR also deletes two unused guns, the sawn off variant of the riot shotgun that, since its rework, is uncraftable/unfindable/unpurchasable. This PR goes toward Rinary wish to clean our long list of guns for things that will be used in game. ## Why we need to add this - Deletes two unused guns going toward our objective to clean those up. - Since the recent Inspector nerf the detective has only a worst dispatcher as his ballistic. The cold case is thematicly fitting gun for him: old, gimmicky to reload and unwieldy. - I cant own a c96 in real life so i can have one in the space game ## Media (Video/Screenshots) <img width="192" height="159" alt="Capture2" src="https://github.com/user-attachments/assets/1a53158f-17c6-4a39-83e2-f25dda963fdf" /> <img width="785" height="166" alt="Capture3" src="https://github.com/user-attachments/assets/07b5781c-044f-4fe1-a5f2-369ccad65bfc" /> <img width="180" height="103" alt="Capture1" src="https://github.com/user-attachments/assets/775bb7d4-2088-469b-9e6d-c2040dc28cb6" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Romero/Littlemen - add: the cold case; a mauser C96 inspired pistol. - add: det has now loadout options for his lethal sidearm.
<img width="1920" height="1080" alt="image" src="https://github.com/user-attachments/assets/d87f7b9b-51ca-4536-a0ab-a47ca4272c1f" /> _"Even if it's foolish, even if it's reckless, I'll carve out my destiny. Go full throttle, blast it away!"_ ## Short description A much needed update to Wizard Duel, with an actual achievable objective, rules to prevent Wizard Duelists from engaging in bad practice, and stricter conditions for their duels. ### Medallions <img width="526" height="483" alt="image" src="https://github.com/user-attachments/assets/9549f7cf-77b5-4614-b02c-733d1e3d36a4" /> <img width="528" height="197" alt="image" src="https://github.com/user-attachments/assets/01bc8a0c-6229-4f78-a48d-5ed1d6492dfe" /> All Wizard Duelists now come equipped with a medallion, corresponding to their specific school. This is the "objective" of the gamemode now; obtain at least 3 of these to be the winner, and, if there's 6 duelists, be the *only* duelist to have at least 3 of these. No more ambiguous hand-wavey duels; there needs to be a defined way to keep score, or the duelists will often do literally anything else. Now, they have something hard-defined as their win condition. ### New Rules <img width="534" height="1004" alt="image" src="https://github.com/user-attachments/assets/7177d774-7b9d-49b0-ac13-e843b6575398" /> Wizard Duelists have new rules, to prevent a lot of LRP activity we saw with them over the past few months. Namely: - All duels must include magic. - Duelists **must** keep their respective colors on; no changing round start. You were sent here by a specific school to represent them, after all. The only exception to this rule is the void robes and space suits - You must **always** wear your medallion as identification. - The 3 medallion win condition as stated above. - Outsiders who steal medallions are to be dealt with harshly. Essentially, if a crew member arrests or kills another wizard, you must do your job as **an Antagonist**, and retrieve the confiscated medallion. - The victory must survive. Survive condition, simple enough. Don't die. ## Why we need to add this A big flaw of the gamemode (both Wizards and Wizard Duelists) is that they're effectively free agents, with nothing really holding them to their goals. This PR stands to address this. ## Media (Video/Screenshots) <img width="291" height="200" alt="image" src="https://github.com/user-attachments/assets/e1cea7d4-9ee6-44c8-8f2a-f4f163a43eba" /> <img width="183" height="270" alt="image" src="https://github.com/user-attachments/assets/7de38c15-8e7a-4907-bc8c-4b475d779217" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: wonderfulnewworld - add: Added 6 Wizard Duelist medallions, corresponding to each respective school. - tweak: Wizard Duelists now have many more rules to follow with regard to their duels; all duels must involve magic, they cannot change their clothing, they must always wear their medallions, victors are only decided when only one duelist has at least 3 or more medallions, outsiders who steal medallions must be dealt with harshly, and the victor must return alive to tell the tale. - tweak: (Wizard's Court) Added a beacon, so wizards can actually teleport back. - fix: Fixed some inconsistencies in the way Space Wizards Federation is written.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
S: Needs Review
Merged
walksanatora
added a commit
that referenced
this pull request
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Why we need to add this
Media (Video/Screenshots)
Checks
Changelog