ITs live time - #5844
Merged
Merged
Conversation
…#44454) * Added EntitySystemSubscriptionsGenerator project to content solution. * Added imports to Content.Client/Server/Shared projects.
## Short description Vent crawling would throw a million exceptions if an entity was delete inside of it, or if the previous pipe was deleted. fixed 👍 ## Why we need to add this <img width="1207" height="450" alt="brave_xHbo4xu9n4" src="https://github.com/user-attachments/assets/2fe6c0f5-cd47-4f04-936c-e6b4b49e5f9c" /> ## Media (Video/Screenshots) the bug: https://github.com/user-attachments/assets/d7bc7ab2-8779-45bd-b54b-c8ec48da7c86 ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Mack - fix: Vent crawling entity deleted bug.
…Server (#5673) ## Short description <!-- What do you propose to change with your PR? --> Needs space-wizards/RobustToolbox#7008 and space-wizards/RobustToolbox#7006 to work properly before you start refactoring content code to use it, or pull upstream code that uses it But this fixes a different problem that also made it not work ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. --------- Co-authored-by: Ataman <Ataman@users.noreply.github.com> Co-authored-by: Starlight <ss14-Starlight@outlook.com>
## Short description <!-- What do you propose to change with your PR? --> Re-organizes the guidebook to make it easier to navigate in the day-to-day, hiding guides intended mostly for new players in their own category and making corporate law it's own category for easier access and navigation. I've also finally moved Corporate Law to an actual Corporate Law xml file and re-named it everywhere it was still referred to as Space Law. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> We don't really _need_ this, but I personally find it very annoying how difficult it is to navigate to Corporate Law right now. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="902" height="696" alt="billede" src="https://github.com/user-attachments/assets/e0e70ae4-93c1-4d48-937e-2189c6fc4904" /> <img width="902" height="699" alt="billede" src="https://github.com/user-attachments/assets/b42b0a4b-01ac-41b5-a46c-4728e030a337" /> <img width="892" height="705" alt="billede" src="https://github.com/user-attachments/assets/6bab8f48-5e6d-470e-b188-539a3168b087" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Trosling - tweak: Reorganized the guides into their own category in the guidebook for less clutter. - tweak: Moved corporate law to it's own guidebook category, instead of hiding it away in the security guide. - fix: Removed last mentions of "Space Law" in the guidebook, replacing them with "Corporate Law". --------- Co-authored-by: Rinary <rinary.super@gmail.com> Co-authored-by: RHSvenson <rsvens21@student.aau.dk>
Credit to @Spaghetti-bit but he asked me to finish it. ## Short description <!-- What do you propose to change with your PR? --> Adds a new uplink reinforcement, the syndicate mobroach. It comes with a self filling spray cleaner bottle Infinite cable cuffs (they break in 3 seconds) 1 damage piercing bite No slip Higher health thresholds (0, 50, 100) Sells for alot (1000) Has regal rat (ratking) typing indicator Speaks like a mobster Has syndicate comms Has 3 small mothperson jumps Discount down to 1 TC Usually 4 TC by default ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> N'yeaaaah... see? Mothroaches / Moproaches. It's worse than a kobold, syndi-cat, and monkey reinforcement. https://discord.com/channels/1272545509562777621/1524458927566094386 made based off of this suggestion. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="480" height="211" alt="image" src="https://github.com/user-attachments/assets/2a2286e2-b352-4dee-945e-7f2feb0a01b5" /> <img width="608" height="624" alt="image" src="https://github.com/user-attachments/assets/412e1ce0-8680-4a14-a292-f6223b1d49d4" /> <img width="414" height="120" alt="image" src="https://github.com/user-attachments/assets/913cfb0d-3e7e-4277-a92f-49e19c6b5d5b" /> <img width="577" height="575" alt="image" src="https://github.com/user-attachments/assets/5c32c493-951d-4ac8-a3f7-ff5b0ec083c4" /> <img width="574" height="572" alt="image" src="https://github.com/user-attachments/assets/22e91e6b-75e0-4b86-9a6f-65594f32918e" /> <img width="367" height="87" alt="image" src="https://github.com/user-attachments/assets/992dcdbc-b3b5-4f4a-af74-f9d552a06a99" /> <img width="479" height="190" alt="image" src="https://github.com/user-attachments/assets/3cb280c9-a7b5-4028-b332-bb494d128d36" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Spaghetti-Bit & ya3.14a - add: The mothroach underground has made some under the table deals with the syndicate and are now available to hire, introducing the Syndicate Mobroach. A special little helper specialized in removing evidence and interrogation. Comes with a bar of soap, cuffs, refilling space cleaner bottle. Costs 4 TC. --------- Co-authored-by: Spaghetti-bit <yumyumkillkill@gmail.com> Co-authored-by: mack.wtf <mackamuir@gmail.com>
## Short description <!-- What do you propose to change with your PR? --> Adds `ticker:toggletimeronend` which can enable/disable the automatic restart timer when round ends. This resets to true once the round restarts and everyone returns to lobby. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Admeme/events ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions.
## Short description Ports funky-station/forky-station#68 and funky-station/forky-station#335 from Forky (MIT) Adds many Large Cardboard Boxes. Constructible by crew using cardboard, different designs can be added with the Spray Painter. Some Cargo Orders have been swapped to Cardboard Boxes instead of Crates for ease of delivery/transport (Lizard/Shark plushies, and boxing supplies mainly) Also added a Box Shelf, which can store 4 boxes on it, for compact storage in departments. Comes with many pre-filled boxes for mappers to map to reduce item spam and fill box shelves in relevant departments with their supplies. Box based deliveries can fit in Box Shelves, and Large Cardboard Boxes can fit in the Mail Trolley, for logical consistency. ## Why we need to add this More mapping resources and better ways to store items in bulk within departments rather than just leaving them piled everywhere. ## Media (Video/Screenshots) <img width="903" height="710" alt="image" src="https://github.com/user-attachments/assets/9f59e0a0-e6a4-496d-98f6-4780bafc8a23" /> <img width="398" height="408" alt="image" src="https://github.com/user-attachments/assets/1c10e69c-9e5a-46a5-81e2-e7965f68a508" /> <img width="376" height="375" alt="image" src="https://github.com/user-attachments/assets/33addd04-38a9-4de8-9610-eab8bd40c16f" /> <img width="360" height="368" alt="image" src="https://github.com/user-attachments/assets/7359a52b-1b44-4b9e-8c5c-ba1bd397365a" /> <img width="358" height="390" alt="image" src="https://github.com/user-attachments/assets/119e5a1e-e46a-4263-9f34-3092cab996f8" /> <img width="353" height="361" alt="image" src="https://github.com/user-attachments/assets/b7cc1c0a-3c6c-4225-869c-568973047089" /> <img width="351" height="407" alt="image" src="https://github.com/user-attachments/assets/affd467c-f62a-4c9a-8d10-768ad71cac9e" /> <img width="345" height="386" alt="image" src="https://github.com/user-attachments/assets/bfb507e3-7376-43fd-abb1-a62d7f9002ad" /> <img width="355" height="379" alt="image" src="https://github.com/user-attachments/assets/d7cc7dc6-3ab9-408f-bfa4-e053afb6e219" /> <img width="345" height="375" alt="image" src="https://github.com/user-attachments/assets/f0ce7aee-d497-4f15-9977-82d2f729c01b" /> <img width="364" height="371" alt="image" src="https://github.com/user-attachments/assets/7e1ceab9-12f8-4647-b4e3-55e24e402962" /> <img width="332" height="366" alt="image" src="https://github.com/user-attachments/assets/e08fc659-af98-49f2-a927-0788885b6bf4" /> <img width="333" height="382" alt="image" src="https://github.com/user-attachments/assets/83b62f7d-b2d0-4a93-a53e-34934717eb2c" /> <img width="332" height="385" alt="image" src="https://github.com/user-attachments/assets/45c6a2de-60b3-4359-9293-bab8e6d3ff53" /> <img width="338" height="377" alt="image" src="https://github.com/user-attachments/assets/90407d5d-4c0e-49df-b3ca-0a4180ce3dae" /> <img width="330" height="365" alt="image" src="https://github.com/user-attachments/assets/c9a4bfcf-4f2d-467e-bd98-3710bdddeb95" /> <img width="341" height="372" alt="image" src="https://github.com/user-attachments/assets/4fb78cef-7899-45ff-babd-214b337ed6f7" /> <img width="325" height="369" alt="image" src="https://github.com/user-attachments/assets/75248d7e-8a90-4b86-a6b0-9f88904abedf" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Conflee, mkanke - add: Added craftable and paintable Cardboard Boxes. - add: Added constructible Box Shelves for storing boxes of items in a more compact and organized way. Can hold Large Cardboard Boxes and box-based Mail Deliveries. - add: Added a dozen ish pre-filled boxes for mappers to use instead of spamming item stacks down in places. - tweak: Changed the Mail Trolley to accept Large Cardboard Boxes, for logical consistency. --------- Co-authored-by: mkanke-real <mikekanke@gmail.com>
## Short description Resprites the Maints Forge sets of swords to match existing sword textures better (IE Claymore, Cutlass, Sabre). ## Why we need to add this Consistent style. Old swords were very scuffed, even the nice high end ones had sloppy spriting. New sprites match the style of the existing vanilla swords (Claymore, Cutlass, and Sabre) as well as the two other custom swords we've added in the past (Prototype Vibroblade and CentComm Vibroblade). ## Media (Video/Screenshots) <img width="945" height="657" alt="image" src="https://github.com/user-attachments/assets/0d88c59f-3483-472c-a256-0bb1c80edcc4" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Conflee - tweak: Resprited the Makeshift Sword, Improvised Sword, Forged Sword + Parts, Dawnbreaker, and Tidebreaker + Parts. New sprites now match existing vanilla sprites (Claymore, Sabre, Cutlass) as well as other Starlight unique swords (Prototype Vibroblade and CentComm Vibroblade).
## Short description <!-- What do you propose to change with your PR? --> Rename ```ItemSwitchState.Hiden``` to ```ItemSwitchState.Hidden``` to fix typo introduced in abductor vest work (4637ae8). The YAML key changes from ```hiden``` to ```hidden```. Any downstream fork prototype using hiden: will need updating. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Fix typo. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [ ] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: OMEGA - fix: Typo in ItemSwitch.
## Short description <!-- What do you propose to change with your PR? --> Makes the news manager console use Journalism access instead of Service access. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Reporters have their own access now, but the news console didn't get updated when Journalism access got added. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="604" height="287" alt="image" src="https://github.com/user-attachments/assets/9d79458f-f6af-494f-b09a-a7d2a7d0d960" /> fig. 1 - Updated access. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Caws - tweak: The news manager console now requires Journalism access (instead of Service access).
Adds froggy chair yay yippee ## Short description <!-- What do you propose to change with your PR? --> Adds the beloved froggy chair to the game + a pink variant ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Everybody love froggy chair. Everybody deserves froggy chair. Let the people have the froggy chair! ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> https://github.com/user-attachments/assets/d5d083c9-d9ba-47e5-b738-7e8cfdf337a2 ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: BriocheBear - add: Added froggy chair as a constructible furniture. - add: Added lovey chair, a pink variant of the froggy chair.
## Short description Adds artist names to the music vinyls descriptions. Some songs I could not track down the credits for, and are defaulted to being credited by Goonstation. <!-- What do you propose to change with your PR? --> ## Why we need to add this It's neat to have, also a way to say "this is song by so and so" or something <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Way - add: Artist names are now in the descriptions of music vinyls. <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> --------- Co-authored-by: Rinary <rinary.super@gmail.com>
## Short description Radio Host and Department lathes mapped <!-- What do you propose to change with your PR? --> ## Why we need to add this Upkeep <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> ## Media (Video/Screenshots) <img width="4448" height="4224" alt="Elkridge-0" src="https://github.com/user-attachments/assets/5115c92f-a64a-43d3-bcfe-96514e0c41f9" /> <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Way - add: Radio Host and Departmental Lathes are now mapped. <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. -->
## Short description Adds Cell Bars, a new 'fence' type structure. - Cell Bars come with straight, end, corner, broken, and gate pieces. - They have 300 health, and drop 1-2 Plasteel when broken. - They can be constructed with 4 Plasteel, and deconstructed by welding and then a prying very slowly, returning the 4 plasteel. - They can NOT be electrified or climbed. - Gates do not have any access types, you will need to create solid wall flanked airlocks to actually lock people in. ## Why we need to add this A new functional and decorative option for mappers. A structure that is functionally a fence, but can't be cut in 2 seconds with wirecutters, bypassed with insulated gloves, or be used to kill people by shoving them into it. Which all together makes it safe for use in Genpop / Prison settings. ## Media (Video/Screenshots) <img width="734" height="757" alt="image" src="https://github.com/user-attachments/assets/65f40cdb-f801-47bb-ab74-b677db1b38df" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Conflee, Way - add: Added Cell Bars. Come in all normal fence variants. Can not be climbed or electrified. Very durable 'fence' option made of Plasteel for mapping in Genpop and Prison areas to prevent escapes.
## Short description <!-- What do you propose to change with your PR? --> Removes the law communications console. A `migration.yml` entry has been added which will replace this console with a camera monitor instead. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Part of a larger suggestions post: https://discord.com/channels/1272545509562777621/1539763924541509712 In short: - Players are getting a lot of announcement fatigue. There's a lot of comms consoles and a lot of them repeat the same things (most often about coordinates). - This is easily the least important comms console current in the game. Neither the Magistrate nor the IAA really have a need to make station-wide announcements. - Unlike other consoles, three people have access to this console (a Magistrate and two IAAs due to them having Command access). Removing this console won't entirely remedy the announcement fatigue, but it's a start. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="939" height="668" alt="image" src="https://github.com/user-attachments/assets/6f6471da-1fbc-4d17-b309-9b3a33a293c1" /> fig. 1 - Example of the `migration.yml` in action. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Caws - remove: The law communications console has been removed.
## Short description <!-- What do you propose to change with your PR? --> Removes `Command` access from IAAs. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> This is paired with #5743 - IAAs on Live have Command access, which allows them to: - make announcements in the Bridge - set Alert levels IAAs are **not** members of Commands (and do not even have `Debrief` access!) and should not have access to either of these. Their mapping guidelines have always strictly prohibited mapping any IAA offices behind Command access. IAAs don't need this access. It should be removed and it should not be added again. They have their own dedicated office spaces on maps where they can operate out of for paperwork, holocalls, and shelter in during emergencies. Failing that, they still have `Brig` access to shelter in Security. There's no need for them to get access to Command areas. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="411" height="148" alt="image" src="https://github.com/user-attachments/assets/f0d826a7-52bb-4227-8724-f9accc0f4df2" /> fig. 1 - Access list. <img width="446" height="379" alt="image" src="https://github.com/user-attachments/assets/841ac1fc-58c2-477d-95d5-bb4c93781812" /> fig. 2 - No longer able to set alert levels. <img width="659" height="374" alt="image" src="https://github.com/user-attachments/assets/57620894-cae6-453e-be3b-20548b780025" /> fig. 3 - No longer able to make announcements. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Caws - remove: Internal Affairs Agents no longer have Command access.
## Short description Adds a admin entity log for when someone enters ssd ## Why we need to add this I remember when I first started playing I ahelped about being robbed when SSD and the admin said the logging was bad to it was hard to tell. On another note holy fuck do the admin entity logs SUCK to read. ## Media (Video/Screenshots) <img width="1100" height="763" alt="image" src="https://github.com/user-attachments/assets/2e64b850-23ac-45d3-b58a-18a86c0e8f95" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions.
## Short description Adds refinery as a map admins can force but does not add it to auto-rotation. Adds refinery to stationpowertests ## Why we need to add this Been a while since we had a totally original map. ## Media (Video/Screenshots) <img width="3000" height="3149" alt="Refineryscrunched" src="https://github.com/user-attachments/assets/28b31090-88e4-42c1-abcd-30ffbc525b4e" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: OJG - add: Adds Refinery station to the game files for testing!
* first pass, something's afoot * BUI cleanup, fix metadata cast * SetupBoundUI: use CreateWindow, not new * fix dependency order * more dependency order fixes # Conflicts: # Content.Client/SurveillanceCamera/UI/SurveillanceCameraMonitorBoundUi.cs # Content.Client/SurveillanceCamera/UI/SurveillanceCameraNavMapControl.cs # Content.Server/SurveillanceCamera/Components/SurveillanceCameraMonitorComponent.cs # Content.Server/SurveillanceCamera/Systems/SurveillanceCameraSystem.cs
## Short description ports this wizden pr space-wizards/space-station-14#45401 ## Why we need to add this camera's don't work ## Media (Video/Screenshots) <img width="1256" height="677" alt="image" src="https://github.com/user-attachments/assets/b5d0cfb7-89ee-441c-8f5b-a95d469d7a9a" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: whatston3 - fix: Cameras work now. Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>
## Short description K9 can no longer roll antag. ## Why we need to add this Dog don't got hands but IS a job. ## Media (Video/Screenshots) <img width="231" height="258" alt="image" src="https://github.com/user-attachments/assets/4a58f495-0bbd-4beb-836d-08e38699f586" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: wonderfulnewworld - tweak: Moved K9 in security's display. - fix: K9 can no longer roll antag.
…tag again (#5840) ## Short description Kiki, Pun Pun, Stir Stir, and other antag rolling animals can roll antag again ## Why we need to add this Inheritance error bug ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: wonderfulnewworld - fix: Kiki, Pun Pun, Stir Stir, and other antag rolling animals can roll antag again.
## Short description <!-- What do you propose to change with your PR? --> Fixes a bug discovered on Delta related to predicted movement states and latching. K9s were latching onto targets, but sometimes in strange distance calculation scenarios, the latch would silently fail and fall-through the latch target onto their previous, teleporting them across time and space to bite onto their previous target. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Bugfix and defensive coding is good. Added a safeguard max distance calculation to latching, and invalidated args on a couple of upstream spots where an action fails. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Sparlight - fix: Fixed K9s teleporting across the station to their previous latch target. <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. -->
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
size/M
Branch: Starlight
S: Untriaged
Contributor
|
I believe something in this has caused a epilepsy producing bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Why we need to add this
Media (Video/Screenshots)
Checks
Changelog