Refinery3

[OrangeJuiceGoose]

Short description

Further refinements to thematics, adds refinery to rotation.

Why we need to add this

Previous version was for fixing critical issues. This one can add the station to rotation with issues resolved.

Media (Video/Screenshots)

Checks

• I do not require assistance to complete the PR.
• Before posting/requesting review of a PR, I have verified that the changes work.
• I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
• I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 OJG

• add: Adds Refinery Starport to rotation. God help us all.
• tweak: (Refinery) Lots and lots of decal work that is difficult to keep track of.
• tweak: (Refinery) Lots of extinguisher cabinets and wallmount closets.
• tweak: (Refinery) Changed the zookeeper office to a more generic setup any service worker can take over due to the roles removal.
• tweak: (Refinery) Added and changed a bunch of decor.
• tweak: (Refinery) gave sec a better access to maints through their substation.
• tweak: (Refinery) adding missing items like jetpacks and keycard auth devices.
• tweak: (Refinery) more dispos chutes in sec for clowns to escape with.

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)

• Resources/Maps/_Starlight/Stations/Refinery.yml

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 4929f3cf-a699-4336-925a-f29fbf3ae978

📥 Commits

Reviewing files that changed from the base of the PR and between bce6630 and 9ec3481.

📒 Files selected for processing (1)

• Resources/Maps/_Starlight/Stations/Refinery.yml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 4a1af3d7-c6ca-432a-a9bc-9ec39b6c0ccc

📥 Commits

Reviewing files that changed from the base of the PR and between 7f13f0a and bce6630.

📒 Files selected for processing (2)

• Resources/Maps/_Starlight/Stations/Refinery.yml
• Resources/Prototypes/_Starlight/Maps/refinery.yml

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

📝 Summary

Summary

• Refines Refinery thematics with decals and additional environmental details.
• Adds extinguisher cabinets and wall-mounted closets.
• Reworks the zookeeper office into a generic service-worker office.
• Enables two K9 security job slots on Refinery.
• Adds StarlightRefinery to DefaultStarlightMapPool.

Gameplay and user impact

Refinery can now appear in normal map rotation. Players can access the enabled K9 security roles. Environmental updates improve facility readability and thematic consistency.

Risk areas

• Map geometry and fixture changes may affect movement, collision, or access routes.
• The security substation door layout may require review because the current engineering door can force an indirect route.
• The generic office may require review of role-independent access and use.
• Map-pool changes expose Refinery during normal play.

Guideline gaps

• The available context does not document Shared-first placement.
• The available context does not document Starlight ownership comments.
• The available context does not address localization.
• The available context does not describe breaking-change impact.
• The available context does not provide detailed rationale for the map refinements or the security substation door choice.

Walkthrough

The default Starlight map pool now includes StarlightRefinery. The map enables two K9 security job slots.

Changes

StarlightRefinery availability

Layer / File(s)	Summary
Add Refinery map and K9 staffing Resources/Prototypes/_Starlight/Maps/Pools/default.yml, Resources/Prototypes/_Starlight/Maps/refinery.yml	Adds StarlightRefinery to the default map pool. Enables K9 with a slot range of [ 2, 2 ] on the map.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bce66

This PR adds Refinery to the map rotation and updates its map configuration and presentation. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: redmushie

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title identifies the Refinery map but does not describe the main changes, which add the map to rotation and enable related map updates.	Replace "Refinery3" with a concise title such as "Add Refinery Starport to map rotation".

✅ Passed checks (4 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The description directly covers the Refinery map refinements and its addition to map rotation. It is related to the changeset.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Content + Integration Test Results

Failed Tests

Failed Tests

❌ SpawnAndDirtyAllEntities SERVER: 6.346s [ERRO] system.container_fill: Entity syndicate snack box (233793/n233793, HappyHonkNukieSnacks) with a EntityTableContainerFillComponent failed to insert an entity: valid salad (233806/n233806, FoodSaladValid). Current contents: - python (233794/n233794, WeaponRevolverPythonAP) - Space Cola can (233795/n233795, DrinkColaCan) - Blood-red Brew can (233797/n233797, DrinkNukieCan) - Space Cola can (233799/n233799, DrinkColaCan) - Space Cola can (233801/n233801, DrinkColaCan) - valid salad (233803/n233803, FoodSaladValid) - valid salad (233804/n233804, FoodSaladValid) - valid salad (233805/n233805, FoodSaladValid) Exception: Trace: at Robust.UnitTesting.Pool.TestPair`2.ReportErrorLogs() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 28 at Robust.UnitTesting.Pool.TestPair`2.OnCleanDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 99 at Robust.UnitTesting.Pool.TestPair`2.OnCleanDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 107 at Robust.UnitTesting.Pool.TestPair`2.CleanReturnAsync() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 125 at Content.IntegrationTests.Fixtures.GameTest.DoTeardown() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Fixtures/GameTest.cs:line 260 at NUnit.Framework.Internal.Commands.SetUpTearDownItem.RunTearDown(TestExecutionContext context) 1) at Robust.UnitTesting.Pool.TestPair`2.ReportErrorLogs() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 25 at Robust.UnitTesting.Pool.TestPair`2.OnCleanDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 99 2) at Robust.UnitTesting.Pool.TestPair`2.OnCleanDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 106

Tests 📝	Passed ✅	Failed ❌	Duration ⏱️
1712	1691	1	17m 27s

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

[CawsForConcern]

big approved

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[Ray-1-A]

If I could ask for a small change to the security substation room for one of the engineering doors to be replaced by a security one, as you kind of have to make your way around just to get behind security maints