Solutions (Rebirth)

[wonderfulnewworld]

Short description

"If there is magic in my heart, can I make this overwhelming dream come true?"

It's the entirety of the Solutions Refactor + a ton of bug fixes, and, as a result of some awkward tangled PRs, also the butchering -> slicing refactor.

I'm going to split up the "list of PRs" into 2 sections, Solutions related, and Slicing related.

Solutions

• Raise SolutionChangedEvent and SolutionContainerChangedEvent when handling SolutionComponent states space-wizards/space-station-14#42814
• Fix Bloodstream Overflow on Rejuvenate space-wizards/space-station-14#43447
• [STAGING] Fix blood regeneration space-wizards/space-station-14#43576
• The big one, the Solutions Refactor: Solutions Refactor Part 1 - Solution Prototypes space-wizards/space-station-14#43412
• Correctly Size Milk Cartons space-wizards/space-station-14#43787
• Allow butter to be mixed into solutions space-wizards/space-station-14#43810
• Some misc solution fixes space-wizards/space-station-14#43823
• Fix Grindable Guide Entries space-wizards/space-station-14#43743
• Fix Broken Solution Enumerators space-wizards/space-station-14#43789
• Fix some prediction and solution duplication issues with the solutions refactor. space-wizards/space-station-14#43728
• Change chemical dispenser and ChemMaster increments space-wizards/space-station-14#43829
• Fix pill labels to reflect their contents space-wizards/space-station-14#43964
• [STAGING] Get Rid of a obsolete test failer in IngestionSystem space-wizards/space-station-14#43790
• [STAGING] Misc Solution Fixes space-wizards/space-station-14#43968
• fix medipens spilling when thrown space-wizards/space-station-14#44102
• Fix for mispredict when using tools on recycler. space-wizards/space-station-14#43766
• Specifically this commit from the Space-Wizards-Federation -> Wizden PR: space-wizards/space-station-14@cb5c1a8
• Solutions Refactor Care Package - Service Department space-wizards/space-station-14#44087
• Fix metamorphic glass not displaying drink names space-wizards/space-station-14#44741
• Recyclers: spill without valid solutions space-wizards/space-station-14#44344

Slicing

• The main one, the Slicing Refactor: Unite LogComponent, FoodSlicableComponent and partially ButcherableComponent into one. Sharp component removal. space-wizards/space-station-14#36895
• Meat spike localization fixes space-wizards/space-station-14#44191
• fix remaining butcherable components space-wizards/space-station-14#44225
• Specifically this commit from the Space-Wizards-Federation -> Wizden PR: space-wizards/space-station-14@1022d12
• Bugfix: Only raise ToolRefineAttemptEvent if used item has needed tool qualities space-wizards/space-station-14#44441
• Fix typo in ToolRefinableSystem name space-wizards/space-station-14#44845
• Fix: Insert items into clothing instead of butchering them when used space-wizards/space-station-14#44860
• Butchering Bugfix for Slicing Tools space-wizards/space-station-14#45424

As I always say when I use AI, I used AI to help me with this PR. It was mainly the "busy" work, the hundreds of 2 line changes to go from solutioncontainer to solution, etc, and some C# assistance too. A lot of busy work.

Since this is technically an upstream merge in a way, might not want to squash merge it? It's not in the same format as the others, so I don't know. It was cherry picked, for what it's worth. (Edit: Yeah don't squash merge this or it'll collide with the other 5 direct PRs that rely on it)

Why we need to add this

We're 7 months behind, and a lot of really good modern features (reagent fires, blood footprints, blood splatter on walls) rely on this PR to work. And to me, this PR existing in our path is a bit of a mental block, so I just want to move past it.

Media (Video/Screenshots)

Note, the silver jug is now 4 wide, 3 tall, instead of 3 wide, 4 tall. It bothered me when I took this picture, so I changed it later.

Despite all those PRs taken, there's not actually that much to show off.

Checks

• I do not require assistance to complete the PR.
• Before posting/requesting review of a PR, I have verified that the changes work.
• I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
• I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog
🆑 wonderfulnewworld, Princess Cheeseballs, kosticia, slarticodefast, themias, rumaks xyz, veprolet, AreYouConfused, insoPL, whatston3, cashew 42, B Kirill, portfiend, korczoczek, deltanedas, Winkarst cpu, Wintoli

• add: You can now boil snails alive in the microwave.
• tweak: Blood volume has been doubled.
• tweak: Many chef recipes have been changed so the final result better matches the ingredients put in. This means overall the nutritional value of the chef's meals have increased.
• tweak: Many chef recipes have had their ingredients changed.
• tweak: Most sliceable foods now give a lot more slices.
• tweak: Reagent container sizes have been standardized, at a base of 30 units per inventory square. Most containers can now hold more than they did before.
• tweak: Changed the size of the silver and gold beakers; they don't fit the standards of the others, since they cost credits.
• tweak: Chemical jugs and bar jugs are now Large (2x4) items.
• tweak: Buckets now hold 360u and are 3x4 items.
• tweak: Nukie medical duffel bag now comes with a bicaridine jug, a mixed puncturase & tranexamic acid jug, a mixed dermaline & pyrazine jug, and a mixed saline & dexalin plus jug.
• tweak: Most items with slicing tool quality now can be used for butchering.
• tweak: Butchering is now predicted and called slicing!
• tweak: Butter and butter slices can be mixed into solutions.
• tweak: Chemical dispenser and ChemMaster transfer increments have been changed to 1u, 5u, 10u, 15u, 20u, 30u, 40u, 60u, and 120u.
• tweak: Hyposprays and jet injectors no longer spill when thrown.
• tweak: The salt and pepper requirements for several recipes have been heavily reduced.
• tweak: Butter now requires Cream instead of Milk to create.

[wonderfulnewworld]

@coderabbitai explain test failures

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

repo="ss14Starlight/space-station-14"
pr_number="5893"
head_sha="$(gh pr view "$pr_number" --repo "$repo" --json headRefOid --jq '.headRefOid')"

echo "== HEAD =="
echo "$head_sha"

echo
echo "== FAILED CHECKS =="
gh pr checks "$pr_number" --repo "$repo" --json name,state,link,workflow \
  --jq '.[] | select(.state == "FAILURE" or .state == "ERROR" or .state == "CANCELLED" or .state == "TIMED_OUT") | [.name, .state, .workflow, .link] | `@tsv`' \
  || true

echo
echo "== FAILED CHECK ANNOTATIONS =="
gh api "repos/$repo/commits/$head_sha/check-runs?per_page=100" \
  --jq '.check_runs[] | select(.conclusion == "failure" or .conclusion == "timed_out" or .conclusion == "cancelled") | [.id, .name, .details_url] | `@tsv`' \
  | while IFS=$'\t' read -r id name url; do
      echo "-- $name: $url"
      gh api "repos/$repo/check-runs/$id/annotations?per_page=100" \
        --jq '.[] | [.path, (.start_line|tostring), .annotation_level, .message] | `@tsv`' \
        || true
    done

echo
echo "== FAILED JOB LOG CONTEXT =="
gh run list --repo "$repo" --commit "$head_sha" --limit 30 \
  --json databaseId,workflowName,conclusion,url \
  --jq '.[] | select(.conclusion == "failure" or .conclusion == "timed_out") | [.databaseId, .workflowName, .url] | `@tsv`' \
  | while IFS=$'\t' read -r run_id workflow url; do
      echo "-- $workflow: $url"
      gh run view "$run_id" --repo "$repo" --log-failed 2>&1 \
        | rg -n -i -C 5 \
          'failed|error:|exception|assert|nunit|xunit|stack trace|unhandled|expected|actual|test.*fail|fatal' \
        | head -n 500 || true
    done

Length of output: 167051

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

repo="ss14Starlight/space-station-14"
run_id="33363526016"
base_sha="$(gh pr view 5893 --repo "$repo" --json baseRefOid --jq '.baseRefOid')"

echo "== DISTINCT FAILED TESTS FROM ALL SHARDS =="
for job_id in 99400917620 99400917714 99400917723; do
  echo "-- job $job_id"
  gh run view "$run_id" --repo "$repo" --job "$job_id" --log-failed 2>&1 \
    | sed -r 's/\x1B\[[0-9;]*[[:alpha:]]//g' \
    | rg -n '^[^[:space:]].*failed[[:space:]]' \
    | head -n 100 || true
done

echo
echo "== CHANGED FILES MATCHING FAILURE TERMS =="
git diff --name-only "$base_sha" HEAD | while IFS= read -r path; do
  if rg -q -i \
    'CosmicGlyphBlades|CheekStorage|TiderLathe|SwordFlamingTA|HelmetForgedTA|BountyKnife|FoodPizzaLarge|FoodPizza|ClothingOuterWinter|SolutionContainerManagerComponent|[[:space:]]Sharp:' \
    "$path"; then
    echo "$path"
  fi
done

echo
echo "== CURRENT MATCHES WITH CONTEXT =="
rg -n -i -C 4 \
  'CosmicGlyphBlades|CheekStorage|TiderLathe|SwordFlamingTA|HelmetForgedTA|BountyKnife|FoodPizzaLarge|FoodPizza|ClothingOuterWinter|SolutionContainerManagerComponent|^[[:space:]]+Sharp:' \
  -g '*.yml' -g '*.yaml' Resources Content.Shared Content.Server Content.Client 2>/dev/null \
  | head -n 900

echo
echo "== RELEVANT PR DIFF =="
git diff --unified=3 "$base_sha" HEAD -- \
  | rg -n -C 4 \
    'CosmicGlyphBlades|CheekStorage|TiderLathe|SwordFlamingTA|HelmetForgedTA|BountyKnife|FoodPizzaLarge|FoodPizza|ClothingOuterWinter|SolutionContainerManagerComponent|^[+-][[:space:]]+Sharp:' \
  | head -n 900

Length of output: 132962

---

@wonderfulnewworld The current failures have five direct causes.

1. Pizza cargo crates can be sold for more than their purchase price.
   NoCargoOrderArbitrage fails for:

   • FoodPizza: cost 450, sale value varies from 844 to 1000.
   • FoodPizzaLarge: cost 1800, sale value varies from 3565 to 3979.

   The increased number or value of pizza slices raises the crate resale value above the cargo product cost. Increase the cargo prices, reduce the produced value, or change the crate contents.

2. FoodPizzaLarge completes the knife bounty.
   NoCargoBountyArbitrageTest reports that FoodPizzaLarge costs 1800 and fulfills BountyKnife, which pays 2000.

   The slicing migration made the large pizza match the bounty’s knife requirements. A pizza should not satisfy BountyKnife. Remove the matching tool/tag/component condition from the pizza, or change the bounty criteria.

3. Winter coats contain both legacy and new food solutions.
   AllItemsHaveSpritesTest fails because the compatibility system logs warnings such as:

   Attempted to port a solution id: food from a SolutionContainerManagerComponent ...
   but the entity already had a solution with that id.
   

   Resources/Prototypes/Entities/Clothing/OuterClothing/wintercoats.yml uses ClothingOuterStorageEdible. The inherited setup already creates food through the new solution system. The legacy SolutionContainerManagerComponent data still attempts to migrate another food solution during map initialization.

   Remove the remaining legacy solution-container definition from the winter-coat inheritance chain. Keep only the new solution definition.

4. Two prototypes still use Sharp, but no Sharp component is registered.
   TestAllServerPrototypesAreSerializable fails for:

   • CosmicGlyphBlades
   • CheekStorage

   Both serialize with:

   Unknown component kind: Sharp
   

   The slicing refactor removed or renamed that component registration. Port these prototypes to the registered slicing component or remove Sharp if it is no longer required.

5. TiderLathe has recipes that require unsupported materials.
   TestLatheRecipeIngredientsFitLathe reports:

   • SwordFlamingTA requires Glass and Plastic.
   • HelmetForgedTA requires Plastic.

   TiderLathe does not accept those materials. Either remove these recipes from TiderLathe, add the materials to its accepted material list, or modify the recipe materials.

Test was dirty-disposed and the VSTestException messages occur after these primary failures. They are test cleanup effects, not separate regressions.

The prior YAML diagnosis does not apply to the current CI run.

_{You are interacting with an AI system.}

[github-actions]

Content + Integration Test Results

Tests 📝	Passed ✅	Failed ❌	Duration ⏱️
1711	1691	0	10m 47s

_{🎉 No failed tests in this run.}

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

[wonderfulnewworld]

Tests all passed. :ikneel: