Skip to content

im the idiot of the century - #5931

Merged
walksanatora merged 1 commit into
ss14Starlight:starlight-devfrom
walksanatora:actually-update-engine
Sep 2, 2026
Merged

im the idiot of the century#5931
walksanatora merged 1 commit into
ss14Starlight:starlight-devfrom
walksanatora:actually-update-engine

Conversation

@walksanatora

@walksanatora walksanatora commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Short description

Oops I accidentally DOWNGRADED Rt when I meant to upgrade it... oops

Why we need to add this

fix delta

Media (Video/Screenshots)

https://www.youtube.com/watch?v=SYCP71qcYZw

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog
🆑 STARLIGHT TEAM

  • fix: Actually updated the engine this time. Actually fixing what it said it would fix.

@walksanatora
walksanatora requested a review from a team September 2, 2026 01:51
@github-actions github-actions Bot added size/XS S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. Changes: No C# labels Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: eedb2dd5-f266-47db-9f8c-bee963ab73b6

📥 Commits

Reviewing files that changed from the base of the PR and between d532506 and 40e4c82.

📒 Files selected for processing (1)
  • RobustToolbox

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Summary

Updates the RobustToolbox submodule from 23edc8e1a20681e0aa213031d3f79ad6f2189867 to 79dc8f3a58331b04efff99c37b5d7d1b8fe95a45.

This corrects an accidental engine downgrade and applies the intended engine upgrade. The change includes no C# code or direct gameplay changes.

Impact and risk

Players receive the intended engine version and its associated fixes. The main risk is an upstream behavior or compatibility change in RobustToolbox. Reviewers should verify that the selected commit contains the intended delta.

Guideline gaps

  • The PR does not state whether the upstream engine update introduces breaking changes.
  • The PR does not describe any design impact from the upstream update.

Walkthrough

The RobustToolbox subproject reference changed to commit 79dc8f3a58331b04efff99c37b5d7d1b8fe95a45.

Changes

RobustToolbox update

Layer / File(s) Summary
Update subproject reference
RobustToolbox
The subproject commit pointer changed from 23edc8e1a20681e0aa213031d3f79ad6f2189867 to 79dc8f3a58331b04efff99c37b5d7d1b8fe95a45.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 40e4c

This is a narrowly scoped engine update with no identified merge-blocking risk; it is ready for normal checks and review.

Suggested reviewers: rinary1

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title is unrelated to the engine version update and does not identify the primary change. Replace the title with a concise description such as "Correct engine version update".
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description explains that the engine version was corrected after an accidental downgrade and that the associated delta was fixed. It is related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Content + Integration Test Results

Tests 📝 Passed ✅ Failed ❌ Duration ⏱️
1697 1677 0 11m 45s

🎉 No failed tests in this run.

Github Test Reporter by CTRF 💚

@walksanatora
walksanatora merged commit 467df1d into ss14Starlight:starlight-dev Sep 2, 2026
24 of 26 checks passed
starlightgithub Bot added a commit that referenced this pull request Sep 2, 2026
@walksanatora
walksanatora deleted the actually-update-engine branch September 2, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: No C# S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant