Skip to content

Stamp Recipes - #5932

Open
JohnnyMalawny wants to merge 2 commits into
ss14Starlight:starlight-devfrom
JohnnyMalawny:stampy-stamp
Open

Stamp Recipes#5932
JohnnyMalawny wants to merge 2 commits into
ss14Starlight:starlight-devfrom
JohnnyMalawny:stampy-stamp

Conversation

@JohnnyMalawny

Copy link
Copy Markdown
Contributor

Short description

Adding the approved stamp, denied stamp, and the stamp box into the command techfab as recipes.

Why we need to add this

It allows more command roles to be able to use these stamps for beaurocracy https://discord.com/channels/1272545509562777621/1544502544045178920

Media (Video/Screenshots)

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 Johnny

  • add: Added the approved stamp, denied stamp, and the stamp box into the command techfab.

@JohnnyMalawny
JohnnyMalawny requested a review from a team September 2, 2026 02:00
@github-actions github-actions Bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Changes: No C# Changes: Prototypes and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S labels Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: a7fdb85c-a817-4fb2-92e9-3108793d0874

📥 Commits

Reviewing files that changed from the base of the PR and between d532506 and f6c5d02.

📒 Files selected for processing (2)
  • Resources/Prototypes/_Starlight/Recipes/Lathes/Packs/command.yml
  • Resources/Prototypes/_Starlight/Recipes/Lathes/misc.yml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Summary

Adds RubberStampApproved, RubberStampDenied, and BoxStamps recipes to the command techfab.

  • Command roles can produce approved stamps, denied stamps, and stamp boxes.
  • Approved and denied stamps require 100 Plastic and take 1 second to produce.
  • Stamp boxes require 500 Cardboard and take 2 seconds to produce.
  • The recipes are added to the StarlightCommandSuppliesStatic recipe pack.

Gameplay impact

More command roles can access the stamps required for bureaucracy without relying on other departments.

Risk areas

The change only adds recipes. It does not modify existing recipes or public declarations. The main balance consideration is the material cost and production time of the new items.

Guideline gaps

No concrete gaps are identified from the available PR context.

Walkthrough

The lathe configuration adds recipes for approved and denied rubber stamps and boxes of stamps. The recipes specify plastic or cardboard costs and completion times. The command supplies recipe pack now exposes all three recipes.

Changes

Lathe recipe additions

Layer / File(s) Summary
Stamp recipe definitions and pack wiring
Resources/Prototypes/_Starlight/Recipes/Lathes/misc.yml, Resources/Prototypes/_Starlight/Recipes/Lathes/Packs/command.yml
Defines RubberStampApproved, RubberStampDenied, and BoxStamps with their material costs and completion times. Adds the recipes to StarlightCommandSuppliesStatic.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f6c5d

This change adds three stamp-related recipes to the command techfab without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: rinary1

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the addition of stamp recipes and matches the main change.
Description check ✅ Passed The description explains that approved stamps, denied stamps, and a stamp box are added to the command techfab as recipes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size/S label Sep 2, 2026
@wonderfulnewworld

Copy link
Copy Markdown
Contributor

Use partials to remove the steal target component from these.

@JohnnyMalawny

Copy link
Copy Markdown
Contributor Author

okay....

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Content + Integration Test Results

Tests 📝 Passed ✅ Failed ❌ Duration ⏱️
1697 1677 0 18m 45s

🎉 No failed tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: No C# Changes: Prototypes S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants