-
Notifications
You must be signed in to change notification settings - Fork 592
AI: Reconnect to last shunt #5933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Proximitron
wants to merge
10
commits into
ss14Starlight:starlight-dev
Choose a base branch
from
Proximitron:AI-reshunt-reconnect-to-borg
base: starlight-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e14dd66
This simply allowes to reconnect to a shunt again. The only check ski…
Proximitron 7619c3a
Merge branch 'ss14Starlight:starlight-dev' into AI-reshunt-reconnect-…
Proximitron c8be267
coderabbitai was nitpicking. This variant now updates possible stale …
Proximitron 394dc3c
Merge branch 'AI-reshunt-reconnect-to-borg' of https://github.com/Pro…
Proximitron a1a82ad
Update Resources/Prototypes/_Starlight/station_ai.yml
Proximitron 924d983
Update Content.Shared/_Starlight/Silicons/Borgs/StationAIShuntSystem.cs
Proximitron 098a946
Update Content.Shared/_Starlight/Silicons/Borgs/StationAIShuntableCom…
Proximitron 10b0b87
Merge branch 'starlight-dev' into AI-reshunt-reconnect-to-borg
Proximitron 88d6a4e
Update Content.Shared/Silicons/Borgs/SharedBorgSystem.cs
Proximitron 727f3ef
Update Content.Shared/Silicons/Borgs/SharedBorgSystem.cs
Proximitron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
Content.Shared/_Starlight/Silicons/Borgs/StationAIShuntSystem.Reconnect.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| using Content.Shared.Actions; | ||
|
|
||
| namespace Content.Shared._Starlight.Silicons.Borgs; | ||
|
|
||
| public sealed partial class StationAIShuntSystem | ||
| { | ||
| private void InitializeReconnect() | ||
| { | ||
| SubscribeLocalEvent<StationAIShuntableComponent, AIReconnectShuntActionEvent>(OnAttemptReconnect); | ||
|
Check warning on line 9 in Content.Shared/_Starlight/Silicons/Borgs/StationAIShuntSystem.Reconnect.cs
|
||
| } | ||
|
|
||
| private void OnAttemptReconnect(EntityUid uid, StationAIShuntableComponent shuntable, AIReconnectShuntActionEvent ev) | ||
| { | ||
| if (ev.Handled || shuntable.Inhabited.HasValue || shuntable.LastShunt is not { } lastShunt || Deleted(lastShunt)) | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| return; | ||
|
|
||
| var shuntEv = new AIShuntActionEvent | ||
| { | ||
| Target = lastShunt, | ||
| Performer = uid, | ||
| IgnoreCameraView = true | ||
| }; | ||
| RaiseLocalEvent(uid, shuntEv); | ||
| ev.Handled = shuntEv.Handled; | ||
| } | ||
| } | ||
|
|
||
| public sealed partial class AIReconnectShuntActionEvent : Content.Shared.Actions.InstantActionEvent | ||
| { | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
Content.Shared/_Starlight/Silicons/Borgs/StationAIShuntableComponent.Reconnect.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| using Robust.Shared.GameObjects; | ||
| using Robust.Shared.GameStates; | ||
|
|
||
| namespace Content.Shared._Starlight.Silicons.Borgs; | ||
|
|
||
| public sealed partial class StationAIShuntableComponent | ||
| { | ||
| /// <summary> | ||
| /// The last shunt target used by this AI, if it still exists. | ||
| /// </summary> | ||
| [ViewVariables] | ||
| [DataField, AutoNetworkedField] | ||
| public EntityUid? LastShunt { get; set; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| ai-shunt-into = Enter Chassis | ||
| ai-shunt-out-of = Exit Chassis | ||
| ai-shunt-reconnect = Reconnect Chassis | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.