Modern ChemMaster UI Changes - #5939
Open
RhapsodySL wants to merge 83 commits into
Open
Conversation
* Everything except the YAML slop... * She solution on my manager till I sajfslkahfsjakfhaskjfshajksafhfsakhfasjfas * another 1000 lines * fix chem dispenser size * go my shnelf * Implicit ass * rider is being mean for some reason * dasdas * borger * better formatting go! * clothes/bloodstream * Cartons * cups and bottles * mmm soder * bar drinks * Spray bottles and some size tweaks with hindsight * 99 bottles of beer on the wall I hate YAML * push that shit * mmm burger * Sneed * sheets * condiments * mmm yummy * fridge yummyfood * meat... * sub 300 * burger... * bready * let them eat cake * does she know how to make a grilled cheese? * pizza pie! * misc shit * soup or salad * Food and drinks, vanquished * the cubes!!! * Almost free from YAML... * fix test fails and some yaml issues * fix prediction, almost done * fix all test fails * remove master merge artifacts and undo autonetworking * review and compatibility * graaah * unfuck master merge I hate github * merg conflicts * sfsa * ehoop * sadas * afsafsaasf * merge conflicts * fucked up the merge conflicts * merge conflict is fucked I might need to completely redo this branch * test fail * no calcium???? --------- Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com> # Conflicts: # Content.Client/Chemistry/EntitySystems/ChemistryGuideDataSystem.cs # Content.Server/Administration/Systems/AdminVerbSystem.cs # Content.Server/Stunnable/Systems/StunbatonSystem.cs # Content.Server/_Starlight/Kitchen/EntitySystems/CookingDeviceSystem.cs # Content.Shared/Chemistry/Components/Solution.cs # Content.Shared/Chemistry/Components/SolutionComponent.cs # Content.Shared/Chemistry/EntitySystems/RehydratableSystem.cs # Content.Shared/Chemistry/EntitySystems/SharedSolutionContainerSystem.Relays.cs # Content.Shared/Chemistry/EntitySystems/SharedSolutionContainerSystem.cs # Content.Shared/Chemistry/EntitySystems/SolutionRegenerationSystem.cs # Content.Shared/EntityEffects/Effects/Solution/AddReagentToSolutionEntityEffectSystem.cs # Content.Shared/Fluids/SharedPuddleSystem.cs # Content.Shared/Kitchen/EntitySystems/SharedReagentGrinderSystem.cs # Content.Shared/Medical/Cryogenics/SharedCryoPodSystem.cs # Content.Shared/Nutrition/EntitySystems/IngestionSystem.cs # Content.Shared/Nutrition/EntitySystems/PressurizedSolutionSystem.cs # Content.Shared/_Starlight/Medical/Body/Systems/MetabolizerSystem.cs # Content.Shared/_Starlight/Medical/Body/Systems/StomachSystem.cs # Resources/Prototypes/Body/Animals/ruminant.yml # Resources/Prototypes/Body/Species/arachnid.yml # Resources/Prototypes/Body/Species/diona.yml # Resources/Prototypes/Body/Species/gingerbread.yml # Resources/Prototypes/Body/Species/moth.yml # Resources/Prototypes/Body/Species/slime.yml # Resources/Prototypes/Body/Species/vox.yml # Resources/Prototypes/Body/Species/vulpkanin.yml # Resources/Prototypes/Body/base_organs.yml # Resources/Prototypes/Entities/Clothing/OuterClothing/coats.yml # Resources/Prototypes/Entities/Mobs/NPCs/animals.yml # Resources/Prototypes/Entities/Mobs/NPCs/argocyte.yml # Resources/Prototypes/Entities/Mobs/NPCs/space.yml # Resources/Prototypes/Entities/Mobs/NPCs/spacetick.yml # Resources/Prototypes/Entities/Objects/Consumable/Drinks/drinks-cartons.yml # Resources/Prototypes/Entities/Objects/Consumable/Drinks/drinks_cups.yml # Resources/Prototypes/Entities/Objects/Consumable/Drinks/drinks_metamorphic.yml # Resources/Prototypes/Entities/Objects/Consumable/Drinks/trash_drinks.yml # Resources/Prototypes/Entities/Objects/Consumable/Food/Baked/pizza.yml # Resources/Prototypes/Entities/Objects/Consumable/Food/ingredients.yml # Resources/Prototypes/Entities/Objects/Consumable/Food/meat.yml # Resources/Prototypes/Entities/Objects/Consumable/Food/produce.yml # Resources/Prototypes/Entities/Objects/Consumable/Food/snacks.yml # Resources/Prototypes/Entities/Objects/Consumable/Food/soup.yml # Resources/Prototypes/Entities/Objects/Fun/toys.yml # Resources/Prototypes/Entities/Objects/Materials/Sheets/glass.yml # Resources/Prototypes/Entities/Objects/Materials/Sheets/metal.yml # Resources/Prototypes/Entities/Objects/Materials/Sheets/other.yml # Resources/Prototypes/Entities/Objects/Materials/crystal_shard.yml # Resources/Prototypes/Entities/Objects/Materials/ingots.yml # Resources/Prototypes/Entities/Objects/Materials/parts.yml # Resources/Prototypes/Entities/Objects/Misc/paper.yml # Resources/Prototypes/Entities/Objects/Specific/Chemistry/chemical-containers.yml # Resources/Prototypes/Entities/Objects/Specific/Chemistry/chemistry-bottles.yml # Resources/Prototypes/Entities/Objects/Specific/Hydroponics/leaves.yml # Resources/Prototypes/Entities/Objects/Specific/Medical/healing.yml # Resources/Prototypes/Entities/Objects/Specific/Medical/hypospray.yml # Resources/Prototypes/Entities/Objects/Specific/Medical/morgue.yml # Resources/Prototypes/Entities/Objects/Tools/cable_coils.yml # Resources/Prototypes/Entities/Objects/Tools/lighters.yml # Resources/Prototypes/Entities/Objects/Tools/welders.yml # Resources/Prototypes/Entities/Objects/Weapons/Guns/Ammunition/Cartridges/shotgun.yml # Resources/Prototypes/Entities/Objects/Weapons/Guns/Projectiles/projectiles.yml # Resources/Prototypes/Entities/Objects/Weapons/security.yml # Resources/Prototypes/Entities/Structures/Furniture/toilet.yml # Resources/Prototypes/Entities/Structures/Machines/chem_master.yml # Resources/Prototypes/Entities/Structures/Machines/reagent_grinder.yml # Resources/Prototypes/Entities/Structures/Specific/Janitor/janicart.yml # Resources/Prototypes/Entities/Tiles/water.yml # Resources/migration.yml
change parents Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* fix overflow and mice * actually don't relay it, each individual solution should handle it. * misc * ensure the solution overflow is tested --------- Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com> Co-authored-by: Janet Blackquill <uhhadd@gmail.com> # Conflicts: # Content.Shared/Chemistry/EntitySystems/SharedSolutionContainerSystem.Relays.cs
whoops Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* burge * bruegr * YAML * two misc fixes * snoutta here * add tests --------- Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com> Co-authored-by: Janet Blackquill <uhhadd@gmail.com> # Conflicts: # Content.Server/Chemistry/EntitySystems/VaporSystem.cs # Content.Server/Fluids/EntitySystems/SpraySystem.cs # Content.Server/Weapons/Ranged/Systems/GunSystem.Solution.cs # Content.Shared/Chemistry/EntitySystems/SolutionPurgeSystem.cs # Content.Shared/Chemistry/EntitySystems/SolutionRegenerationSystem.cs # Content.Shared/EntityEffects/Effects/Solution/AddReagentToSolutionEntityEffectSystem.cs # Resources/Prototypes/Entities/Objects/Tools/lighters.yml # Resources/Prototypes/Entities/Structures/Furniture/toilet.yml
…s refactor. (#43728) * fix prediction and solution duplication issues * lock down * wait I fogrot other systems need to read this id I'm stupid * fix * actually throw * better comment and obsoletion * master merge + fix popup text * netowkring fix * better debug assert * back to basics * dumbb --------- Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
change increments
Co-authored-by: veprolet <> # Conflicts: # Resources/Prototypes/Entities/Objects/Specific/Medical/healing.yml
* Goodbye * whoop --------- Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
misc fixes Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* no longer will medipens spill when thrown * reparented injectors/sprays to removed spillable component * hyposprays and jet injectors nolonger spill when thrown.
* predict * fix # Conflicts: # Content.Shared/Materials/SharedMaterialReclaimerSystem.cs
* moproach/spider solutions with recharge * mop mop mop roach * more straightforward moproach solution inheritance
* draf * slime time * ddsaasdgatagsde * fix that shit --------- Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com> # Conflicts: # Content.Shared/Tools/Systems/ToolRefinableSystem.cs # Resources/Prototypes/Entities/Mobs/NPCs/animals.yml # Resources/Prototypes/Entities/Objects/Consumable/Drinks/drinks_metamorphic.yml # Resources/Prototypes/Entities/Objects/Consumable/Food/Baked/bread.yml
add transformablecontainer back to the metamorphic glass
* Recyclers: spill without valid solutions * Early return on empty
…mponent into one. Sharp component removal. (#36895) * Yay * Do a LOT changes in yml * and again * Finale changes * yml and locale * locale tweak * yml and charp cleanup * fix carpets * and some-some * And some * I want to believe that its last🙏🙏 * 😭 * 😭😭 * clean * fix * AAHHAHAHAHAHAH * fix * FINAL * thisguyusa... * LAST_ONE * wawa * merge2 * sdobfjibwdsjaqaksmzxsowaw2edqw84 * aoaoaooaoaao * this hardcode took 30 minutes of my life * fix aaaa * fix test * FIX BUILD * oops * oops * aaooaoaoa * fuck * oops * refactor: cleanup after merge + use protoId in KitchenSpikeComponent * refactor: fix butcherable stuff again!~ * fix: now actively checks for EdibleComponent on slicing, predicted items splitting * fix: changed knife.yaml to use Slicing tool * fix: no more sounds spam on chop-chop * refactor: cleanups * refactor: default time value for slicable * refactor: whitespaces and extract variables * fix: slicable no longer prevents InteractUsingEvent by marking handled w/o actually handling * feat: chopping trees now requires sawing tool, same for slicing logs * refactor: cleanup after merge * refactor: fix non-related PR changes * refactor: rename locid * refactor: remove unneeded red 'slice' verb name when slicing entities with mob-state. * refactor: simplify test code changes * refactor: better readability for test * refactor: linebreak for unary op * refactor: xml-doc for SliceableComponent corrected to be more fitting. * refactor: cleanup SliceableSystem some more * refactor: use HasComp instead of TryComp in AddSliceVerb * refactor: extracted methods to improve readability * refactor: remove unchecked operator - not needed when casting from uint * refactor: SliceableSystem cleanups, fix logs not being chopped due to solution splitting * fix: slice verb is now showing up even if disabled, slicing is done even if there is no solution to split, replaced direct dependency for sliceable component to food component with default solution-name * refactor: comment about RandomPredicted + toy knife now fits into clown shoes * refactor: remove EdibleComponent dependency from SliceableSystem * refactor: moved SliceableSystem into ToolRefinableSystem * refactor: basic renaming for comps * refactor: cleanup after merge * refactor: reorder methods, renaming, simplify polymorph related conditions on slicing * refactor: xml-doc + reorder yaml fields * refactor: fixing yaml + method renaming, unused usings removed * refactor: removed unused usings * refactor: fix typo * refactor: remove reference for deleted meat proto * refactor: clean up yaml after merge * refactor: fix multiple typos from mass replace * refactor: fix missed field renaming * refactor: ensure all entities that had ToolRefinable got BaseSlicingRefinable (aftermerge cleanup) * refactor: undo solution-related changes for animals.yml * refactor: fix invalid parent set for corgi + fix amount of slices for the rest of pies * refactor: revert Solution to SolutionContainerManager changes after merge * refactor: revert Solution to SolutionContainerManager changes after merge * refactor: fix invalid property name for toolMissingQualityTooltip in yml, fixed missing entity on which AttemptToolRefineEvent is raised * refactor: remove over-indent for components of BaseSlicingRefinable and for Slicing tool quality * refactor: remove over-indentation on MobCarpHolo * empty collection --------- Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru> Co-authored-by: Fildrance <fildrance@gmail.com> Co-authored-by: iaada <iaada@users.noreply.github.com> # Conflicts: # Content.IntegrationTests/Tests/CargoTest.cs # Content.Server/Botany/Components/LogComponent.cs # Content.Server/_Starlight/Nutrition/EntitySystems/SliceableFoodSystem.cs # Content.Shared/Nutrition/EntitySystems/SharedCreamPieSystem.cs # Content.Shared/Nutrition/IngestionEvents.cs # Content.Shared/Tools/Systems/ToolRefinableSystem.cs # Content.Shared/_Starlight/Kitchen/EntitySystems/SharedSharpSystem.cs # Resources/Locale/en-US/nutrition/components/sliceable-food-component.ftl # Resources/Prototypes/Body/Species/diona.yml # Resources/Prototypes/Body/Species/reptilian.yml # Resources/Prototypes/Body/Species/slime.yml # Resources/Prototypes/Body/Species/vox.yml # Resources/Prototypes/Body/species_base.yml # Resources/Prototypes/Entities/Clothing/Hands/gloves.yml # Resources/Prototypes/Entities/Mobs/NPCs/animals.yml # Resources/Prototypes/Entities/Mobs/NPCs/hellspawn.yml # Resources/Prototypes/Entities/Mobs/NPCs/pets.yml # Resources/Prototypes/Entities/Mobs/NPCs/regalrat.yml # Resources/Prototypes/Entities/Mobs/NPCs/slimes.yml # Resources/Prototypes/Entities/Objects/Consumable/Food/Baked/bread.yml # Resources/Prototypes/Entities/Objects/Consumable/Food/Baked/cake.yml # Resources/Prototypes/Entities/Objects/Consumable/Food/Baked/pie.yml # Resources/Prototypes/Entities/Objects/Consumable/Food/ingredients.yml # Resources/Prototypes/Entities/Objects/Consumable/Food/meat.yml # Resources/Prototypes/Entities/Objects/Materials/crystal_shard.yml # Resources/Prototypes/Entities/Objects/Materials/shards.yml # Resources/Prototypes/Entities/Objects/Misc/broken_bottle.yml # Resources/Prototypes/Entities/Objects/Specific/Medical/surgery.yml # Resources/Prototypes/Entities/Objects/Weapons/Melee/armblade.yml # Resources/Prototypes/Entities/Objects/Weapons/Melee/chainsaw.yml # Resources/Prototypes/Entities/Objects/Weapons/Melee/e_sword.yml # Resources/Prototypes/Entities/Objects/Weapons/Melee/fireaxe.yml # Resources/Prototypes/Entities/Objects/Weapons/Melee/knife.yml # Resources/Prototypes/Entities/Objects/Weapons/Melee/sword.yml
* Meat spike localization fixes * Review
* relocalize these two messages * fix erroneous butcherable components pt 1 * fix argocyte butchery * redundant # Conflicts: # Resources/Prototypes/Entities/Mobs/NPCs/animals.yml # Resources/Prototypes/Entities/Mobs/NPCs/carp.yml
…d to be instead of dropping onto the floor (ss14Starlight#160)
…l qualities (#44441) ToolRefinableSystem: check used tool before evt
e Co-authored-by: deltanedas <@deltanedas:goida.zip>
Update SharedKitchenSpikeSystem.cs
github-actions
Bot
added
size/L
Changes: UI
Changes: C#
Changes: Prototypes
and removed
S: Needs Review
Contributor
|
Important Review skippedToo many files! This PR contains 535 files, which is 435 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (535)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
@coderabbitai Run a code review on commits between1bfed1e and 095ffad. |
Contributor
|
This command requires write access to the repository. Only users with write or admin permissions can trigger CodeRabbit to commit or create pull requests. |
Contributor
Author
|
@coderabbitai The additions made by this PR are from commits 1bfed1e to 095ffad. Review this collection of commits. |
Contributor
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base='1bfed1ecb8c9027f0497c20c67ac6f378946e352'
head='095ffada9799f5b4a2dbc0eccbacdda1e64e147c'
git cat-file -e "${base}^{commit}"
git cat-file -e "${head}^{commit}"
printf '%s\n' '=== commits ==='
git show -s --format='%H%n%s%n%b' "$base"
printf '%s\n' '---'
git show -s --format='%H%n%s%n%b' "$head"
printf '%s\n' '=== changed files (base^..head, inclusive) ==='
git diff --name-status "${base}^" "$head"
printf '%s\n' '=== diff ==='
git diff --find-renames --find-copies --unified=80 "${base}^" "$head"
printf '%s\n' '=== outlines of changed C# files ==='
git diff --name-only "${base}^" "$head" -- '*.cs' |
while IFS= read -r file; do
printf '\n--- %s ---\n' "$file"
ast-grep outline "$file" --items all --view expanded || true
doneLength of output: 98153 🏁 Script executed: #!/bin/bash
set -euo pipefail
base='1bfed1ecb8c9027f0497c20c67ac6f378946e352'
head='095ffada9799f5b4a2dbc0eccbacdda1e64e147c'
printf '%s\n' '=== changed implementation with line numbers ==='
nl -ba Content.Client/_Starlight/Chemistry/UI/ModernChemMasterWindow.xaml.cs | sed -n '270,405p'
nl -ba Content.Client/_Starlight/Chemistry/UI/ModernChemMasterWindow.xaml.cs | sed -n '730,935p'
printf '%s\n' '=== selector behavior before the range ==='
git show "${base}^:Content.Client/_Starlight/Chemistry/UI/ModernChemMasterWindow.xaml.cs" |
nl -ba | sed -n '210,340p'
printf '%s\n' '=== title bar positioning API usages ==='
rg -n -C 5 --glob '*.cs' \
'(SetPositionInParent\s*\(|CloseButton\.Parent|class\s+PopOutFancyWindow\b)' .
printf '%s\n' '=== amount event subscriptions and state updates ==='
rg -n -C 5 --glob '*.cs' \
'(OnAmountSelected\s*\+=|SetSelectedAmount\s*\(|ChemMasterSetTransferAmountMessage\s*\()' \
Content.Client Content.Server Content.Shared
printf '%s\n' '=== static UI dictionaries and network-entity lifetime handling ==='
rg -n -C 4 --glob '*.cs' \
'(static\s+readonly\s+Dictionary<NetEntity|Dictionary<NetEntity|SetChemMasterEntity\s*\()' \
Content.ClientLength of output: 1590 🏁 Script executed: #!/bin/bash
set -euo pipefail
base='1bfed1ecb8c9027f0497c20c67ac6f378946e352'
printf '%s\n' '=== changed selector and layout implementation ==='
sed -n '270,405p' Content.Client/_Starlight/Chemistry/UI/ModernChemMasterWindow.xaml.cs
sed -n '730,935p' Content.Client/_Starlight/Chemistry/UI/ModernChemMasterWindow.xaml.cs
printf '%s\n' '=== selector behavior before the range ==='
git show "${base}^:Content.Client/_Starlight/Chemistry/UI/ModernChemMasterWindow.xaml.cs" |
sed -n '210,340p'
printf '%s\n' '=== title bar positioning API usages ==='
rg -n -C 5 --glob '*.cs' \
'(SetPositionInParent\s*\(|CloseButton\.Parent|class\s+PopOutFancyWindow\b)' .
printf '%s\n' '=== amount event subscriptions and state updates ==='
rg -n -C 5 --glob '*.cs' \
'(OnAmountSelected\s*\+=|SetSelectedAmount\s*\(|ChemMasterSetTransferAmountMessage\s*\()' \
Content.Client Content.Server Content.Shared
printf '%s\n' '=== static UI dictionaries and network-entity lifetime handling ==='
rg -n -C 4 --glob '*.cs' \
'(static\s+readonly\s+Dictionary<NetEntity|Dictionary<NetEntity|SetChemMasterEntity\s*\()' \
Content.ClientLength of output: 63371
I found no actionable correctness regressions in this range. The custom amount message has server-side bounds validation. The title-bar control uses the existing
|
Contributor
Content + Integration Test ResultsFailed Tests
Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Contributor
Author
|
@coderabbitai Explain the test failures. |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ss14Starlight/space-station-14"
pr="5939"
printf '%s\n' '=== pull request status ==='
gh pr view "$pr" --repo "$repo" --json headRefOid,statusCheckRollup \
--jq '{headRefOid, checks: [.statusCheckRollup[] | {name, status, conclusion, detailsUrl}]}'
printf '%s\n' '=== failed workflow jobs ==='
gh api "repos/$repo/actions/runs?event=pull_request&per_page=100" \
--jq --arg head "$(gh pr view "$pr" --repo "$repo" --json headRefOid --jq .headRefOid)" \
'[.workflow_runs[] | select(.head_sha == $head) | {id, name, conclusion, html_url}]' |
while IFS= read -r run; do
run_id="$(jq -r '.id' <<<"$run")"
printf '%s\n' "$run"
gh api "repos/$repo/actions/runs/$run_id/jobs?filter=latest&per_page=100" \
--jq '[.jobs[] | select(.conclusion == "failure") | {id, name, conclusion, started_at, completed_at, html_url, steps: [.steps[] | select(.conclusion == "failure") | {name, number, conclusion}]}]'
doneLength of output: 4731 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ss14Starlight/space-station-14"
for job in 100155589463 100155589429; do
printf '\n=== job metadata: %s ===\n' "$job"
gh api "repos/$repo/actions/jobs/$job" \
--jq '{name, conclusion, html_url, steps: [.steps[] | {number, name, conclusion, started_at, completed_at}]}'
printf '\n=== failed log: %s ===\n' "$job"
gh run view 33600771723 --repo "$repo" --job "$job" --log-failed || true
doneLength of output: 198980 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ss14Starlight/space-station-14"
run="33600771723"
workdir="$(mktemp -d)"
trap 'rm -rf "$workdir"' EXIT
gh run view "$run" --repo "$repo" --log-failed > "$workdir/failed.log"
printf '%s\n' '=== failed test names and retry summaries ==='
rg -n -i -C 2 'failed.*\(|Retry summary|Test run summary|hang|timed out|exception' \
"$workdir/failed.log" |
grep -E 'Integration Tests \(shard (0|1)\)|Retry summary|Test run summary' | head -n 240
printf '%s\n' '=== changed files in the reviewed commit range ==='
git diff --name-only 1bfed1ecb8c9027f0497c20c67ac6f378946e352^ 095ffada9799f5b4a2dbc0eccbacdda1e64e147c
printf '%s\n' '=== repository files related to the gumball prototypes or the solution-port warning ==='
rg -n -i -C 2 \
'FoodSnackGumball|Attempted to port a solution id|AllItemsHaveSpritesTest' \
Content.* RobustToolbox 2>/dev/null | head -n 200Length of output: 55602 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ss14Starlight/space-station-14"
run="33600771723"
workdir="$(mktemp -d)"
trap 'rm -rf "$workdir"' EXIT
printf '%s\n' '=== artifacts ==='
gh api "repos/$repo/actions/runs/$run/artifacts?per_page=100" \
--jq '.artifacts[] | {id, name, expired}'
gh run download "$run" --repo "$repo" --dir "$workdir/artifacts"
printf '%s\n' '=== failed CTRF test results ==='
fd -t f -e json . "$workdir/artifacts" -x sh -c \
'jq -r '"'"'
.results.tests[]?
| select((.status // .outcome // "") | test("fail|error"; "i"))
| "\($ENV.RESULT_FILE): \(.name // .id // "<unnamed>")\n \(.message // .error.message // .extra.message // "<no message>")"
'"'"' "$1"' sh {} |
sed -n '1,160p'
printf '%s\n' '=== changed files in reviewed range ==='
git diff --name-only 1bfed1ecb8c9027f0497c20c67ac6f378946e352^ 095ffada9799f5b4a2dbc0eccbacdda1e64e147cLength of output: 25763
The relevant error is:
The reviewed commit range changes only ChemMaster UI, ChemMaster networking, 🐇🔍 You are interacting with an AI system. |
Contributor
|
Merge my branch into yours again, I have those test fails fixed |
Contributor
|
Since you're working on a branch of mine, pretty much pull from me instead of pressing merge on github, since I have a trail of merges that go upwards to the solutions pr. |
Contributor
|
That way we don't get any awkward out of order merge conflicts in the future |
Contributor
Author
|
Going to do a quick pass on something in the output tab that's bothering me after I get some sleep, otherwise good to go. |
A comment heavily implies this was either a planned feature or broken at some point or something, but it makes sense to have it shown here so we add it.
Contributor
Author
|
Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Dependent on #5894. Makes various visual improvements to the ChemMaster's new "Modern" layout as well as the old "Classic" layout, and adds feature parity as well as a custom unit selector. Specifically:
In Modern:
In Classic:
In both:
Why we need to add this
The Modern layout from #5894 has some nice features but is visually a bit rough. Some polish makes it look better, is a good excuse to port the filter search bar to the Classic layout, and is a good opportunity to add custom unit amount selection to help smooth over the jug size changes.
List of commits added by this PR for reviewing purposes: https://github.com/ss14Starlight/space-station-14/pull/5939/changes/e9456ef962ea5167ddb033bea3fd2ff5db0bf557..095ffada9799f5b4a2dbc0eccbacdda1e64e147c
Media (Video/Screenshots)
chemmaster.mp4
Checks
Changelog
🆑 Rhapsody (Pepta Vismahl)