Oasis dat DAWG chore alongside killing all mail techs. - #5947
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 SummarySummary
Gameplay impactPlayers can access K9 roles on both stations. The available job configuration limits Oasis to one K9 slot and Sepultum to two slots. Risk areasThe changes affect station job availability only. They may alter job distribution and round-start role selection on the affected stations. Guideline gapsThe PR context does not provide:
WalkthroughThe map prototypes now include the ChangesK9 Map Job Availability
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR updates station layouts and adds K9 job availability on Oasis and Sepultum. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Content + Integration Test ResultsFailed Tests
Github Test Reporter by CTRF 💚 |
CawsForConcern
left a comment
There was a problem hiding this comment.
review
- oasis changes look good
- test fails real on sepultum
There was a problem hiding this comment.
test fails real on sepultum
failed GameMapsLoadableTest("StarlightSepultum") (44s 118ms)
Multiple failures or warnings in test:
1) There is no spawnpoints for K9 on StarlightSepultum.
Short description
More chores! K9 spawn support and mailboxes to stop the mail spam everywhere.
Why we need to add this
I hate mail clutter and love doing chores. Also some guy is asking for more lawyer offices and with the new nct mapping standards i can make room for lawyer. #5821 #5821
Media (Video/Screenshots)
Checks
Changelog
🆑 Cvlancer