Skip to content

Oasis dat DAWG chore alongside killing all mail techs. - #5947

Open
Cvlancer wants to merge 1 commit into
ss14Starlight:starlight-devfrom
Cvlancer:Oasis-dat-DAWG-chore-alongside-killing-all-mail-techs
Open

Oasis dat DAWG chore alongside killing all mail techs.#5947
Cvlancer wants to merge 1 commit into
ss14Starlight:starlight-devfrom
Cvlancer:Oasis-dat-DAWG-chore-alongside-killing-all-mail-techs

Conversation

@Cvlancer

@Cvlancer Cvlancer commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Short description

More chores! K9 spawn support and mailboxes to stop the mail spam everywhere.

Why we need to add this

I hate mail clutter and love doing chores. Also some guy is asking for more lawyer offices and with the new nct mapping standards i can make room for lawyer. #5821 #5821

Media (Video/Screenshots)

image image image image image image

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog

🆑 Cvlancer

  • add: (Oasis) Added a single k9 spawn inside.
  • add: (Oasis) Added all mailboxes.
  • add: (Oasis) Added a lawyer's office by shrinking NCT office near chapel.
  • add: (Oasis) Added box shelf storage to science storage room,cargo front, maints shop, gen pop island cargo dock.
  • add: (Oasis) Added a TON of toilet paper and hand santizers to several of the bathrooms and sinks.
  • add: (Sepultum) Added two k9 to sepultum via prototypes (Spawners already mapped in).
  • tweak: (Oasis) Changed trimmed some grass near evac.
  • tweak: (Oasis) Changed nct office to be ALOT smaller.

@Cvlancer
Cvlancer requested a review from a team September 2, 2026 19:51
@github-actions github-actions Bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/L S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. Changes: Map Changes: No C# Changes: Prototypes and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/L labels Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: d92afda4-45c9-427d-a254-745880ee6c7d

📥 Commits

Reviewing files that changed from the base of the PR and between ffa0558 and 9bb4f60.

📒 Files selected for processing (3)
  • Resources/Maps/_Starlight/Stations/Oasis.yml
  • Resources/Prototypes/_Starlight/Maps/oasis.yml
  • Resources/Prototypes/_Starlight/Maps/sepultum.yml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Summary

Summary

  • Adds one K9 security job slot to StarlightOasis.
  • Adds two K9 security job slots to Sepultum.
  • Enables K9 gameplay on the Oasis and Sepultum stations.

Gameplay impact

Players can access K9 roles on both stations. The available job configuration limits Oasis to one K9 slot and Sepultum to two slots.

Risk areas

The changes affect station job availability only. They may alter job distribution and round-start role selection on the affected stations.

Guideline gaps

The PR context does not provide:

  • The rationale for the station-specific K9 slot counts.
  • Confirmation that the changes follow Shared-first placement.
  • Starlight ownership comments, if required by project conventions.
  • Localization impact or confirmation that no localization changes are needed.
  • Confirmation that the changes have no breaking impact.
  • Design impact details beyond enabling K9 roles.
  • Evidence for the described Oasis station layout, Sepultum station layout, mailboxes, lawyer’s office, storage, bathroom supplies, grass trimming, or reduced NCT office changes.

Walkthrough

The map prototypes now include the K9 security job. StarlightOasis provides one slot, and Sepultum provides two slots.

Changes

K9 Map Job Availability

Layer / File(s) Summary
Add K9 jobs to map job lists
Resources/Prototypes/_Starlight/Maps/oasis.yml, Resources/Prototypes/_Starlight/Maps/sepultum.yml
The StarlightOasis map includes one K9 slot. The Sepultum map includes two K9 slots.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 9bb4f

This PR updates station layouts and adds K9 job availability on Oasis and Sepultum. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: rinary1

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title refers to Oasis changes and mail-related work, which are included in the PR objectives. It does not mention Sepultum K9 support, but partial coverage passes this check.
Description check ✅ Passed The description is related to the changeset. It lists Oasis map changes, mailbox work, lawyer office changes, and K9 support for Oasis and Sepultum.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Content + Integration Test Results

Failed Tests

Failed Tests
❌ GameMapsLoadableTest("StarlightSepultum")
Multiple failures or warnings in test:
  1)   There is no spawnpoints for K9 on StarlightSepultum.
Assert.That(jobs, Is.Empty)
  Expected: <empty>
  But was:  < K9 >
     at Content.IntegrationTests.Tests.PostMapInitTest.<>c__DisplayClass21_0.<GameMapsLoadableTest>b__0() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/PostMapInitTest.cs:line 489
   at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.SingleThreadRunUntilEmpty() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1273
   at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.Run() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1237
   at Robust.UnitTesting.RobustIntegrationTest.ServerIntegrationInstance._serverMain() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 773
   at System.Threading.Thread.StartHelper.Callback(Object state)
  2) Test was dirty-disposed.
     at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 44
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose()
   at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 146
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync()
   at Content.IntegrationTests.Fixtures.GameTest.DoTeardown() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Fixtures/GameTest.cs:line 262
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Content.IntegrationTests.Fixtures.GameTest.DoTeardown()

Trace:


1)    at Content.IntegrationTests.Tests.PostMapInitTest.<>c__DisplayClass21_0.<GameMapsLoadableTest>b__0() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/PostMapInitTest.cs:line 489
   at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.SingleThreadRunUntilEmpty() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1273
   at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.Run() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1237
   at Robust.UnitTesting.RobustIntegrationTest.ServerIntegrationInstance._serverMain() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 773
   at System.Threading.Thread.StartHelper.Callback(Object state)
2)    at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 44
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose()
   at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 146
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync()
   at Content.IntegrationTests.Fixtures.GameTest.DoTeardown() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Fixtures/GameTest.cs:line 262
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Content.IntegrationTests.Fixtures.GameTest.DoTeardown()
❌ GameMapsLoadableTest("StarlightSepultum")
Multiple failures or warnings in test:
  1)   There is no spawnpoints for K9 on StarlightSepultum.
Assert.That(jobs, Is.Empty)
  Expected: <empty>
  But was:  < K9 >
     at Content.IntegrationTests.Tests.PostMapInitTest.<>c__DisplayClass21_0.<GameMapsLoadableTest>b__0() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/PostMapInitTest.cs:line 489
   at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.SingleThreadRunUntilEmpty() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1273
   at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.Run() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1237
   at Robust.UnitTesting.RobustIntegrationTest.ServerIntegrationInstance._serverMain() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 773
   at System.Threading.Thread.StartHelper.Callback(Object state)
  2) Test was dirty-disposed.
     at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 44
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose()
   at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 146
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync()
   at Content.IntegrationTests.Fixtures.GameTest.DoTeardown() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Fixtures/GameTest.cs:line 262
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Content.IntegrationTests.Fixtures.GameTest.DoTeardown()

Trace:


1)    at Content.IntegrationTests.Tests.PostMapInitTest.<>c__DisplayClass21_0.<GameMapsLoadableTest>b__0() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/PostMapInitTest.cs:line 489
   at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.SingleThreadRunUntilEmpty() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1273
   at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.Run() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1237
   at Robust.UnitTesting.RobustIntegrationTest.ServerIntegrationInstance._serverMain() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 773
   at System.Threading.Thread.StartHelper.Callback(Object state)
2)    at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 44
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose()
   at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 146
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync()
   at Content.IntegrationTests.Fixtures.GameTest.DoTeardown() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Fixtures/GameTest.cs:line 262
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Content.IntegrationTests.Fixtures.GameTest.DoTeardown()
❌ GameMapsLoadableTest("StarlightSepultum")
Exception of type 'Microsoft.Testing.Extensions.VSTestBridge.ObjectModel.VSTestException' was thrown.

Trace:


1)    at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 44
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Robust.UnitTesting.Pool.TestPair`2.OnDirtyDispose()
   at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 146
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
   at Robust.UnitTesting.Pool.TestPair`2.DisposeAsync()
   at Content.IntegrationTests.Fixtures.GameTest.DoTeardown() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Fixtures/GameTest.cs:line 262
   at Content.IntegrationTests.Fixtures.GameTest.DoTeardown()
   at InvokeStub_GameTest.DoTeardown(Object, Object, IntPtr*)
Tests 📝 Passed ✅ Failed ❌ Duration ⏱️
1699 1676 3 12m 47s

Github Test Reporter by CTRF 💚

@CawsForConcern CawsForConcern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

  • oasis changes look good
  • test fails real on sepultum

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test fails real on sepultum

failed GameMapsLoadableTest("StarlightSepultum") (44s 118ms)
  Multiple failures or warnings in test:
    1)   There is no spawnpoints for K9 on StarlightSepultum.

@CawsForConcern CawsForConcern added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: Map Changes: No C# Changes: Prototypes S: Awaiting Changes Status: Changes are required before another review can happen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants