Skip to content

Hide the alive icon from medical HUDs - #5949

Open
LightIDX wants to merge 1 commit into
ss14Starlight:starlight-devfrom
LightIDX:alive-icon-begone
Open

Hide the alive icon from medical HUDs#5949
LightIDX wants to merge 1 commit into
ss14Starlight:starlight-devfrom
LightIDX:alive-icon-begone

Conversation

@LightIDX

@LightIDX LightIDX commented Sep 2, 2026

Copy link
Copy Markdown

Short description

Remove the blue cross icon from entities that are alive that the medical HUD displays.

Why we need to add this

It blocks the chat bubbles, it's redundant and annoying. It's obvious when someone is alive.
Health bars are already hidden for healthy entities, so this fits right in.

Media (Video/Screenshots)

Much cleaner!
image

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog
🆑 STARLIGHT TEAM

  • tweak: Medical HUDs no longer display the alive icon

@LightIDX
LightIDX requested a review from a team September 2, 2026 21:14
@github-actions github-actions Bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/XS Changes: C# labels Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 39d782d8-00a7-4cde-b62f-a510030d685b

📥 Commits

Reviewing files that changed from the base of the PR and between ffa0558 and 73e0ee5.

📒 Files selected for processing (1)
  • Content.Shared/Damage/Components/DamageableComponent.cs

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Summary

Summary

Medical HUDs no longer show the blue alive icon for living entities. This reduces visual obstruction near chat bubbles and removes redundant information because healthy entities already hide their health bars.

The change disables the default MobState.Alive icon mapping in DamageableComponent.cs. Critical and dead icons remain unchanged.

Gameplay impact

  • Living entities no longer display the alive icon on medical HUDs.
  • Critical and dead health indicators remain visible.

Risk areas

The change has a narrow scope. Medical HUDs may provide less visual feedback for living entities, but critical and dead states remain distinguishable.

Guideline gaps

  • The PR does not identify a specific Starlight ownership comment for the shared component change.
  • The PR does not state whether localization or breaking-change review is unnecessary.
  • The PR does not document the design decision beyond the general goal of reducing obstruction and redundant information.

Walkthrough

The damageable component no longer maps MobState.Alive to HealthIconFine. Critical and dead health icon mappings remain enabled.

Changes

Health icon mapping

Layer / File(s) Summary
Update health icon state mapping
Content.Shared/Damage/Components/DamageableComponent.cs
The MobState.Alive to HealthIconFine mapping is disabled. Critical and dead mappings remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 73e0e

This localized change removes the redundant alive icon from medical HUDs while retaining critical and dead indicators, with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: redmushie

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: hiding the alive icon from medical HUDs.
Description check ✅ Passed The description directly explains the change, its purpose, and its effect on medical HUDs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Musiklie

Musiklie commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

I like this icon, i would prefer it not removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: C# S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants