Update docker conf#31
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Docker configuration and implements significant frontend improvements including internationalization support, UI redesign with Tailwind CSS, and various bug fixes.
Key Changes
- Added internationalization (i18n) support with German and French translations
- Updated Docker configuration with improved nginx setup and security settings
- Redesigned frontend UI using Tailwind CSS v4 and Flowbite components
- Refactored donation flow with improved modals and form handling
Reviewed changes
Copilot reviewed 41 out of 44 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docker-compose.yml | Updated volume paths and added security sysctls for database |
| Dockerfile | Improved multi-stage build with better caching and dependency management |
| src/nginx/conf/nginx.conf | Enhanced SSL configuration with modern TLS protocols and cipher suites |
| src/frontend/package.json | Upgraded dependencies to latest versions including Tailwind CSS v4 |
| src/frontend/src/lib/i18n/* | Added new i18n system with German and French translations |
| src/frontend/src/routes/* | Updated all route components to use new i18n system and redesigned UI |
| src/frontend/src/routes/donation/* | Refactored donation flow with improved validation and country selection |
| .github/workflows/frontend-CI.yml | Updated CI workflow to generate SvelteKit files before testing |
Comments suppressed due to low confidence (4)
src/nginx/conf/nginx.conf:1
- The upstream name 'db' is misleading as it now points to 'mailcom:3000' which appears to be an application server rather than a database. Consider renaming the upstream block to 'mailcom_backend' or 'app_server' to better reflect its purpose.
src/frontend/src/routes/donation/+page.server.ts:1 - The variable 'country' should be renamed to 'cc' to match the naming convention used elsewhere in the codebase and to be consistent with the database schema field name.
src/frontend/src/routes/global.css:1 - The button text color is set to the same value as the background color (#590d08), making the text invisible. This should likely be a contrasting color such as white or a light shade.
src/frontend/src/routes/donation/+page.svelte:1 - Missing space in German text. Should be 'um fortzufahren' with a comma before 'um'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and some minor fixes