Update translations#37
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request improves the internationalization (i18n) infrastructure by extracting hardcoded German text into translation files and updating French translations. It also adds a team photo, fixes the Docker Compose HTTPS port mapping, and significantly expands the README with comprehensive project documentation.
- Extracts all hardcoded German strings from the donation modal workflow into structured translation keys
- Updates and improves French translations for better accuracy and consistency
- Adds team photo to the team page
- Corrects Docker Compose port mapping from 8443:443 to 443:443 for proper HTTPS configuration
- Expands README from minimal content to comprehensive documentation covering tech stack, deployment, and development setup
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/frontend/src/routes/team/+page.svelte |
Adds team photo image display with responsive styling |
src/frontend/src/routes/donation/+page.svelte |
Replaces all hardcoded German strings with translation keys for proper i18n support |
src/frontend/src/lib/i18n/translations.ts |
Adds comprehensive German and French translation strings for donation modals, alerts, and updated contact descriptions |
docker-compose.yml |
Fixes nginx HTTPS port mapping from 8443 to standard 443 |
README.md |
Transforms basic README into comprehensive documentation with architecture, deployment instructions, and development guide |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <p class="text-center text-gray-700 mt-4">{$t.team.description}</p> | ||
|
|
||
| <div class="flex justify-center mt-8"> | ||
| <img src="/images/Teamfoto_bearbeitet_V1.jpg" alt="MailCom research team" class="max-w-full h-auto rounded-lg shadow-lg" /> |
There was a problem hiding this comment.
The alt text for the team photo is hardcoded in English ("MailCom research team"), but this page supports multiple languages (German and French). Consider extracting this to the translation files to provide proper localized alt text for screen readers and accessibility tools.
| <img src="/images/Teamfoto_bearbeitet_V1.jpg" alt="MailCom research team" class="max-w-full h-auto rounded-lg shadow-lg" /> | |
| <img src="/images/Teamfoto_bearbeitet_V1.jpg" alt="{$t.team.photoAlt}" class="max-w-full h-auto rounded-lg shadow-lg" /> |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
No description provided.