feat: add servicemonitor resource template to helm chart#2128
Open
lmbaschiera wants to merge 3 commits into
Open
feat: add servicemonitor resource template to helm chart#2128lmbaschiera wants to merge 3 commits into
lmbaschiera wants to merge 3 commits into
Conversation
95cf3f5 to
136812b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional Prometheus Operator
ServiceMonitorto the Connaisseur Helm chart so clusters running the operator can scrape Connaisseur's existing/metricsendpoint.charts/connaisseur/templates/servicemonitor.yaml, gated bykubernetes.serviceMonitor.enabled(disabled by default — no impact on existing installs).scheme: https) because Connaisseur serves/metricson the same TLS listener as the webhook, using the webhook serving certificate. Scrape behaviour is configurable via new values:enabled,interval,scrapeTimeout,additionalLabels(to match the Prometheus instance'sserviceMonitorSelector), andtlsConfig(defaults toinsecureSkipVerify: true; users can supply a CA +serverNameto verify).connaisseur.selectorLabelsso it targets the existing Service, and pinsnamespaceSelectorto the release namespace.When enabled without the
monitoring.coreos.com/v1CRD present,helm installfails loudly. This is intentional, as enabling the resource is an explicit opt-in.Checklist
developChart.yaml(if necessary)